1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
Return-Path: <apoelstra@wpsoftware.net>
Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])
by lists.linuxfoundation.org (Postfix) with ESMTP id D8847C0032
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 24 Oct 2023 13:06:00 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
by smtp2.osuosl.org (Postfix) with ESMTP id A416B42ED4
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 24 Oct 2023 13:06:00 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A416B42ED4
Authentication-Results: smtp2.osuosl.org;
dkim=pass (2048-bit key) header.d=mail.wpsoftware.net
header.i=@mail.wpsoftware.net header.a=rsa-sha256 header.s=default
header.b=Q3XhwcBo
X-Virus-Scanned: amavisd-new at osuosl.org
X-Spam-Flag: NO
X-Spam-Score: -1.107
X-Spam-Level:
X-Spam-Status: No, score=-1.107 tagged_above=-999 required=5
tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001]
autolearn=no autolearn_force=no
Received: from smtp2.osuosl.org ([127.0.0.1])
by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id C-Xy31HiA_kQ
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 24 Oct 2023 13:05:58 +0000 (UTC)
Received: from mail.wpsoftware.net (unknown [66.183.0.205])
by smtp2.osuosl.org (Postfix) with ESMTP id 7099B40558
for <bitcoin-dev@lists.linuxfoundation.org>;
Tue, 24 Oct 2023 13:05:58 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7099B40558
Received: from camus (camus-andrew.lan [192.168.0.190])
by mail.wpsoftware.net (Postfix) with ESMTPSA id E5DD7400C8;
Tue, 24 Oct 2023 13:05:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.wpsoftware.net;
s=default; t=1698152757;
bh=8l4q3whx3K2/I8XoZ7VaDOTcVkrhSF3eX3BBd2fuJJ4=;
h=Date:From:To:Cc:Subject:References:In-Reply-To;
b=Q3XhwcBoXXbbLd/20Bd6HNhmEkV6J+4Kvvxx0X0nOvkvV1D0GekAmPdnvrK7RaIz+
eO5fRIYipbESLkO3xj8qavsYZf8Na8fxx6iwTLZO6qH4hh9jGAwyoFNRKXYTdDrZ+0
lJEoHhg6aECxSA44FJKMPT6AmfRz/wibnqsUzdH4QTN2xk0ppCeIFElgSZhHE1tdqC
i54RaTqBUmEoafLdbda7MvTwwZD23JoaS7VUjocmUqqY9DeVdYpZ/7XcZazXyeEoAd
ItcoIc1SL6UkWD4z0kZhfy4o607qz7+FYnMHsGMc678W21OrcPq7ggYdfEanuFHjSl
/KmreLFC8pPjQ==
Date: Tue, 24 Oct 2023 13:05:56 +0000
From: Andrew Poelstra <apoelstra@wpsoftware.net>
To: Rusty Russell <rusty@rustcorp.com.au>
Message-ID: <ZTfBNGipc2O+ojvr@camus>
References: <CAEM=y+XDB7GGa5BTAWrQHqTqQHBE2VRyd7VWjEb+zCOMzRP+Lg@mail.gmail.com>
<871qdmulvt.fsf@rustcorp.com.au> <ZTZ4H2y6+5pxRcs/@camus>
<871qdku9pj.fsf@rustcorp.com.au> <ZTcbKM+XTCaJ2kIP@camus>
<87r0lksmxe.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature"; boundary="r27zWCUS3/qPzAyB"
Content-Disposition: inline
In-Reply-To: <87r0lksmxe.fsf@rustcorp.com.au>
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Proposed BIP for OP_CAT
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2023 13:06:00 -0000
--r27zWCUS3/qPzAyB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Oct 24, 2023 at 02:15:49PM +1030, Rusty Russell wrote:
> Andrew Poelstra <apoelstra@wpsoftware.net> writes:
> > I had a similar thought. But my feeling is that replacing the stack
> > interpreter data structure is still too invasive to justify the benefit.
> >
> > Also, one of my favorite things about this BIP is the tiny diff.
>=20
> To be fair, this diff is even smaller than the OP_CAT diff :)
>
Oh, look at that :). For some reason I had it in my head that looping
like this would mess up the asymptotics and meaningfully harm
performance. But no, it just involves adding (at most) 1000 numbers.
Which is unlikely to even be measurable.
> Though I had to strongly resist refactoring, that interpreter code
> needs a good shake! Using a class for the stack is worth doing anyway
> (macros, really??).
>
Hah, agreed, but it still makes my hands sweat to think about refactoring
that file.
--=20
Andrew Poelstra
Director of Research, Blockstream
Email: apoelstra at wpsoftware.net
Web: https://www.wpsoftware.net/andrew
The sun is always shining in space
-Justin Lewis-Webster
--r27zWCUS3/qPzAyB
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEkPnKPD7Je+ki35VexYjWPOQbl8EFAmU3wTQACgkQxYjWPOQb
l8HHPQf9HpD1urFJl5P78KCrms3+urkH0yOoGoSHBu2wNjFZCVLn0NQyD9i1i1Sq
ZwXQbxOLu6WsQcdy54apKV9GM9b9x+XNfyskkNpPeEGAW7yk0HUCwoDVpGDKyyCj
CbxhmWLARVEWPs6+PWuWiR9xGlgiNDaGUtO5jwL7tiOST8zVhrgfdupDTZIJkBI1
htXTYU15ZNen+XMKVK3DUDP4CuHa7dDaT5/Drzt97FLHGtYXZkQS0AR/zs+Nxrs1
Ui3mQN9HE/Ag+/n4M6Z6mVrEqOl2iSamiZ3agaZSHNminYKKqqMyKe7pDNI+Y9hi
n8pJajmuBG0JwDvuXhBOiP/tCGLArw==
=be6J
-----END PGP SIGNATURE-----
--r27zWCUS3/qPzAyB--
|
