1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
|
Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193]
helo=mx.sourceforge.net)
by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <mh.in.england@gmail.com>) id 1Ws8mw-0008GG-J9
for bitcoin-development@lists.sourceforge.net;
Wed, 04 Jun 2014 10:51:22 +0000
Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com
designates 209.85.214.169 as permitted sender)
client-ip=209.85.214.169; envelope-from=mh.in.england@gmail.com;
helo=mail-ob0-f169.google.com;
Received: from mail-ob0-f169.google.com ([209.85.214.169])
by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1Ws8mu-0007JK-OG
for bitcoin-development@lists.sourceforge.net;
Wed, 04 Jun 2014 10:51:22 +0000
Received: by mail-ob0-f169.google.com with SMTP id vb8so7591539obc.0
for <bitcoin-development@lists.sourceforge.net>;
Wed, 04 Jun 2014 03:51:15 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.60.83.232 with SMTP id t8mr55761551oey.16.1401879075077;
Wed, 04 Jun 2014 03:51:15 -0700 (PDT)
Sender: mh.in.england@gmail.com
Received: by 10.76.71.162 with HTTP; Wed, 4 Jun 2014 03:51:15 -0700 (PDT)
In-Reply-To: <538EF81D.9060301@stud.uni-saarland.de>
References: <1401822421.27942.YahooMailNeo@web124505.mail.ne1.yahoo.com>
<CANEZrP18nf0oK6fbnE59opXxfMdwiOOu4v99iGyXyGo_7NLuYA@mail.gmail.com>
<CAAS2fgTM30oFLGpkCwqM5Wf-Crmz5s05X-uWXAiGy9u43nbKvQ@mail.gmail.com>
<538EF81D.9060301@stud.uni-saarland.de>
Date: Wed, 4 Jun 2014 18:51:15 +0800
X-Google-Sender-Auth: A3RWR_sDcBR7x-l1yNLE-HPOsks
Message-ID: <CANEZrP1nEwro7ZSATEW3-TkRyF+gxBbW9D8KkY=VaQL8kxPSUg@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: Jannis Froese <s9jafroe@stud.uni-saarland.de>
Content-Type: multipart/alternative; boundary=089e01182c8a49d6ea04fb0068d4
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(mh.in.england[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
1.0 HTML_MESSAGE BODY: HTML included in message
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1Ws8mu-0007JK-OG
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] # error "Bitcoin cannot be compiled
without assertions." <<<<NOT
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Wed, 04 Jun 2014 10:51:22 -0000
--089e01182c8a49d6ea04fb0068d4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Currently expensive checks are guarded with command line flags. It'd be
nice if there could be one unified command line flag -expensivechecks that
subsumes -checkmempool and so on.
On Wed, Jun 4, 2014 at 6:42 PM, Jannis Froese <s9jafroe@stud.uni-saarland.d=
e
> wrote:
> There are reasons to have assertions enabled by default in software like
> Bitcoin Core, where incorrect behaviour can be costly. But this comes at =
a
> prize: our assertions have to satisfy certain performance requirements.
> It's no longer possible to do expensive, redundant checks in performance
> critical code, which is one of the main advantages of asserts. Imho,
> asserts are not intended for small range checks etc, but are meant for
> checks that a hash hasn't changed, that a tree structure is still a tree,
> that data is still sorted, or that data structures are in sync.
>
> I think most concerns about the current use of asserts would be resolved
> if the currently used asserts would be changed to a nicer definition whic=
h
> is independent of NDEBUG, and a second class of debugging asserts would b=
e
> introduced, which is exclusively for expensive, redundant checks and is
> disabled by NDEBUG.
>
>
>
> Am 2014-06-04 12:15, schrieb Gregory Maxwell:
>
> On Wed, Jun 4, 2014 at 2:51 AM, Mike Hearn <mike@plan99.net> wrote:
>
>> Hi Ron,
>>
>> FYI your mail is being spamfoldered due to Yahoo's DMARC policy and the
>> brokenness of the SF.net mailing list software. I would not expect to ge=
t
>> replies reliably whilst this is the case. I think we should move away fr=
om
>> SF.net for hosting mailing lists personally, because it's this list that=
's
>> at fault not Yahoo, but until then you may wish to send to the list with=
a
>> different email address.
>>
>> As to your question,
>>
>> assert() should have *no* side effects, that is the problem.
>>>
>>> See
>>>
>>> http://books.google.com/books?id=3DL5ZbzVnpkXAC&pg=3DPA72&lpg=3DPA72&dq=
=3DGotcha+%2328+Side+Effects&source=3Dbl&ots=3DRn15TlPmje&sig=3DtymHqta0aSA=
NwaM2GaXC-1Di_tk&hl=3Den&sa=3DX&ei=3DuVKNU47fCcvTsAT6goHIBA&ved=3D0CCAQ6AEw=
AA#v=3Donepage&q=3DGotcha%20%2328%20Side%20Effects&f=3Dfalse
>>>
>>> a great book, BTW. Everyone who thinks they know what they are doing
>>> when they write C++ should read this book! They will realize that they
>>> don't know Jack [image: Roll Eyes]
>>>
>>> Why weren't these and all the other examples of amateur, i.e.,
>>> non-professional, software fixed way back in version 0.3.0 in 2010, bef=
ore
>>> any more releases were done? And why were these and other sub-standard
>>> coding practices continued and expanded in later releases, right up unt=
il
>>> the present?
>>>
>>
>> Back in 2010 most code was still being written by Satoshi so perhaps
>> you should ask him. Regardless, it's very common for professional codeba=
ses
>> to require assertions be enabled. For example the entire Google C++
>> codebase uses always-on assertions that have side effects liberally: it'=
s
>> convenient and safe, when you have the guarantee the code will always ru=
n,
>> and the performance benefits of compiling out assertions are usually
>> non-existent.
>>
>> So for this reason I think Bitcoin Core currently will fail to build if
>> assertions are disabled, and that seems OK to me.
>>
>
> As a matter of procedure we do not use assertions with side effects=E2=
=80=94 the
> codebase did at one point, but have cleaned them up. In an abundance of
> caution we also made it refuse to compile without assertions enabled: A
> decision who's wisdom was clearly demonstrated when not long after, some
> additional side-effect having assert was contributed. In the real world
> errors happen here and there, and making robust software involves defense
> in depth.
>
> Considering the normal criticality of the software it should always be
> with the assertions. Without them is an untested configuration. It would
> probably be superior to use our own assertion macros (for one, they can
> give some better reporting=E2=80=A6) that don't have the baggage ordinary
> assertions have, but as a the codebase is a production thing, making larg=
er
> changes all at once to satisfy aesthetics would be unwise... simply
> refusing to compile in that untested, unsupported configuration is pruden=
t,
> for the time being.
>
>
>
> -------------------------------------------------------------------------=
-----
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and thei=
r
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!http:/=
/p.sf.net/sfu/NeoTech
>
>
>
> _______________________________________________
> Bitcoin-development mailing listBitcoin-development@lists.sourceforge.net=
https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
>
>
> -------------------------------------------------------------------------=
-----
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and thei=
r
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/NeoTech
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
--089e01182c8a49d6ea04fb0068d4
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Currently expensive checks are guarded with command line f=
lags. It'd be nice if there could be one unified command line flag -exp=
ensivechecks that subsumes -checkmempool and so on.</div><div class=3D"gmai=
l_extra">
<br><br><div class=3D"gmail_quote">On Wed, Jun 4, 2014 at 6:42 PM, Jannis F=
roese <span dir=3D"ltr"><<a href=3D"mailto:s9jafroe@stud.uni-saarland.de=
" target=3D"_blank">s9jafroe@stud.uni-saarland.de</a>></span> wrote:<br>=
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
=20
=20
=20
<div text=3D"#000000" bgcolor=3D"#FFFFFF">
<div>There are reasons to have assertions
enabled by default in software like Bitcoin Core, where incorrect
behaviour can be costly. But this comes at a prize: our assertions
have to satisfy certain performance requirements. It's no longer
possible to do expensive, redundant checks in performance critical
code, which is one of the main advantages of asserts. Imho,
asserts are not intended for small range checks etc, but are meant
for checks that a hash hasn't changed, that a tree structure is
still a tree, that data is still sorted, or that data structures
are in sync.<br>
<br>
I think most concerns about the current use of asserts would be
resolved if the currently used asserts would be changed to a nicer
definition which is independent of NDEBUG, and a second class of
debugging asserts would be introduced, which is exclusively for
expensive, redundant checks and is disabled by NDEBUG.<br>
<br>
<br>
<br>
Am 2014-06-04 12:15, schrieb Gregory Maxwell:<br>
</div>
<blockquote type=3D"cite"><div><div class=3D"h5">
<div dir=3D"ltr">On Wed, Jun 4, 2014 at 2:51 AM, Mike Hearn <span dir=
=3D"ltr"><<a href=3D"mailto:mike@plan99.net" target=3D"_blank">mike@plan=
99.net</a>></span>
wrote:<br>
<div class=3D"gmail_extra">
<div class=3D"gmail_quote">
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo=
rder-left:1px #ccc solid;padding-left:1ex">
<div dir=3D"ltr">Hi Ron,
<div><br>
</div>
<div>FYI your mail is being spamfoldered due to Yahoo's
DMARC policy and the brokenness of the SF.net mailing
list software. I would not expect to get replies
reliably whilst this is the case. I think we should
move away from SF.net for hosting mailing lists
personally, because it's this list that's at faul=
t not
Yahoo, but until then you may wish to send to the list
with a different email address.</div>
<div><br>
</div>
<div>As to your question,</div>
<div class=3D"gmail_extra">
<div class=3D"gmail_quote"><br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0=
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style=3D"color:#000;background-color:#fff;font=
-family:Courier New,courier,monaco,monospace,sans-serif;font-size:10pt">
<div>
<div>
<div style=3D"color:#000;background-color:#ff=
f;font-family:Courier New,courier,monaco,monospace,sans-serif;font-size:10p=
t">
<div style=3D"color:rgb(0,0,0);font-size:13=
.3333px;font-family:Courier New,courier,monaco,monospace,sans-serif;backgro=
und-color:transparent;font-style:normal">
<tt>assert() </tt>should have <span style=
=3D"text-decoration:underline"><b>no</b></span>
side effects, that is the problem.<br>
<br>
See<br>
<a rel=3D"nofollow" href=3D"http://books.=
google.com/books?id=3DL5ZbzVnpkXAC&pg=3DPA72&lpg=3DPA72&dq=3DGo=
tcha+%2328+Side+Effects&source=3Dbl&ots=3DRn15TlPmje&sig=3DtymH=
qta0aSANwaM2GaXC-1Di_tk&hl=3Den&sa=3DX&ei=3DuVKNU47fCcvTsAT6goH=
IBA&ved=3D0CCAQ6AEwAA#v=3Donepage&q=3DGotcha%20%2328%20Side%20Effec=
ts&f=3Dfalse" target=3D"_blank">http://books.google.com/books?id=3DL5Zb=
zVnpkXAC&pg=3DPA72&lpg=3DPA72&dq=3DGotcha+%2328+Side+Effects&am=
p;source=3Dbl&ots=3DRn15TlPmje&sig=3DtymHqta0aSANwaM2GaXC-1Di_tk&am=
p;hl=3Den&sa=3DX&ei=3DuVKNU47fCcvTsAT6goHIBA&ved=3D0CCAQ6AEwAA#=
v=3Donepage&q=3DGotcha%20%2328%20Side%20Effects&f=3Dfalse</a><br>
<br>
a great book, BTW.=C2=A0 Everyone who
thinks they know what they are doing
when they write C++ should read this
book!=C2=A0 They will realize that they
don't know Jack <img alt=3D"Roll
Eyes" border=3D"0"></div>
<div style=3D"color:rgb(0,0,0);font-size:13=
.3333px;font-family:Courier New,courier,monaco,monospace,sans-serif;backgro=
und-color:transparent;font-style:normal">
<br>
</div>
<div style=3D"color:rgb(0,0,0);font-size:13=
.3333px;font-family:Courier New,courier,monaco,monospace,sans-serif;backgro=
und-color:transparent;font-style:normal">Why
weren't these and all the other
examples of amateur, i.e.,
non-professional, software fixed way
back in version 0.3.0 in 2010, before
any more releases were done?=C2=A0 And wh=
y
were these and other sub-standard
coding practices continued and
expanded in later releases, right up
until the present? <br>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>Back in 2010 most code was still being written
by Satoshi so perhaps you should ask him.
Regardless, it's very common for professional
codebases to require assertions be enabled. For
example the entire Google C++ codebase uses
always-on assertions that have side effects
liberally: it's convenient and safe, when you hav=
e
the guarantee the code will always run, and the
performance benefits of compiling out assertions
are usually non-existent.</div>
<div><br>
</div>
<div>So for this reason I think Bitcoin Core
currently will fail to build if assertions are
disabled, and that seems OK to me.</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>As a matter of procedure we do not use assertions with
side effects=E2=80=94 the codebase did at one point, but have
cleaned them up.=C2=A0 In an abundance of caution we also mad=
e
it refuse to compile without assertions enabled: A
decision who's wisdom was clearly demonstrated when not
long after, some additional side-effect having assert was
contributed. In the real world errors happen here and
there, and making robust software involves defense in
depth.<br>
<br>
</div>
<div>Considering the normal criticality of the software it
should always be with the assertions. Without them is an
untested configuration.=C2=A0 It would probably be superior t=
o
use our own assertion macros (for one, they can give some
better reporting=E2=80=A6) that don't have the baggage or=
dinary
assertions have, but as a the codebase is a production
thing, making larger changes all at once to satisfy
aesthetics would be unwise... simply refusing to compile
in that untested, unsupported configuration is prudent,
for the time being.<br>
<br>
</div>
</div>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div></div><pre>----------------------------------------------------=
--------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases =
and their=20
applications. Written by three acclaimed leaders in the field,=20
this first edition is now available. Download your free book today!
<a href=3D"http://p.sf.net/sfu/NeoTech" target=3D"_blank">http://p.sf.net/s=
fu/NeoTech</a></pre>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Bitcoin-development mailing list
<a href=3D"mailto:Bitcoin-development@lists.sourceforge.net" target=3D"_bla=
nk">Bitcoin-development@lists.sourceforge.net</a>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development=
" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de=
velopment</a>
</pre>
</blockquote>
<br>
</div>
<br>-----------------------------------------------------------------------=
-------<br>
Learn Graph Databases - Download FREE O'Reilly Book<br>
"Graph Databases" is the definitive new guide to graph databases =
and their<br>
applications. Written by three acclaimed leaders in the field,<br>
this first edition is now available. Download your free book today!<br>
<a href=3D"http://p.sf.net/sfu/NeoTech" target=3D"_blank">http://p.sf.net/s=
fu/NeoTech</a><br>_______________________________________________<br>
Bitcoin-development mailing list<br>
<a href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-develo=
pment@lists.sourceforge.net</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development=
" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de=
velopment</a><br>
<br></blockquote></div><br></div>
--089e01182c8a49d6ea04fb0068d4--
|
