1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
|
Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194]
helo=mx.sourceforge.net)
by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
(envelope-from <toshi@peernova.com>) id 1WrrsW-00016f-3X
for bitcoin-development@lists.sourceforge.net;
Tue, 03 Jun 2014 16:48:00 +0000
Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of peernova.com
designates 209.85.128.182 as permitted sender)
client-ip=209.85.128.182; envelope-from=toshi@peernova.com;
helo=mail-ve0-f182.google.com;
Received: from mail-ve0-f182.google.com ([209.85.128.182])
by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
(Exim 4.76) id 1WrrsU-0004An-Vo
for bitcoin-development@lists.sourceforge.net;
Tue, 03 Jun 2014 16:48:00 +0000
Received: by mail-ve0-f182.google.com with SMTP id sa20so7245458veb.41
for <bitcoin-development@lists.sourceforge.net>;
Tue, 03 Jun 2014 09:47:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:date
:message-id:subject:from:to:cc:content-type;
bh=VcpLWYwUIy6AiwpXLj4D+V1+GIueLP+MJlKgGr5OMAo=;
b=hOmHOLtMeFS1hfXwsj+nR0M0+PO2QclUj1tXpAZwdHZ6hVCjt3gNqq1dmYR3FXUVHS
YGrkW9MaP+qc/t3QGS0Vx1SdZXWCjgmy+ErhNgSK956gl5XcIx1xfBn6hSZ3D7mBRIee
HZ28IyXGC+HSNXeN9kjLoAKT1m3jjaTMnwCSVTRsRLQv1K2fWx2/NDeS1qM0GGOlOa7d
QAXTWvLuvhkkl3LtH+UFwjjdlTH8seox/xvP7H7wQ79H9PlPkGCl41NCUUjaCenxlo86
id9Ws4cZkDlMlk7mCTszFtUmxA4jjXsObTrd4dWf2wFNqPel8vtxIH3NrOSwo2gpbTAn
ZHoA==
X-Gm-Message-State: ALoCoQn3SoYPGOFGpLPXjRQLnwBOAm+8pxCy/9hUl21FQet+I731hGo7SeUmh3SO8nFk2ghToRTD
MIME-Version: 1.0
X-Received: by 10.58.29.16 with SMTP id f16mr38480666veh.23.1401814073191;
Tue, 03 Jun 2014 09:47:53 -0700 (PDT)
Received: by 10.52.97.37 with HTTP; Tue, 3 Jun 2014 09:47:53 -0700 (PDT)
In-Reply-To: <CAJHLa0OiFCX_CT-OLBaFHB5SGL0ADsXm7gQrsRs7inu=qM1E6g@mail.gmail.com>
References: <CANFXpYOdmweoxXRM_LcnB-jFNHt8kj_B0jTFZ00Jffi7UHvwPA@mail.gmail.com>
<CAJHLa0OiFCX_CT-OLBaFHB5SGL0ADsXm7gQrsRs7inu=qM1E6g@mail.gmail.com>
Date: Tue, 3 Jun 2014 09:47:53 -0700
Message-ID: <CANFXpYOFcYtt_PS4RNmiXdcNbLbY5S29aO14sP8fK+GN3ivNYg@mail.gmail.com>
From: Toshi Morita <toshi@peernova.com>
To: Jeff Garzik <jgarzik@bitpay.com>
Content-Type: multipart/alternative; boundary=047d7b6dd084dfb89104faf14509
X-Spam-Score: -0.5 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
sender-domain
-0.0 SPF_PASS SPF: sender matches SPF record
1.0 HTML_MESSAGE BODY: HTML included in message
X-Headers-End: 1WrrsU-0004An-Vo
Cc: bitcoin-development <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Another uninitialized memory problem
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 03 Jun 2014 16:48:00 -0000
--047d7b6dd084dfb89104faf14509
Content-Type: text/plain; charset=UTF-8
I looked at this a bit more yesterday, and it looks like both sides of the
comparison were uninitialized, and I fixed one side, but the other side has
the same problem.
I'll try to investigate further this afternoon once I get out of
meetings/meetings prep.
Toshi
On Tue, Jun 3, 2014 at 9:43 AM, Jeff Garzik <jgarzik@bitpay.com> wrote:
> I think I see the problem.
>
>
> On Mon, Jun 2, 2014 at 4:01 PM, Toshi Morita <toshi@peernova.com> wrote:
> > I'm seeing another uninitialized memory problem in bitcoind using
> valgrind:
> >
> > tm@tm-VirtualBox:~/bitcoind/bitcoin/src$ valgrind ./bitcoind
> > ==2337== Memcheck, a memory error detector
> > ==2337== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
> > ==2337== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright
> info
> > ==2337== Command: ./bitcoind
> > ==2337==
> > ==2337== Conditional jump or move depends on uninitialised value(s)
> > ==2337== at 0x319176: CWallet::LoadKeyMetadata(CPubKey const&,
> > CKeyMetadata const&) (wallet.cpp:110)
> > ==2337== by 0x33645A: ReadKeyValue(CWallet*, CDataStream&,
> CDataStream&,
> > CWalletScanState&, std::string&, std::string&) (walletdb.cpp:509)
> > ==2337== by 0x3374F0: CWalletDB::LoadWallet(CWallet*)
> (walletdb.cpp:623)
> > ==2337== by 0x3218FD: CWallet::LoadWallet(bool&) (wallet.cpp:1485)
> > ==2337== by 0x157F16: AppInit2(boost::thread_group&) (init.cpp:958)
> > ==2337== by 0x140142: AppInit(int, char**) (bitcoind.cpp:143)
> > ==2337== by 0x13649E: main (bitcoind.cpp:180)
> > ==2337==
> >
> >
> >
> ------------------------------------------------------------------------------
> > Learn Graph Databases - Download FREE O'Reilly Book
> > "Graph Databases" is the definitive new guide to graph databases and
> their
> > applications. Written by three acclaimed leaders in the field,
> > this first edition is now available. Download your free book today!
> > http://p.sf.net/sfu/NeoTech
> > _______________________________________________
> > Bitcoin-development mailing list
> > Bitcoin-development@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/bitcoin-development
> >
>
>
>
> --
> Jeff Garzik
> Bitcoin core developer and open source evangelist
> BitPay, Inc. https://bitpay.com/
>
--047d7b6dd084dfb89104faf14509
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">I looked at this a bit more yesterday, and it looks like b=
oth sides of the comparison were uninitialized, and I fixed one side, but t=
he other side has the same problem.<div><br></div><div>I'll try to inve=
stigate further this afternoon once I get out of meetings/meetings prep.</d=
iv>
<div><br></div><div>Toshi</div><div><br></div></div><div class=3D"gmail_ext=
ra"><br><br><div class=3D"gmail_quote">On Tue, Jun 3, 2014 at 9:43 AM, Jeff=
Garzik <span dir=3D"ltr"><<a href=3D"mailto:jgarzik@bitpay.com" target=
=3D"_blank">jgarzik@bitpay.com</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">I think I see the problem.<br>
<div><div class=3D"h5"><br>
<br>
On Mon, Jun 2, 2014 at 4:01 PM, Toshi Morita <<a href=3D"mailto:toshi@pe=
ernova.com">toshi@peernova.com</a>> wrote:<br>
> I'm seeing another uninitialized memory problem in bitcoind using =
valgrind:<br>
><br>
> tm@tm-VirtualBox:~/bitcoind/bitcoin/src$ valgrind ./bitcoind<br>
> =3D=3D2337=3D=3D Memcheck, a memory error detector<br>
> =3D=3D2337=3D=3D Copyright (C) 2002-2012, and GNU GPL'd, by Julian=
Seward et al.<br>
> =3D=3D2337=3D=3D Using Valgrind-3.8.1 and LibVEX; rerun with -h for co=
pyright info<br>
> =3D=3D2337=3D=3D Command: ./bitcoind<br>
> =3D=3D2337=3D=3D<br>
> =3D=3D2337=3D=3D Conditional jump or move depends on uninitialised val=
ue(s)<br>
> =3D=3D2337=3D=3D =C2=A0 =C2=A0at 0x319176: CWallet::LoadKeyMetadata(CP=
ubKey const&,<br>
> CKeyMetadata const&) (wallet.cpp:110)<br>
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x33645A: ReadKeyValue(CWallet*, CDat=
aStream&, CDataStream&,<br>
> CWalletScanState&, std::string&, std::string&) (walletdb.c=
pp:509)<br>
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x3374F0: CWalletDB::LoadWallet(CWall=
et*) (walletdb.cpp:623)<br>
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x3218FD: CWallet::LoadWallet(bool&am=
p;) (wallet.cpp:1485)<br>
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x157F16: AppInit2(boost::thread_grou=
p&) (init.cpp:958)<br>
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x140142: AppInit(int, char**) (bitco=
ind.cpp:143)<br>
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x13649E: main (bitcoind.cpp:180)<br>
> =3D=3D2337=3D=3D<br>
><br>
><br>
</div></div>> ----------------------------------------------------------=
--------------------<br>
> Learn Graph Databases - Download FREE O'Reilly Book<br>
> "Graph Databases" is the definitive new guide to graph datab=
ases and their<br>
> applications. Written by three acclaimed leaders in the field,<br>
> this first edition is now available. Download your free book today!<br=
>
> <a href=3D"http://p.sf.net/sfu/NeoTech" target=3D"_blank">http://p.sf.=
net/sfu/NeoTech</a><br>
> _______________________________________________<br>
> Bitcoin-development mailing list<br>
> <a href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-d=
evelopment@lists.sourceforge.net</a><br>
> <a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-develo=
pment" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitco=
in-development</a><br>
><br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
<br>
<br>
--<br>
Jeff Garzik<br>
Bitcoin core developer and open source evangelist<br>
BitPay, Inc. =C2=A0 =C2=A0 =C2=A0<a href=3D"https://bitpay.com/" target=3D"=
_blank">https://bitpay.com/</a><br>
</font></span></blockquote></div><br></div>
--047d7b6dd084dfb89104faf14509--
|
