1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
|
Return-Path: <aymeric@peersm.com>
Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])
by lists.linuxfoundation.org (Postfix) with ESMTP id C7466C002A
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 20 Apr 2023 14:25:36 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
by smtp3.osuosl.org (Postfix) with ESMTP id A16A06FEFB
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 20 Apr 2023 14:25:36 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A16A06FEFB
X-Virus-Scanned: amavisd-new at osuosl.org
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5
tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001,
RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001]
autolearn=ham autolearn_force=no
Received: from smtp3.osuosl.org ([127.0.0.1])
by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id 86kAc3nLpGX6
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 20 Apr 2023 14:25:34 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.8.0
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1B7036FEFA
Received: from 7.mo548.mail-out.ovh.net (7.mo548.mail-out.ovh.net
[46.105.33.25])
by smtp3.osuosl.org (Postfix) with ESMTPS id 1B7036FEFA
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 20 Apr 2023 14:25:33 +0000 (UTC)
Received: from mxplan6.mail.ovh.net (unknown [10.108.4.188])
by mo548.mail-out.ovh.net (Postfix) with ESMTPS id A23E8214A4;
Thu, 20 Apr 2023 14:25:31 +0000 (UTC)
Received: from peersm.com (37.59.142.107) by DAG6EX2.mxp6.local (172.16.2.52)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 20 Apr
2023 16:25:30 +0200
Authentication-Results: garm.ovh; auth=pass
(GARM-107S0012533c719-6501-4944-ac1f-1f10a18bff76,
5E17EACF1FF56CB846BCCF407048ED344BBC7385) smtp.auth=aymeric@peersm.com
X-OVh-ClientIp: 92.184.112.152
To: Erik Aronesty <erik@q32.com>, Bitcoin Protocol Discussion
<bitcoin-dev@lists.linuxfoundation.org>
References: <uuq_VbxJp50_-m4ufKpEhJOknhZ0pvK8ioDabCkxtDjBYauO3gLKrj2O2tjS6YIFOnJLyaZg6-LENzom1DyQQ3TyMLIIaGz5IRrzrKB8gRs=@protonmail.com>
<feef7f88-b46d-7355-1716-122afc6359ee@achow101.com>
<cfa83206-4ea7-5949-9db4-99fc495641a4@peersm.com>
<CAJowKgLh1zS+fFvkVZTLXiqHQ8QMOqxCVooGpby3_o8EHxoihA@mail.gmail.com>
From: Aymeric Vitte <aymeric@peersm.com>
Message-ID: <c9339ca3-d2d1-8006-fef2-c9e9479fb2ce@peersm.com>
Date: Thu, 20 Apr 2023 16:25:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAJowKgLh1zS+fFvkVZTLXiqHQ8QMOqxCVooGpby3_o8EHxoihA@mail.gmail.com>
Content-Type: multipart/alternative;
boundary="------------D058FDA76903754188A4C509"
X-Originating-IP: [37.59.142.107]
X-ClientProxiedBy: DAG8EX1.mxp6.local (172.16.2.71) To DAG6EX2.mxp6.local
(172.16.2.52)
X-Ovh-Tracer-GUID: 5dcf1ee5-3ebe-4ddc-8aae-1d4daa6dad4d
X-Ovh-Tracer-Id: 5429933775854986205
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtvddgjeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhevhffkffgfgggjtghisegrtderredtfeejnecuhfhrohhmpeethihmvghrihgtucggihhtthgvuceorgihmhgvrhhitgesphgvvghrshhmrdgtohhmqeenucggtffrrghtthgvrhhnpefhteehhfdtjeejffduleeijeegheelueetjefguefgvdehgfektefhjeevudduhfenucffohhmrghinhepuhhtgihoshdrohhrghdpghhithhhuhgsrdgtohhmpdhlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgpdhpvggvrhhsmhdrtghomhdplhhinhhkvgguihhnrdgtohhmnecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutdejpdelvddrudekgedrudduvddrudehvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoegrhihmvghrihgtsehpvggvrhhsmhdrtghomheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhishhtshesrggthhhofidutddurdgtohhmpdgsihhttghoihhnqdguvghvsehlihhsthhsrdhlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgpdgvrhhikhesqhefvddrtghomhdpoffvtefjohhsthepmhhoheegkedpmh
houggvpehsmhhtphhouhht
X-Mailman-Approved-At: Fri, 21 Apr 2023 12:13:10 +0000
Subject: Re: [bitcoin-dev] Bitcoin Core maintainers and communication on
merge decisions
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Apr 2023 14:25:36 -0000
--------------D058FDA76903754188A4C509
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Right, that's why I do not participate any longer, they specify things
for the participants (ie big companies), they disregard whatever
suggestion can be made, they are so slow that when they have specified
something someone else has specified something better, then they throw
away their spec and take what the others have specified
And they are wrong in many design decisions
What I meant is that bitcoin big companies should involve people, who
are not just discussing stupid things all the day like W3C folks but do
the work efficiently
Le 20/04/2023 =C3=A0 15:59, Erik Aronesty a =C3=A9crit :
> i think the w3c is a very good example of a slow train wreck, and we
> should do everything possible to avoid the decisions they made=20
>
> On Thu, Apr 20, 2023 at 7:09=E2=80=AFAM Aymeric Vitte via bitcoin-dev
> <bitcoin-dev@lists.linuxfoundation.org
> <mailto:bitcoin-dev@lists.linuxfoundation.org>> wrote:
>
> Personnally I will never criticize the maintainers, but my comment =
was
> about the global process, I thought that for something important li=
ke
> bitcoin there were many devs/maintainers, and as you point out, a P=
R
> must be done by certified people
>
> I don't get very well why every company involved in bitcoin do not =
put
> at least one person in this process (a bit like W3C specs), with
> different time zone so every time you wake up you don't have to loo=
k
> at/handle hundreds of requests/comments
>
> And we can read in the press that bitcoin maintenance is supposed t=
o
> cost 200M per year, probably false then, but this is worrying to se=
e
> that devs/maintainers are stepping down one after the other
>
>
> Le 19/04/2023 =C3=A0 23:33, Andrew Chow via bitcoin-dev a =C3=A9cri=
t :
> > Responses in-line.
> > Note that the opinions expressed in this email are my own and
> are not
> > representative of what other maintainers think or believe.
> >
> > On 04/18/2023 08:40 AM, Michael Folkson via bitcoin-dev wrote:
> > >
> > > Communication has been a challenge on Bitcoin Core for what I =
can
> > tell the entire history of the project. Maintainers merge a pull
> request
> > and provide no commentary on why they=E2=80=99ve merged it.
> >
> > What commentary does there need to be?
> > It's self evident that the maintainer believes the code is ready
> to be
> > merged, and has observed enough ACKs from contributors that they =
are
> > comfortable to do so.
> > You're welcome to ask for clarification, but frankly, I don't thi=
nk
> > having any commentary on merges is going to be helpful or more
> elaborate
> > in any way.
> > Requiring maintainers to have to write explanations for every sin=
gle
> > merge is simply going to increase the burden on them and
> increase the
> > rate of burnout and resignations.
> > We've had too many maintainers step down already.
> > It'll end up being a bunch of boilerplate comments that don't say=
> > anything meaningful.
> >
> > There are certainly situations where PRs are merged very quickly
> or with
> > otherwise little apparent review.
> > But, as I said, if you ask a maintainer why it was merged, the
> answer
> > will be "I thought it was ready and had enough review".
> > There may be other reasons that made the maintainer think it was
> ready
> > sooner, such as the PR fixes a critical bug or security
> vulnerability,
> > but these reasons aren't going to be stated publicly.
> >
> > > Maintainers leave a pull request with many ACKs and few (if an=
y)
> > NACKs for months and provide no commentary on why they haven't
> merged it.
> >
> > There are currently 320 open PRs and 366 open issues.
> > I wake up every morning to 150+ email notifications containing
> > everything that went on overnight, and throughout the day, I
> typically
> > get hundreds more.
> > It's impossible to keep up with everything that goes on
> throughout the repo.
> > ACKs come in sporadically, PRs are updated, reviews are posted, e=
tc.
> > Often times PRs are not merged simply because the maintainers
> were not
> > aware that a PR was ready to be merged.
> > Things can simply fall through the cracks.
> >
> > Of course there are other reasons why something might not be
> merged, and
> > these generally fall into the camp of "I don't think it has had
> enough
> > review".
> > It's the maintainer's judgement call to make as to whether
> something has
> > been sufficiently reviewed, and part of the judgement call is to
> > consider the quality and competence of the reviewers.
> > If a PR had 100 ACKs but all from random people who have never
> > contributed to the project in any capacity, then it's not going
> to be
> > merged because those reviewers would be considered low quality.
> > It's not just about the numbers, but also about whether the
> reviewers
> > are people the maintainers think are familiar enough with an
> area and
> > have had a history of thoroughly reviewing PRs.
> > For example, if a reviewer who primarily works on the mempool
> reviewed a
> > PR in the wallet, I would consider their review and ACK with
> less weight
> > because they are unlikely to be familiar with the intricacies of
> the wallet.
> > Obviously that changes over time as they make more reviews.
> > For another example, if I see an ACK from a reviewer who posts
> reviews
> > that primarily contain nits on code style and other trivialities,=
I
> > would consider that ACK with less weight.
> >
> > Furthermore, the maintainers are not necessarily the ones who
> block a merge.
> > Part of evaluating if something is ready to be merged is to read =
the
> > comments on a PR.
> > Other frequent contributors may have commented or asked
> questions that
> > haven't been resolved yet.
> > PRs will often not be merged (even if they have ACKs) until a
> maintainer
> > deems that those comments and questions have been sufficiently
> resolved,
> > typically with the commenter stating in some way that their conce=
rns
> > were addressed.
> > In these situations, no commentary from maintainers is given nor
> > necessary as it should be self evident (by reading the comments)
> that
> > something is controversial.
> > These kinds of comments are not explicit NACKs (so someone who
> is only
> > counting (N)ACKs won't see them), but are blocking nonetheless.
> >
> > Lastly, personally I like to review every PR before I merge it.
> > This often means that a PR that might otherwise be ready to be
> merged
> > wouldn't be merged by myself as I may not be familiar with that
> part of
> > the codebase.
> > It may also mean that I would require more or specific
> additional people
> > to review a PR before I merge it as I would weight my own review
> less
> > heavily.
> > With several long time maintainers stepping away, this may be a
> factor
> > in PRs taking longer to get merged as the remaining maintainers
> may be
> > less familiar with the parts of the codebase that were previously=
> > maintained by someone else.
> >
> > > but a casual observer would have only seen Concept ACKs and
> ACKs with
> > 3 stray NACKs. Many of these casual observers inflated the
> numbers on
> > the utxos.org <http://utxos.org> site [4] signalling support for
> a soft fork activation
> > attempt.
> >
> > Anyone who thinks that maintainers only look at the numbers of
> (N)ACKs
> > is delusional.
> > As I explained above, there is a whole lot more nuance to
> determining
> > even just the status of the opinions on a PR, nevermind the code
> itself.
> >
> > In this specific example of a soft fork, there is also
> consideration of
> > the opinions outside of the repo itself, such as on this mailing
> list
> > and elsewhere that people discuss soft forks.
> >
> > On 04/19/2023 11:17 AM, Aymeric Vitte via bitcoin-dev wrote:
> > > While some simple changes can allow bitcoin to surpass
> ethereum, as
> > usual, like "Allow several OP_RETURN in one tx and no limited siz=
e"
> > https://github.com/bitcoin/bitcoin/issues/27043
> > >
> > > How long it will take remains mysterious
> >
> > No one (maintainers or contributors) is obligated to implement
> anything.
> > A feature request not being implemented is because the people who=
do
> > open PRs are either not interested in implementing the feature,
> or are
> > working on other things that they believe to be higher priority.
> > If there is a feature that you want, then you will often need to
> either
> > to it yourself, or pay someone to do it for you.
> >
> > Additionally, a feature may seem like a good idea to you, but
> there are
> > often interactions with other things that may end up resulting in=
it
> > being rejected or need significant revision, especially for
> something
> > which affects transaction relay.
> >
> >
> >
> > Andrew Chow
> >
> > _______________________________________________
> > bitcoin-dev mailing list
> > bitcoin-dev@lists.linuxfoundation.org
> <mailto:bitcoin-dev@lists.linuxfoundation.org>
> > https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>
> --=20
> Sophia-Antipolis, France
> CV: https://www.peersm.com/CVAV.pdf
> LinkedIn: https://fr.linkedin.com/in/aymeric-vitte-05855b26
> GitHub : https://www.github.com/Ayms
> A Universal Coin Swap system based on Bitcoin:
> https://gist.github.com/Ayms/029125db2583e1cf9c3209769eb2cdd7
> A bitcoin NFT system:
> https://gist.github.com/Ayms/01dbfebf219965054b4a3beed1bfeba7
> Move your coins by yourself (browser version):
> https://peersm.com/wallet
> Bitcoin transactions made simple:
> https://github.com/Ayms/bitcoin-transactions
>
> torrent-live: https://github.com/Ayms/torrent-live
> node-Tor : https://www.github.com/Ayms/node-Tor
> Anti-spies and private torrents, dynamic blocklist:
> http://torrent-live.peersm.com
> Peersm : http://www.peersm.com
>
>
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev@lists.linuxfoundation.org
> <mailto:bitcoin-dev@lists.linuxfoundation.org>
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>
--=20
Sophia-Antipolis, France
CV: https://www.peersm.com/CVAV.pdf
LinkedIn: https://fr.linkedin.com/in/aymeric-vitte-05855b26
GitHub : https://www.github.com/Ayms
A Universal Coin Swap system based on Bitcoin: https://gist.github.com/Ay=
ms/029125db2583e1cf9c3209769eb2cdd7
A bitcoin NFT system: https://gist.github.com/Ayms/01dbfebf219965054b4a3b=
eed1bfeba7
Move your coins by yourself (browser version): https://peersm.com/wallet
Bitcoin transactions made simple: https://github.com/Ayms/bitcoin-transac=
tions
torrent-live: https://github.com/Ayms/torrent-live
node-Tor : https://www.github.com/Ayms/node-Tor
Anti-spies and private torrents, dynamic blocklist: http://torrent-live.p=
eersm.com
Peersm : http://www.peersm.com
--------------D058FDA76903754188A4C509
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Right, that's why I do not participate any longer, they specify
things for the participants (ie big companies), they disregard
whatever suggestion can be made, they are so slow that when they
have specified something someone else has specified something
better, then they throw away their spec and take what the others
have specified</p>
<p>And they are wrong in many design decisions</p>
<p>What I meant is that bitcoin big companies should involve people,
who are not just discussing stupid things all the day like W3C
folks but do the work efficiently<br>
</p>
<br>
<div class="moz-cite-prefix">Le 20/04/2023 à 15:59, Erik Aronesty a
écrit :<br>
</div>
<blockquote
cite="mid:CAJowKgLh1zS+fFvkVZTLXiqHQ8QMOqxCVooGpby3_o8EHxoihA@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">i think the w3c is a very good example of a slow
train wreck, and we should do everything possible to avoid the
decisions they made </div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Apr 20, 2023 at
7:09 AM Aymeric Vitte via bitcoin-dev <<a
moz-do-not-send="true"
href="mailto:bitcoin-dev@lists.linuxfoundation.org">bitcoin-dev@lists.linuxfoundation.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Personnally
I will never criticize the maintainers, but my comment was<br>
about the global process, I thought that for something
important like<br>
bitcoin there were many devs/maintainers, and as you point
out, a PR<br>
must be done by certified people<br>
<br>
I don't get very well why every company involved in bitcoin do
not put<br>
at least one person in this process (a bit like W3C specs),
with<br>
different time zone so every time you wake up you don't have
to look<br>
at/handle hundreds of requests/comments<br>
<br>
And we can read in the press that bitcoin maintenance is
supposed to<br>
cost 200M per year, probably false then, but this is worrying
to see<br>
that devs/maintainers are stepping down one after the other<br>
<br>
<br>
Le 19/04/2023 à 23:33, Andrew Chow via bitcoin-dev a écrit :<br>
> Responses in-line.<br>
> Note that the opinions expressed in this email are my own
and are not<br>
> representative of what other maintainers think or
believe.<br>
><br>
> On 04/18/2023 08:40 AM, Michael Folkson via bitcoin-dev
wrote:<br>
> ><br>
> > Communication has been a challenge on Bitcoin Core
for what I can<br>
> tell the entire history of the project. Maintainers merge
a pull request<br>
> and provide no commentary on why they’ve merged it.<br>
><br>
> What commentary does there need to be?<br>
> It's self evident that the maintainer believes the code
is ready to be<br>
> merged, and has observed enough ACKs from contributors
that they are<br>
> comfortable to do so.<br>
> You're welcome to ask for clarification, but frankly, I
don't think<br>
> having any commentary on merges is going to be helpful or
more elaborate<br>
> in any way.<br>
> Requiring maintainers to have to write explanations for
every single<br>
> merge is simply going to increase the burden on them and
increase the<br>
> rate of burnout and resignations.<br>
> We've had too many maintainers step down already.<br>
> It'll end up being a bunch of boilerplate comments that
don't say<br>
> anything meaningful.<br>
><br>
> There are certainly situations where PRs are merged very
quickly or with<br>
> otherwise little apparent review.<br>
> But, as I said, if you ask a maintainer why it was
merged, the answer<br>
> will be "I thought it was ready and had enough review".<br>
> There may be other reasons that made the maintainer think
it was ready<br>
> sooner, such as the PR fixes a critical bug or security
vulnerability,<br>
> but these reasons aren't going to be stated publicly.<br>
><br>
> > Maintainers leave a pull request with many ACKs and
few (if any)<br>
> NACKs for months and provide no commentary on why they
haven't merged it.<br>
><br>
> There are currently 320 open PRs and 366 open issues.<br>
> I wake up every morning to 150+ email notifications
containing<br>
> everything that went on overnight, and throughout the
day, I typically<br>
> get hundreds more.<br>
> It's impossible to keep up with everything that goes on
throughout the repo.<br>
> ACKs come in sporadically, PRs are updated, reviews are
posted, etc.<br>
> Often times PRs are not merged simply because the
maintainers were not<br>
> aware that a PR was ready to be merged.<br>
> Things can simply fall through the cracks.<br>
><br>
> Of course there are other reasons why something might not
be merged, and<br>
> these generally fall into the camp of "I don't think it
has had enough<br>
> review".<br>
> It's the maintainer's judgement call to make as to
whether something has<br>
> been sufficiently reviewed, and part of the judgement
call is to<br>
> consider the quality and competence of the reviewers.<br>
> If a PR had 100 ACKs but all from random people who have
never<br>
> contributed to the project in any capacity, then it's not
going to be<br>
> merged because those reviewers would be considered low
quality.<br>
> It's not just about the numbers, but also about whether
the reviewers<br>
> are people the maintainers think are familiar enough with
an area and<br>
> have had a history of thoroughly reviewing PRs.<br>
> For example, if a reviewer who primarily works on the
mempool reviewed a<br>
> PR in the wallet, I would consider their review and ACK
with less weight<br>
> because they are unlikely to be familiar with the
intricacies of the wallet.<br>
> Obviously that changes over time as they make more
reviews.<br>
> For another example, if I see an ACK from a reviewer who
posts reviews<br>
> that primarily contain nits on code style and other
trivialities, I<br>
> would consider that ACK with less weight.<br>
><br>
> Furthermore, the maintainers are not necessarily the ones
who block a merge.<br>
> Part of evaluating if something is ready to be merged is
to read the<br>
> comments on a PR.<br>
> Other frequent contributors may have commented or asked
questions that<br>
> haven't been resolved yet.<br>
> PRs will often not be merged (even if they have ACKs)
until a maintainer<br>
> deems that those comments and questions have been
sufficiently resolved,<br>
> typically with the commenter stating in some way that
their concerns<br>
> were addressed.<br>
> In these situations, no commentary from maintainers is
given nor<br>
> necessary as it should be self evident (by reading the
comments) that<br>
> something is controversial.<br>
> These kinds of comments are not explicit NACKs (so
someone who is only<br>
> counting (N)ACKs won't see them), but are blocking
nonetheless.<br>
><br>
> Lastly, personally I like to review every PR before I
merge it.<br>
> This often means that a PR that might otherwise be ready
to be merged<br>
> wouldn't be merged by myself as I may not be familiar
with that part of<br>
> the codebase.<br>
> It may also mean that I would require more or specific
additional people<br>
> to review a PR before I merge it as I would weight my own
review less<br>
> heavily.<br>
> With several long time maintainers stepping away, this
may be a factor<br>
> in PRs taking longer to get merged as the remaining
maintainers may be<br>
> less familiar with the parts of the codebase that were
previously<br>
> maintained by someone else.<br>
><br>
> > but a casual observer would have only seen Concept
ACKs and ACKs with<br>
> 3 stray NACKs. Many of these casual observers inflated
the numbers on<br>
> the <a moz-do-not-send="true" href="http://utxos.org"
rel="noreferrer" target="_blank">utxos.org</a> site [4]
signalling support for a soft fork activation<br>
> attempt.<br>
><br>
> Anyone who thinks that maintainers only look at the
numbers of (N)ACKs<br>
> is delusional.<br>
> As I explained above, there is a whole lot more nuance to
determining<br>
> even just the status of the opinions on a PR, nevermind
the code itself.<br>
><br>
> In this specific example of a soft fork, there is also
consideration of<br>
> the opinions outside of the repo itself, such as on this
mailing list<br>
> and elsewhere that people discuss soft forks.<br>
><br>
> On 04/19/2023 11:17 AM, Aymeric Vitte via bitcoin-dev
wrote:<br>
> > While some simple changes can allow bitcoin to
surpass ethereum, as<br>
> usual, like "Allow several OP_RETURN in one tx and no
limited size"<br>
> <a moz-do-not-send="true"
href="https://github.com/bitcoin/bitcoin/issues/27043"
rel="noreferrer" target="_blank">https://github.com/bitcoin/bitcoin/issues/27043</a><br>
> ><br>
> > How long it will take remains mysterious<br>
><br>
> No one (maintainers or contributors) is obligated to
implement anything.<br>
> A feature request not being implemented is because the
people who do<br>
> open PRs are either not interested in implementing the
feature, or are<br>
> working on other things that they believe to be higher
priority.<br>
> If there is a feature that you want, then you will often
need to either<br>
> to it yourself, or pay someone to do it for you.<br>
><br>
> Additionally, a feature may seem like a good idea to you,
but there are<br>
> often interactions with other things that may end up
resulting in it<br>
> being rejected or need significant revision, especially
for something<br>
> which affects transaction relay.<br>
><br>
><br>
><br>
> Andrew Chow<br>
><br>
> _______________________________________________<br>
> bitcoin-dev mailing list<br>
> <a moz-do-not-send="true"
href="mailto:bitcoin-dev@lists.linuxfoundation.org"
target="_blank">bitcoin-dev@lists.linuxfoundation.org</a><br>
> <a moz-do-not-send="true"
href="https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev"
rel="noreferrer" target="_blank">https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev</a><br>
<br>
-- <br>
Sophia-Antipolis, France<br>
CV: <a moz-do-not-send="true"
href="https://www.peersm.com/CVAV.pdf" rel="noreferrer"
target="_blank">https://www.peersm.com/CVAV.pdf</a><br>
LinkedIn: <a moz-do-not-send="true"
href="https://fr.linkedin.com/in/aymeric-vitte-05855b26"
rel="noreferrer" target="_blank">https://fr.linkedin.com/in/aymeric-vitte-05855b26</a><br>
GitHub : <a moz-do-not-send="true"
href="https://www.github.com/Ayms" rel="noreferrer"
target="_blank">https://www.github.com/Ayms</a><br>
A Universal Coin Swap system based on Bitcoin: <a
moz-do-not-send="true"
href="https://gist.github.com/Ayms/029125db2583e1cf9c3209769eb2cdd7"
rel="noreferrer" target="_blank">https://gist.github.com/Ayms/029125db2583e1cf9c3209769eb2cdd7</a><br>
A bitcoin NFT system: <a moz-do-not-send="true"
href="https://gist.github.com/Ayms/01dbfebf219965054b4a3beed1bfeba7"
rel="noreferrer" target="_blank">https://gist.github.com/Ayms/01dbfebf219965054b4a3beed1bfeba7</a><br>
Move your coins by yourself (browser version): <a
moz-do-not-send="true" href="https://peersm.com/wallet"
rel="noreferrer" target="_blank">https://peersm.com/wallet</a><br>
Bitcoin transactions made simple: <a moz-do-not-send="true"
href="https://github.com/Ayms/bitcoin-transactions"
rel="noreferrer" target="_blank">https://github.com/Ayms/bitcoin-transactions</a><br>
<br>
torrent-live: <a moz-do-not-send="true"
href="https://github.com/Ayms/torrent-live" rel="noreferrer"
target="_blank">https://github.com/Ayms/torrent-live</a><br>
node-Tor : <a moz-do-not-send="true"
href="https://www.github.com/Ayms/node-Tor" rel="noreferrer"
target="_blank">https://www.github.com/Ayms/node-Tor</a><br>
Anti-spies and private torrents, dynamic blocklist: <a
moz-do-not-send="true" href="http://torrent-live.peersm.com"
rel="noreferrer" target="_blank">http://torrent-live.peersm.com</a><br>
Peersm : <a moz-do-not-send="true"
href="http://www.peersm.com" rel="noreferrer"
target="_blank">http://www.peersm.com</a><br>
<br>
<br>
_______________________________________________<br>
bitcoin-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:bitcoin-dev@lists.linuxfoundation.org"
target="_blank">bitcoin-dev@lists.linuxfoundation.org</a><br>
<a moz-do-not-send="true"
href="https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev"
rel="noreferrer" target="_blank">https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev</a><br>
</blockquote>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Sophia-Antipolis, France
CV: <a class="moz-txt-link-freetext" href="https://www.peersm.com/CVAV.pdf">https://www.peersm.com/CVAV.pdf</a>
LinkedIn: <a class="moz-txt-link-freetext" href="https://fr.linkedin.com/in/aymeric-vitte-05855b26">https://fr.linkedin.com/in/aymeric-vitte-05855b26</a>
GitHub : <a class="moz-txt-link-freetext" href="https://www.github.com/Ayms">https://www.github.com/Ayms</a>
A Universal Coin Swap system based on Bitcoin: <a class="moz-txt-link-freetext" href="https://gist.github.com/Ayms/029125db2583e1cf9c3209769eb2cdd7">https://gist.github.com/Ayms/029125db2583e1cf9c3209769eb2cdd7</a>
A bitcoin NFT system: <a class="moz-txt-link-freetext" href="https://gist.github.com/Ayms/01dbfebf219965054b4a3beed1bfeba7">https://gist.github.com/Ayms/01dbfebf219965054b4a3beed1bfeba7</a>
Move your coins by yourself (browser version): <a class="moz-txt-link-freetext" href="https://peersm.com/wallet">https://peersm.com/wallet</a>
Bitcoin transactions made simple: <a class="moz-txt-link-freetext" href="https://github.com/Ayms/bitcoin-transactions">https://github.com/Ayms/bitcoin-transactions</a>
torrent-live: <a class="moz-txt-link-freetext" href="https://github.com/Ayms/torrent-live">https://github.com/Ayms/torrent-live</a>
node-Tor : <a class="moz-txt-link-freetext" href="https://www.github.com/Ayms/node-Tor">https://www.github.com/Ayms/node-Tor</a>
Anti-spies and private torrents, dynamic blocklist: <a class="moz-txt-link-freetext" href="http://torrent-live.peersm.com">http://torrent-live.peersm.com</a>
Peersm : <a class="moz-txt-link-freetext" href="http://www.peersm.com">http://www.peersm.com</a></pre>
</body>
</html>
--------------D058FDA76903754188A4C509--
|