summaryrefslogtreecommitdiff
path: root/07/c97c8b8d65f891cd51b9424d4cce28064701f6
blob: 984887ad76241ef709c4dd3473304c3582e2305f (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
Return-Path: <tier.nolan@gmail.com>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id 3F5F692B
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Tue, 10 Nov 2015 16:30:59 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-qg0-f43.google.com (mail-qg0-f43.google.com
	[209.85.192.43])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 86CD71A1
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Tue, 10 Nov 2015 16:30:58 +0000 (UTC)
Received: by qgec40 with SMTP id c40so1825760qge.2
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Tue, 10 Nov 2015 08:30:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type; bh=evFncqOQbIeZl9j6td/KjoRU+uxMc65xPd3gIcv9Ppg=;
	b=DiCwiUyoAoFNPkCGqBMENDv3TevsTuwLLkK7lrnV2frmsz9VXdSEv81SajR3+wrKFL
	ejuOZusMceJogT+/GPl5l+/LMOB1Gf3HMTs0RWOKP50pv8tNemTRAyYsENneJol0mZq9
	KzMnNfWV7JmJenjShTZhKDYQwmSoVrj0jqYlVz/KbYJRMSO0WCuHVMxqMQwVIIipnnVv
	UN+ilqsrYadbmmCLRV4evbgi3498RIK1FTOm90IpQ3ApbNBEDQKaajs14VBd7+h89VWG
	TKdVdZCRX+b7jfg/SiUDN0RhggtEsyTR2i/eOaa8NNOCWRPRBSnPSJbzhafDHPCcjFwD
	WKsA==
MIME-Version: 1.0
X-Received: by 10.140.181.197 with SMTP id c188mr5867384qha.4.1447173057616;
	Tue, 10 Nov 2015 08:30:57 -0800 (PST)
Received: by 10.140.93.82 with HTTP; Tue, 10 Nov 2015 08:30:57 -0800 (PST)
In-Reply-To: <5642172C.701@gmail.com>
References: <5640F172.3010004@gmail.com> <20151109210449.GE5886@mcelrath.org>
	<CAL7-sS0Apm4O_Qi0FmY7=H580rEVD6DYjk2y+ACpZmKqUJTQwA@mail.gmail.com>
	<CALOxbZtTUrZwDfy_jTbs60n=K8RKDGg5X0gkLsh-OX3ikLf1FQ@mail.gmail.com>
	<CAE-z3OUB-se_HUvW2NLjWt=0d5sgMiPEciu0hLzr_HQN0m9fqQ@mail.gmail.com>
	<5642172C.701@gmail.com>
Date: Tue, 10 Nov 2015 16:30:57 +0000
Message-ID: <CAE-z3OXgWCHL_3CDR-ACc7ojbLi7EavyObNa3s7hPUMGj_V2+A@mail.gmail.com>
From: Tier Nolan <tier.nolan@gmail.com>
To: Bitcoin Dev <bitcoin-dev@lists.linuxfoundation.org>
Content-Type: multipart/alternative; boundary=001a113a95be0721d70524323ce2
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
Subject: Re: [bitcoin-dev] request BIP number for: "Support for Datastream
	Compression"
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Development Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Nov 2015 16:30:59 -0000

--001a113a95be0721d70524323ce2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 10, 2015 at 4:11 PM, Peter Tschipper <peter.tschipper@gmail.com=
>
wrote:

> There are better ways of sending new blocks, that's certainly true but fo=
r
> sending historical blocks and seding transactions I don't think so.  This
> PR is really designed to save bandwidth and not intended to be a huge
> performance improvement in terms of time spent sending.
>

If the main point is for historical data, then sticking to just blocks is
the best plan.

Since small blocks don't compress well, you could define a "cblocks"
message that handles multiple blocks (just concatenate the block messages
as payload before compression).

The sending peer could combine blocks so that each cblock is compressing at
least 10kB of block data (or whatever is optimal).  It is probably worth
specifying a maximum size for network buffer reasons (either 1MB or 1 block
maximum).

Similarly, transactions could be combined together and compressed "ctxs".
The inv messages could be modified so that you can request groups of 10-20
transactions.  That would depend on how much of an improvement compressed
transactions would represent.

More generally, you could define a message which is a compressed message
holder.  That is probably to complex to be worth the effort though.



>
> On Tue, Nov 10, 2015 at 5:40 AM, Johnathan Corgan via bitcoin-dev <
> <bitcoin-dev@lists.linuxfoundation.org>
> bitcoin-dev@lists.linuxfoundation.org> wrote:
>
>> On Mon, Nov 9, 2015 at 5:58 PM, gladoscc via bitcoin-dev <
>> bitcoin-dev@lists.linuxfoundation.org> wrote:
>>
>>
>>> I think 25% bandwidth savings is certainly considerable, especially for
>>> people running full nodes in countries like Australia where internet
>>> bandwidth is lower and there are data caps.
>>>
>>
>> =E2=80=8BThis reinforces the idea that such trade-off decisions should b=
e be
>> local and negotiated between peers, not a required feature of the networ=
k
>> P2P.=E2=80=8B
>>
>>
>> --
>> Johnathan Corgan
>> Corgan Labs - SDR Training and Development Services
>> http://corganlabs.com
>>
>> _______________________________________________
>> bitcoin-dev mailing list
>> bitcoin-dev@lists.linuxfoundation.org
>> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>>
>>
>
>
> _______________________________________________
> bitcoin-dev mailing listbitcoin-dev@lists.linuxfoundation.orghttps://list=
s.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>
>
>

--001a113a95be0721d70524323ce2
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Tue, Nov 10, 2015 at 4:11 PM, Peter Tschipper <span dir=3D"ltr">&lt;=
<a href=3D"mailto:peter.tschipper@gmail.com" target=3D"_blank">peter.tschip=
per@gmail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 =20
   =20
 =20
  <span class=3D""></span><span class=3D""></span>There are better ways of =
sending new blocks, that&#39;s certainly true
    but for sending historical blocks and seding transactions I don&#39;t
    think so.=C2=A0 This PR is really designed to save bandwidth and not
    intended to be a huge performance improvement in terms of time spent
    sending.<span class=3D""><br></span></blockquote><div><br></div><div>If=
 the main point is for historical data, then sticking to just blocks is the=
 best plan.<br><br></div><div>Since small blocks don&#39;t compress well, y=
ou could define a &quot;cblocks&quot; message that handles multiple blocks =
(just concatenate the block messages as payload before compression).=C2=A0 =
<br><br>The sending peer could combine blocks so that each cblock is compre=
ssing at least 10kB of block data (or whatever is optimal).=C2=A0 It is pro=
bably worth specifying a maximum size for network buffer reasons (either 1M=
B or 1 block maximum).<br><br></div><div>Similarly, transactions could be c=
ombined together and compressed &quot;ctxs&quot;.=C2=A0 The inv messages co=
uld be modified so that you can request groups of 10-20 transactions.=C2=A0=
 That would depend on how much of an improvement compressed transactions wo=
uld represent. <br><br></div><div>More generally, you could define a messag=
e which is a compressed message holder.=C2=A0 That is probably to complex t=
o be worth the effort though.<br></div><div><br>=C2=A0</div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pa=
dding-left:1ex"><div bgcolor=3D"#FFFFFF" text=3D"#000000"><span class=3D"">
    <blockquote type=3D"cite">
      <div class=3D"gmail_extra"><br>
        <div class=3D"gmail_quote">On Tue, Nov 10, 2015 at 5:40 AM,
          Johnathan Corgan via bitcoin-dev <span dir=3D"ltr">&lt;<a href=3D=
"mailto:bitcoin-dev@lists.linuxfoundation.org" target=3D"_blank"></a><a hre=
f=3D"mailto:bitcoin-dev@lists.linuxfoundation.org" target=3D"_blank">bitcoi=
n-dev@lists.linuxfoundation.org</a>&gt;</span>
          wrote:<br>
          <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bord=
er-left:1px #ccc solid;padding-left:1ex">
            <div dir=3D"ltr"><span>
                <div style=3D"font-size:small">On
                  Mon, Nov 9, 2015 at 5:58 PM, gladoscc via bitcoin-dev
                  <span dir=3D"ltr">&lt;<a href=3D"mailto:bitcoin-dev@lists=
.linuxfoundation.org" target=3D"_blank">bitcoin-dev@lists.linuxfoundation.o=
rg</a>&gt;</span>
                  wrote:<br>
                </div>
              </span>
              <div class=3D"gmail_extra">
                <div class=3D"gmail_quote"><span>
                    <div>=C2=A0</div>
                    <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0=
 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                      <div dir=3D"ltr">I think 25% bandwidth savings is
                        certainly considerable, especially for people
                        running full nodes in countries like Australia
                        where internet bandwidth is lower and there are
                        data caps.</div>
                    </blockquote>
                    <div><br>
                    </div>
                  </span>
                  <div>
                    <div style=3D"font-size:small;display:inline">=E2=80=8B=
This
                      reinforces the idea that such trade-off decisions
                      should be be local and negotiated between peers,
                      not a required feature of the network P2P.=E2=80=8B</=
div>
                    =C2=A0</div>
                </div>
                <span>
                  <div><br>
                  </div>
                  -- <br>
                  <div>
                    <div dir=3D"ltr">
                      <div>
                        <div dir=3D"ltr">
                          <div dir=3D"ltr">
                            <div dir=3D"ltr">
                              <div dir=3D"ltr">
                                <div dir=3D"ltr">
                                  <div>Johnathan Corgan<br>
                                    Corgan Labs - SDR Training and
                                    Development Services</div>
                                  <div><a href=3D"http://corganlabs.com" st=
yle=3D"font-size:12.8px" target=3D"_blank">http://corganlabs.com</a><br>
                                  </div>
                                </div>
                              </div>
                            </div>
                          </div>
                        </div>
                      </div>
                    </div>
                  </div>
                </span></div>
            </div>
            <br>
            _______________________________________________<br>
            bitcoin-dev mailing list<br>
            <a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org" target=
=3D"_blank">bitcoin-dev@lists.linuxfoundation.org</a><br>
            <a href=3D"https://lists.linuxfoundation.org/mailman/listinfo/b=
itcoin-dev" rel=3D"noreferrer" target=3D"_blank">https://lists.linuxfoundat=
ion.org/mailman/listinfo/bitcoin-dev</a><br>
            <br>
          </blockquote>
        </div>
        <br>
      </div>
      <br>
      <fieldset></fieldset>
      <br>
      <pre>_______________________________________________
bitcoin-dev mailing list
<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org" target=3D"_blank">=
bitcoin-dev@lists.linuxfoundation.org</a>
<a href=3D"https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev" =
target=3D"_blank">https://lists.linuxfoundation.org/mailman/listinfo/bitcoi=
n-dev</a>
</pre>
    </blockquote>
    <br>
  </span></div>

</blockquote></div><br></div></div>

--001a113a95be0721d70524323ce2--