1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
|
Return-Path: <eric@voskuil.org>
Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])
by lists.linuxfoundation.org (Postfix) with ESMTP id A1D66C002D
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 6 Oct 2022 04:32:32 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
by smtp4.osuosl.org (Postfix) with ESMTP id 5F7784188E
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 6 Oct 2022 04:32:32 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5F7784188E
Authentication-Results: smtp4.osuosl.org;
dkim=pass (2048-bit key) header.d=voskuil-org.20210112.gappssmtp.com
header.i=@voskuil-org.20210112.gappssmtp.com header.a=rsa-sha256
header.s=20210112 header.b=jLuqUiwX
X-Virus-Scanned: amavisd-new at osuosl.org
X-Spam-Flag: NO
X-Spam-Score: -1.025
X-Spam-Level:
X-Spam-Status: No, score=-1.025 tagged_above=-999 required=5
tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001,
THIS_AD=0.873] autolearn=no autolearn_force=no
Received: from smtp4.osuosl.org ([127.0.0.1])
by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id 49tNw_7Oij7a
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 6 Oct 2022 04:32:31 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.8.0
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 265FA41888
Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com
[IPv6:2607:f8b0:4864:20::42d])
by smtp4.osuosl.org (Postfix) with ESMTPS id 265FA41888
for <bitcoin-dev@lists.linuxfoundation.org>;
Thu, 6 Oct 2022 04:32:31 +0000 (UTC)
Received: by mail-pf1-x42d.google.com with SMTP id g28so983974pfk.8
for <bitcoin-dev@lists.linuxfoundation.org>;
Wed, 05 Oct 2022 21:32:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=voskuil-org.20210112.gappssmtp.com; s=20210112;
h=content-language:thread-index:content-transfer-encoding
:mime-version:message-id:date:subject:in-reply-to:references:cc:to
:from:from:to:cc:subject:date;
bh=yKfroEPBkxIIbBEqkEd0z4JvD6kk8EhtGw/fbzs0/7E=;
b=jLuqUiwXswM1RTnkwysc506wDykQTmKymVOvPnOkgTnZvscc7/jeiH5CGS4A0fsWst
X6SYveoXS5KtC5IszVfDWCJRBWYmicuQkvZroRAQ3gVM1pZa0nqOJRcChLRg84HDkA4F
WPG79H3ZarXTGuQziwYJWLhYOXj1fgSclEqVj1fpfz8dXID2x6T5wsWQ/eKvFyQ9ydnj
EQ9p0NTglKuHca+CJOmSa3eUnScaHlorWQRdIbTr0XALZeM9pyOcGRZipC8F1TtOLbTh
6wOfWadoR5+uaxy9NdOV9X/ZWfLycFwaztauDA/bG1WHik5Xn+w5hoFbT4LXcZSAlnJA
W/Sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-language:thread-index:content-transfer-encoding
:mime-version:message-id:date:subject:in-reply-to:references:cc:to
:from:x-gm-message-state:from:to:cc:subject:date;
bh=yKfroEPBkxIIbBEqkEd0z4JvD6kk8EhtGw/fbzs0/7E=;
b=p/6XPQm3fvSG3fySSM2NCiGM4PKLE9RmdQpEsRnSb6GX1B7y6mIXDXDTA2SuO8lzVj
fmN2sZgSyYBHpMczhdZqMKrMw9Un437gdyIIAwKi2nzjajnNd0LZOVu+aQtYgvAf/Xjp
BkmUVJt6GrQDbVWMqvRwjq8uvlMr6TmasT6CfaillL9NMdhindIQzL5AYnNfuy9xrg0N
H6YtMXClMz8ebmoIAZsjh9Z9Qhg2X9SzGs0bRyFGHWKApy4lSh5rdt3sfPPW2vUMll2q
WIQXKgvw1vax9Abr2v9K0al4f+EL7PzvzW5KrPG24avNXYJosDhGOv9+VYnmhxPI6rgM
lzfA==
X-Gm-Message-State: ACrzQf0e67ci4LOuimwadznPDLNju7Zjp6JJqiOFFOuYhDRQb40FwcEq
ItsFDdMr5WL0fdMvcFOObhqLyA==
X-Google-Smtp-Source: AMsMyM6qhfH6+jWUqth+BJRSN8svJ3Sbeyke54rh5JeQOlP7CORixtW2sgAg/pvIMzVg4Nb1SWlG9A==
X-Received: by 2002:a05:6a00:174a:b0:562:781f:eca3 with SMTP id
j10-20020a056a00174a00b00562781feca3mr1235645pfc.41.1665030750365;
Wed, 05 Oct 2022 21:32:30 -0700 (PDT)
Received: from ERICDESKTOP ([50.35.79.94]) by smtp.gmail.com with ESMTPSA id
ik13-20020a170902ab0d00b0017f7e0f4a4esm2217479plb.35.2022.10.05.21.32.29
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 05 Oct 2022 21:32:29 -0700 (PDT)
From: <eric@voskuil.org>
To: "'Anthony Towns'" <aj@erisian.com.au>
References: <03ca01d8d8fb$1558ed50$400ac7f0$@voskuil.org>
In-Reply-To: <03ca01d8d8fb$1558ed50$400ac7f0$@voskuil.org>
Date: Wed, 5 Oct 2022 21:32:29 -0700
Message-ID: <040f01d8d93c$a58c2540$f0a46fc0$@voskuil.org>
MIME-Version: 1.0
Content-Type: text/plain;
charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGjJkZ87zZ0BUhtE3y1t2YHVdIMma5sJKOQ
Content-Language: en-us
Cc: 'Bitcoin Protocol Discussion' <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Packaged Transaction Relay
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2022 04:32:32 -0000
>> ...sendaddrv2 messages are only sent to nodes advertising version =
70016 or later (same as wtxidrelay)
> I don=E2=80=99t see this constraint in BIP155. Do you mean that addrv2 =
support was
> released in Core at the same time as wtxidrelay, or that it is an
> undocumented version constraint implemented in Core?
I see that it is the latter:
// BIP155 defines addrv2 and sendaddrv2 for all protocol versions, but =
some
// implementations reject messages they don't know. As a courtesy, don't =
send
// it to nodes with a version before 70016, as no software is known to =
support
// BIP155 that doesn't announce at least that protocol version number.
https://github.com/bitcoin/bitcoin/pull/20564/files#diff-6875de769e90cec8=
4d2e8a9c1b962cdbcda44d870d42e4215827e599e11e90e3R2366-R2370
The version string in the log message I posted implies it may not be a =
Core release. Yet it is BIP155 compliant.
Protocol cannot be defined on an ad-hoc basis as a "courtesy" - and it's =
not exactly a courtesy to keep yourself from getting dropped by peers. =
It is not clear to me why such a comment would be accepted instead of =
specifying this properly. A new protocol cannot define a message for =
"all versions", it can only assume that older versions will disregard =
all unknown message traffic - or that implementers will patch it in this =
ad-hoc matter.
I would suggest that authors update BIP155 and BIP330 (both still in =
Draft status), as well any pending proposals that may have picked up =
this pattern from BIP155.
I doubt that anyone who's worked with it is terribly fond of Bitcoin's =
P2P protocol versioning. I've spent some time on a proposal to update =
it, though it hasn't been a priority. If anyone is interested in =
collaborating on it please contact me directly.
e
|
