1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
|
Return-Path: <eric@voskuil.org>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
[172.17.192.35])
by mail.linuxfoundation.org (Postfix) with ESMTPS id F2406AC7
for <bitcoin-dev@lists.linuxfoundation.org>;
Sun, 20 Oct 2019 05:13:15 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com
[209.85.222.171])
by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3DAEC14D
for <bitcoin-dev@lists.linuxfoundation.org>;
Sun, 20 Oct 2019 05:13:15 +0000 (UTC)
Received: by mail-qk1-f171.google.com with SMTP id p4so9197653qkf.5
for <bitcoin-dev@lists.linuxfoundation.org>;
Sat, 19 Oct 2019 22:13:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=voskuil-org.20150623.gappssmtp.com; s=20150623;
h=content-transfer-encoding:from:mime-version:subject:date:message-id
:references:cc:in-reply-to:to;
bh=dVntKGnj6IAFG9p1VW7U38dH7Tqbgg3rrOv6JFOJUjs=;
b=AnpVmywiUc5uKhrD4wHE7tAcK7h48gRJV7fYS5s75va2fxM4x0O37XWVpv2WrorP6L
76zf69tNnApDlcZMUcIViepdue99/ZPFoPcf4hudBef+R14spGMHnxZy2tp32woAH18J
I4G1LSpJ6cEDSfQMIBRtOHFfK1Ejvzzu6jfPf1lKgAjvCSmBpxxnN9uOzZ80TNtk9FJ9
sPGy6BrXYEix3A+cNfUDloGNq/N80OmJ0ZsA1n5Il4802ybv7AWpBYa3j9l9sjoJDcPs
IyE+xAU5z4tzfRkl6FqhIxzHfO8EO9l3Ld1Q0jrCoOK81w5DZEZWHZJIHeBoHoOazCVM
BmBA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:content-transfer-encoding:from:mime-version
:subject:date:message-id:references:cc:in-reply-to:to;
bh=dVntKGnj6IAFG9p1VW7U38dH7Tqbgg3rrOv6JFOJUjs=;
b=ipNvxWCCn4GQYC4kNcKW4EAyT5JRWwTX4RUlHjRsgUtaiujEgK84U8xONWRhjYJlrI
nzRY/yKREir8ISmMOxdbztVRTm+nTbQ6WP+93/ynaLJJqli0HTA4QL4sfkqudrXRmiww
AVMbWN+TaqBosCxxMzFMb8CY3v/vVZ/FZPU/GLqYnf8dnuc9SUzNrLNDWFaEnzr2ri5D
1HGJmsnP2BKfYDn1ghck8WYE4nXXvHcrCjUbr+9z+Q7O2HhMv2yaD9dSCC4XatWMJ4RX
YzWTfs4aq9mFpa81Lr7KJfUjPPMQ/l6xFQpEYpb22/CWU5FmHC210Onb9eqCuaOmlmE8
PN7w==
X-Gm-Message-State: APjAAAVzG81z187s6hi1iogW/wTuxKb5DxN84OV3XG3gBrF1WAjruvLr
GCFnxr6ElK1fMq1pfOMfr1GMHBCnViY=
X-Google-Smtp-Source: APXvYqw2soYPUmmCVReG/BAxXPfUboJN8kQAjsbFpCHBWd60jXeHWYJ1v9kVcgU//ZS2llA6QPHMpg==
X-Received: by 2002:a05:620a:347:: with SMTP id
t7mr11754526qkm.356.1571548394028;
Sat, 19 Oct 2019 22:13:14 -0700 (PDT)
Received: from ?IPv6:2600:380:bc23:b42c:9489:8da7:15fc:4cdf?
([2600:380:bc23:b42c:9489:8da7:15fc:4cdf])
by smtp.gmail.com with ESMTPSA id
m15sm4710775qka.104.2019.10.19.22.13.13
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Sat, 19 Oct 2019 22:13:13 -0700 (PDT)
Content-Type: multipart/alternative;
boundary=Apple-Mail-C837301A-A457-42A9-B13A-2665F191B174
Content-Transfer-Encoding: 7bit
From: Eric Voskuil <eric@voskuil.org>
Mime-Version: 1.0 (1.0)
Date: Sun, 20 Oct 2019 01:13:12 -0400
Message-Id: <8C87E9AF-A064-42BB-AB9D-7477C10625BF@voskuil.org>
References: <20191018224535.wy6f55grpfk2sncq@ganymede>
In-Reply-To: <20191018224535.wy6f55grpfk2sncq@ganymede>
To: "David A. Harding" <dave@dtrt.org>
X-Mailer: iPhone Mail (17A860)
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID, HTML_MESSAGE, MIME_QP_LONG_LINE,
RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
smtp1.linux-foundation.org
X-Mailman-Approved-At: Sun, 20 Oct 2019 08:36:24 +0000
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Removal of reject network messages from Bitcoin
Core (BIP61)
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Oct 2019 05:13:16 -0000
--Apple-Mail-C837301A-A457-42A9-B13A-2665F191B174
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
I agree, thanks.
FWIW I=E2=80=99ve never been a fan of the =E2=80=98reject=E2=80=99 message, o=
r its implementation.
https://github.com/bitcoin/bips/wiki/Comments:BIP-0061
e
> On Oct 18, 2019, at 18:46, David A. Harding <dave@dtrt.org> wrote:
>=20
> =EF=BB=BFOn Thu, Oct 17, 2019 at 01:16:47PM -0700, Eric Voskuil via bitcoi=
n-dev wrote:
>> As this is a P2P protocol change it should be exposed as a version
>> increment (and a BIP) [...]
>>=20
>> BIP61 is explicit:
>>=20
>> =E2=80=9CAll implementations of the P2P protocol version 70,002 and later=
>> should support the reject message.=E2=80=9C
>=20
> I don't think a new BIP or a version number increment is necessary.
>=20
> 1. "Should support" isn't the same as "must support". See
> https://tools.ietf.org/html/rfc2119 ; by that reading,
> implementations with protocol versions above 70,002 are not required
> to support the reject message.
>=20
> 2. If you don't implement a BIP, as Bitcoin Core explicitly doesn't any
> more for BIP61[1], you're not bound by its conditions.
>=20
> -Dave
>=20
> [1] https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md "BIP61
> [...] Support was removed in v0.20.0"
--Apple-Mail-C837301A-A457-42A9-B13A-2665F191B174
Content-Type: text/html;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><div dir=3D"ltr">I agree, thanks.</div><div=
dir=3D"ltr"><br></div><div dir=3D"ltr">FWIW I=E2=80=99ve never been a fan o=
f the =E2=80=98reject=E2=80=99 message, or its implementation.</div><div dir=
=3D"ltr"><br></div><div dir=3D"ltr"><a href=3D"https://github.com/bitcoin/bi=
ps/wiki/Comments:BIP-0061">https://github.com/bitcoin/bips/wiki/Comments:BIP=
-0061</a></div><div dir=3D"ltr"><br></div><div dir=3D"ltr">e</div><div dir=3D=
"ltr"><br><blockquote type=3D"cite">On Oct 18, 2019, at 18:46, David A. Hard=
ing <dave@dtrt.org> wrote:<br><br></blockquote></div><blockquote type=3D=
"cite"><div dir=3D"ltr">=EF=BB=BF<span>On Thu, Oct 17, 2019 at 01:16:47PM -0=
700, Eric Voskuil via bitcoin-dev wrote:</span><br><blockquote type=3D"cite"=
><span>As this is a P2P protocol change it should be exposed as a version</s=
pan><br></blockquote><blockquote type=3D"cite"><span>increment (and a BIP) [=
...]</span><br></blockquote><blockquote type=3D"cite"><span></span><br></blo=
ckquote><blockquote type=3D"cite"><span>BIP61 is explicit:</span><br></block=
quote><blockquote type=3D"cite"><span></span><br></blockquote><blockquote ty=
pe=3D"cite"><span>=E2=80=9CAll implementations of the P2P protocol version 7=
0,002 and later</span><br></blockquote><blockquote type=3D"cite"><span>shoul=
d support the reject message.=E2=80=9C</span><br></blockquote><span></span><=
br><span>I don't think a new BIP or a version number increment is necessary.=
</span><br><span></span><br><span>1. "Should support" isn't the same as "mus=
t support". See</span><br><span> https://tools.ietf.org/ht=
ml/rfc2119 ; by that reading,</span><br><span> implementations w=
ith protocol versions above 70,002 are not required</span><br><span> &=
nbsp;to support the reject message.</span><br><span></span><br><span>2. If y=
ou don't implement a BIP, as Bitcoin Core explicitly doesn't any</span><br><=
span> more for BIP61[1], you're not bound by its conditions.</sp=
an><br><span></span><br><span>-Dave</span><br><span></span><br><span>[1] htt=
ps://github.com/bitcoin/bitcoin/blob/master/doc/bips.md "BIP61</span><=
br><span>[...] Support was removed in v0.20.0"</span><br></div></blockquote>=
</body></html>=
--Apple-Mail-C837301A-A457-42A9-B13A-2665F191B174--
|
