diff options
author | Mike Hearn <mike@plan99.net> | 2013-01-16 11:43:55 +0100 |
---|---|---|
committer | bitcoindev <bitcoindev@gnusha.org> | 2013-01-16 10:44:01 +0000 |
commit | f0f9cad51de5e06a58c014288a15d7cda8fd52ec (patch) | |
tree | 38b0efe83c9873b5b4d225f805e20958de8fd092 | |
parent | e505dd3eb935cbc5055b9b5bc7826cc724306fca (diff) | |
download | pi-bitcoindev-f0f9cad51de5e06a58c014288a15d7cda8fd52ec.tar.gz pi-bitcoindev-f0f9cad51de5e06a58c014288a15d7cda8fd52ec.zip |
Re: [Bitcoin-development] Draft BIP for Bloom filtering
-rw-r--r-- | cc/3b42391a6f4d59933d02c4b21176fbc4c5f66f | 83 |
1 files changed, 83 insertions, 0 deletions
diff --git a/cc/3b42391a6f4d59933d02c4b21176fbc4c5f66f b/cc/3b42391a6f4d59933d02c4b21176fbc4c5f66f new file mode 100644 index 000000000..efaa64a2e --- /dev/null +++ b/cc/3b42391a6f4d59933d02c4b21176fbc4c5f66f @@ -0,0 +1,83 @@ +Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] + helo=mx.sourceforge.net) + by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) + (envelope-from <mh.in.england@gmail.com>) id 1TvQTR-0006Nb-L6 + for bitcoin-development@lists.sourceforge.net; + Wed, 16 Jan 2013 10:44:01 +0000 +Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com + designates 209.85.219.51 as permitted sender) + client-ip=209.85.219.51; envelope-from=mh.in.england@gmail.com; + helo=mail-oa0-f51.google.com; +Received: from mail-oa0-f51.google.com ([209.85.219.51]) + by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) + (Exim 4.76) id 1TvQTQ-0005o2-Si + for bitcoin-development@lists.sourceforge.net; + Wed, 16 Jan 2013 10:44:01 +0000 +Received: by mail-oa0-f51.google.com with SMTP id n12so1242596oag.10 + for <bitcoin-development@lists.sourceforge.net>; + Wed, 16 Jan 2013 02:43:55 -0800 (PST) +MIME-Version: 1.0 +X-Received: by 10.182.12.101 with SMTP id x5mr445886obb.47.1358333035466; Wed, + 16 Jan 2013 02:43:55 -0800 (PST) +Sender: mh.in.england@gmail.com +Received: by 10.76.128.139 with HTTP; Wed, 16 Jan 2013 02:43:55 -0800 (PST) +In-Reply-To: <CANEZrP3KKGOPM7BzWAr1xGqh96iEzJ+Ki2hdUTe0Gvv51pJ23w@mail.gmail.com> +References: <CANEZrP0XALwBFJyZTzYd5xBp4MRrjv0s_y2tOXbO7UgjWF2HzA@mail.gmail.com> + <20121121151534.GA5540@vps7135.xlshosting.net> + <1353523117.1085.14.camel@localhost.localdomain> + <20121127211019.GA22701@vps7135.xlshosting.net> + <CANEZrP0w052ebao-04H4Wduerm86o6RKBY=ObnJXBX22k--zMA@mail.gmail.com> + <1357876751.1740.4.camel@localhost.localdomain> + <CA+8xBpcB6kXWyRbeUknK6gkcrFMV6YtrDk0c938q1_32U6GtRw@mail.gmail.com> + <CANEZrP2k30UsWFYSZ7Bh5Hm4LJ9vEAMEUgYSrYkcXcDTY2Z79Q@mail.gmail.com> + <CANEZrP3KKGOPM7BzWAr1xGqh96iEzJ+Ki2hdUTe0Gvv51pJ23w@mail.gmail.com> +Date: Wed, 16 Jan 2013 11:43:55 +0100 +X-Google-Sender-Auth: sgrNP-kFQYMJSTUYr0iTM49nzN0 +Message-ID: <CANEZrP2q=Kvk8DRRjB7mtw7QF8xDTAFYPVRCDW60tJn4A67LYQ@mail.gmail.com> +From: Mike Hearn <mike@plan99.net> +To: Jeff Garzik <jgarzik@exmulti.com> +Content-Type: text/plain; charset=UTF-8 +X-Spam-Score: -1.5 (-) +X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. + See http://spamassassin.org/tag/ for more details. + -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for + sender-domain + 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider + (mh.in.england[at]gmail.com) + -0.0 SPF_PASS SPF: sender matches SPF record + 0.1 DKIM_SIGNED Message has a DKIM or DK signature, + not necessarily valid + -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature +X-Headers-End: 1TvQTQ-0005o2-Si +Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net> +Subject: Re: [Bitcoin-development] Draft BIP for Bloom filtering +X-BeenThere: bitcoin-development@lists.sourceforge.net +X-Mailman-Version: 2.1.9 +Precedence: list +List-Id: <bitcoin-development.lists.sourceforge.net> +List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>, + <mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe> +List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development> +List-Post: <mailto:bitcoin-development@lists.sourceforge.net> +List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help> +List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>, + <mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe> +X-List-Received-Date: Wed, 16 Jan 2013 10:44:01 -0000 + +Matts latest code has been tested by Andreas and seems to work +correctly. He had to extend the client a bit to refresh the filter +every 25k blocks because even with the extra flag, eventually the +filter degrades into uselessness, but it did still improve the +situation quite a bit. + +Because it's unit tested, been reviewed by me several times, has an +interoperable implementation that has also been tested by Andreas in a +build of his smartphone app, I'm going to ACK the current code and +request that it be merged in to 0.8. What do you say Gavin? + +The next step after that would be profiling. It's a big performance +improvement for SPV clients already, but not as much as I anticipated. +I suspect there's a simple bottleneck or missed optimization +somewhere. But that can obviously come post-0.8 + + |