diff options
| author | Aymeric Vitte <vitteaymeric@gmail.com> | 2019-03-07 21:52:33 +0100 |
|---|---|---|
| committer | bitcoindev <bitcoindev@gnusha.org> | 2019-03-07 20:52:38 +0000 |
| commit | f43b9472a2fcae2cb3dccf870e0dae7414a34c3b (patch) | |
| tree | 9b695e5661671d3f8cfa4b0fa04410d25e2070e2 /85/f09285fe2c18702adcee7ebcf0600e9035af5d | |
| parent | f54049164c591873fb8d9ec615ad0416161be2c9 (diff) | |
| download | pi-bitcoindev-f43b9472a2fcae2cb3dccf870e0dae7414a34c3b.tar.gz pi-bitcoindev-f43b9472a2fcae2cb3dccf870e0dae7414a34c3b.zip | |
Re: [bitcoin-dev] Removal of reject network messages from Bitcoin Core (BIP61)
Diffstat (limited to '85/f09285fe2c18702adcee7ebcf0600e9035af5d')
| -rw-r--r-- | 85/f09285fe2c18702adcee7ebcf0600e9035af5d | 199 |
1 files changed, 199 insertions, 0 deletions
diff --git a/85/f09285fe2c18702adcee7ebcf0600e9035af5d b/85/f09285fe2c18702adcee7ebcf0600e9035af5d new file mode 100644 index 000000000..816b2826e --- /dev/null +++ b/85/f09285fe2c18702adcee7ebcf0600e9035af5d @@ -0,0 +1,199 @@ +Return-Path: <vitteaymeric@gmail.com> +Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org + [172.17.192.35]) + by mail.linuxfoundation.org (Postfix) with ESMTPS id C0233C338 + for <bitcoin-dev@lists.linuxfoundation.org>; + Thu, 7 Mar 2019 20:52:38 +0000 (UTC) +X-Greylist: whitelisted by SQLgrey-1.7.6 +Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com + [209.85.221.50]) + by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 12F4B5E2 + for <bitcoin-dev@lists.linuxfoundation.org>; + Thu, 7 Mar 2019 20:52:38 +0000 (UTC) +Received: by mail-wr1-f50.google.com with SMTP id n2so19059919wrw.8 + for <bitcoin-dev@lists.linuxfoundation.org>; + Thu, 07 Mar 2019 12:52:37 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; + h=subject:to:references:from:openpgp:autocrypt:message-id:date + :user-agent:mime-version:in-reply-to:content-transfer-encoding + :content-language; + bh=z/zL+sl4bacI3o10K8ArZkHoQe3iz7GwE8xTveHCVdU=; + b=knm7EA/UoJdG7/v7PK3wWoL5BzKd5ink+z+T3w4WMci7t/c13/Cv7MnFv6wVoMrHbb + W8Fzv2V7XU6i3ICdoyCSZKdcPchR91ABQWgRvJYMwn/zxJKq4RiT86WA2vEvNPVdV1C9 + Cg29K/cK/8MWjcAc7DBcnnpq4rDxalSNjXr8Uy5JeA1OZx0vdMf9PO4pDS6ZmUPaZy4M + Vb29wiZ9yL52/rrHQNz0n+rR1WroTobIEvQaQ6kHDcAL0fdJdLsQ9hkosZVWtEWCSFzP + fBcAKwH0wZuJSKzHb8K1fVmPaQvMSTL9kQpYOL0jtuFwnZGl/lO+SZyh1GbmYzVeimdA + DiSQ== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20161025; + h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt + :message-id:date:user-agent:mime-version:in-reply-to + :content-transfer-encoding:content-language; + bh=z/zL+sl4bacI3o10K8ArZkHoQe3iz7GwE8xTveHCVdU=; + b=C3eoQgPbupTVu8KpfXljPpCANQ+7Se/B5Y2QOLUxJ80ng1W4+CddBR3NSD4QCABvjE + imewRAfPVHW9B4qIZuTVr66hr/2ms4frdvI10/sjjcTm7asbxwon5QDnjrZKQ4DgwQPM + xiZQ7HkZWfnChZbBskhhuG/sOvFohkdvwWepR97fH3Af7jTDa4QC8OTxy98Ww8yUspNh + S0Sw6OYEl5Iz4ocId2iOK7fiL2OIHIa9xaC1T5ZKcwQuQdF2gjDWGtt7qhlKZ0y5IvBE + uDF22Zoy435cFJV8gaysPoqrvrhJvqSjnprpU86hcQJGuqg682xF7xeoFOVvBNj5qEps + DdlA== +X-Gm-Message-State: APjAAAVGoW7zUBX4POCIh1yLs2KPjAu7rwhUvnPvd1w1j6H2dw40PRZ5 + Us146Wd9Xqn3OQ+KUIZWazdWrWc1 +X-Google-Smtp-Source: APXvYqydXTviQSUiSgLWVugfAGpP0bZajUsVH75pogcHDyCwTXfmJMagmyC1bpnf1iCWgl0NyFiJVA== +X-Received: by 2002:a05:6000:1c2:: with SMTP id + t2mr8754222wrx.109.1551991956196; + Thu, 07 Mar 2019 12:52:36 -0800 (PST) +Received: from ?IPv6:2a01:cb1d:44:6500:9d6d:71b2:cb71:cb17? + ([2a01:cb1d:44:6500:9d6d:71b2:cb71:cb17]) + by smtp.googlemail.com with ESMTPSA id + a204sm6588716wmf.12.2019.03.07.12.52.35 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Thu, 07 Mar 2019 12:52:35 -0800 (PST) +To: Marco Falke <falke.marco@gmail.com>, + Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org> +References: <CAK51vgDO2Tg38XbW0pqAnO3ETJ_qf8owRsUYsTXmrf7H2yGZtw@mail.gmail.com> +From: Aymeric Vitte <vitteaymeric@gmail.com> +Openpgp: preference=signencrypt +Autocrypt: addr=vitteaymeric@gmail.com; prefer-encrypt=mutual; keydata= + mQINBFdW8uABEAC7HJScbB2d/lmYoY5Cn9loEjJwfLs1LC3om030bWFGiH3Ceo5XeHUT94rw + Pi+HaHU8ea94425SXIFsnqp/ouoT/8Ffn6vED0OoRmK0jE4fqDApXSpoL2mHX9PAGdUItMtD + YrxBiBZNfMkctEsm4NrQ4TCvB3Yrm6Fc69inXJjUoYgPw5tHafEeI8Qwh0j99JZZDKcAqIra + JF3MPc59rATz0qOJtRP9EpsPVFwjJe13zN6CHILwiVgrL8EtT5WKCVO6ATxh60LHi8+MwPxV + V31zp/NNI5Hck+XocEMO98ZvUu9X8ZxmnOk/+9pBxXEwUqSGUNWdmPJLncpI23Usce3u/MOo + M2C4T4rD4J0XrXiyBvbeTvwq4qVNlyggeWzlBH+YpEYgDctPq4gNh4eoTtAkf8URtBeke5bQ + CGdaZt/jxv8nvmxs9V/iSyg5ldJLQktHStXOo0OZ7FEB2C6Ggtymm4hm2MHYg07Q1MGJrFLa + oJZkJ3JeXnVsZMam7ypQtld6rRa96CvH+llXwux6aQ5hKdzmBBMQ10LlkZhkExgTawbeqdiG + RMP2DjD5go6TPdAHS4NN34SBkrTWLqgWOjN/lnG77bbLnpMl0P+xBTuqw1oSXaDbcdHE2nGY + lRno/ZZIfr+1Bq56DZLBX/WpnAT4f5WtofL4CxQM9SbG6byyewARAQABtCJBeW1lcmljIFZp + dHRlIDxheW1lcmljQHBlZXJzbS5jb20+iQI/BBMBCAApBQJXVvLgAhsjBQkJZgGABwsJCAcD + AgEGFQgCCQoLBBYCAwECHgECF4AACgkQKh17NCYnrDm3WhAAlYmgtSmtfqjBvQMqkmtqiQJA + aZkzFZWt6+zroduHH5/Tp8jh73gFqCUyRrl/kcKvs2+XQhfrOwk1R6OScF25bpnrZSeuyJnZ + MZu4T0P2tGS8YdddQvWUHMtI9ZnQRuYmuZT23/hgj1JnukuGvGLeY0yDUa1xFffPN39shp5X + FPMcpIVOV3bs+xjAdsyfRyO3qJAD1FGiR7ggJeoaxUbKZ6NtcVUPPRMjVTKfopkuDwKY318m + BE0epfxSZ/iRhsJ0/sREUWgbgq4/QvCFwBKzgz7fTikGmf8OELWSdofmXs7gOtmMc3el8fJu + W8PVa/OsIQHDmwSzvxmE8ba5M8bdwOYEraTWFArIymAAtRXKxmuYpkqKfeSlbCwae3W+pgNT + 8nKYRVAFlMtIxYkmPYyMTk9kCscmSqugGWbWdnqe/dhVaa31xa1qO1tDH24D2/tjCJRQt4Jk + AEWNSmjCmjfeArMEFTGlZwMTAjVXErLSPbLOsZiZhD9sjvSbfzrtJiMli2h9+Dvds+AJk1PM + O8LW7cCNyFoCk4OdAxzJHobZ25G+uy4NSQEHgxLC2iuh/tugz1tOHnQczPc/3AkVVI9A5DF1 + gbVRBJh6rI7sAcwuR76uoOs0Rpp7r6I66xqU/5eq8g1OsJp89tw0ppSIa0YmaxNqQZ0l3rVX + o/ZwpBjtNQS5Ag0EV1by4AEQANhlz3Ywff4dY1HTdn05v0wVUxZzW2PUih+96m6EhpUrD9BT + vxriKtbgxm/zl+5YAlThbrk9f0QyVTHJ95Z1/M5qjuksP9Zn3qZ/8ylANDkN2s3z8Bq/LJA+ + u7+APhMqyFWK0FqNCOogClvijiKPEzkU6tmDGO6wZ5pR/u8Fdq7DGQgwgyGZZc7qstte0M7l + yx7bVRlPBqvd6kyX3YubQHzkctf46nFjiYZgKawdWFsA3PCdSBupbhixL5d/t1UK9ZTiQJcf + 0uhHzT06qwolFrm/ugkLDHtE4Zo3BuKch47Sms8P2hJ08gABxeJHg0ZgkIUy/Xf4nHbDCBJw + T8tE8pWYWA2ECiPNo0TOCMVOueEzISUNKINfCuFHSbMQU39hgt3ofxODbAjOiO3e/iu1ptck + AkuVBdtjOBP4tHRGxVrbf5EuAV5U5xtiSxMwMgojg0GIXZjnT/8uvWqcLqtJILRMmmu+WNvD + oxuiJzcTJhDai9oujmxQwcpMvgrBB89KSTDyitO5XVjZqaR7Zxvvn3rM4bAms/lotv9+pTyh + spazTIxb80u0ifJ6y1RxAkxQCfWwps1i3VbsM6OKX78aUyOf5V4ihXF57M37tOqPRwFvz6a+ + AIIhUNMTLo2H+o6Vw9qbX8SUxPHPs6YpJ8lWQJ9OMWHE+SbaDFAi/D5hYRubABEBAAGJAiUE + GAEIAA8FAldW8uACGwwFCQlmAYAACgkQKh17NCYnrDmk4Q/9Fuu0h5HvIiO3ieYA2StdE7hO + vv2THuesjJDsj6aQUTgknaxKptJogNe3dDyIT+FHxXmCw0Nrbm9Q3ryl80z/G9utfFNO3Gwc + q31QW3n3LJHnpqdrV3WsRzT5NwJMVtiIAGRrX8ZomtarWHT0PeEHC2xBdFzRrJtmkrwer0Wc + 0nBzD7vk1XEXC9nODbmlgsesoHFgRwQBst3wClCbX1gv8aSfxQNpaf9UBC8DmyrQ621UXpBo + PvcFEtWxV44vJfP0WOLCCN0Pzv2F2I66iKo7VMqbr5jlNAXJN9I1hXb7qwYJmBC9j5oeEoqv + A9d44WWpxrdAr8qih4Nv89k9+9F6NoqORY3FGuVDKiW8CVhCmGT7bIvNeyicVBZFipXqPcKL + VFduO2c5Ubc2npMWLUF1k9JJc9tH75l3+F/0RbYVTzGAZ+zSaudwR6h8YiCN2DBZGZkJEZbh + 3X/l6jtijMN/W9sPHyyKvm/TmeEC27S3TqZPZ8PUQLxZC70V6gMbenh01JdSQsn5t8Ru0RNh + Blt0g7IyZyIKCE9b+TyzbYpX6qgqEBUHia5b0vyPtQacWQlZ8uqnghAqNkLluEsy7Q/7xG6M + wXUYEDsFOmB9dKOzcAOIhpxlVjSKu5mzXJ11sEtE8nyF5NJ/riCA7FGcjlki3zIpzQUNo9v7 + vXl2h6Tivlk= +Message-ID: <bd7fbec9-3cc0-58c9-4312-ae0a8f4fc03f@gmail.com> +Date: Thu, 7 Mar 2019 21:52:33 +0100 +User-Agent: Mozilla/5.0 (Windows NT 6.3; rv:60.0) Gecko/20100101 + Thunderbird/60.5.1 +MIME-Version: 1.0 +In-Reply-To: <CAK51vgDO2Tg38XbW0pqAnO3ETJ_qf8owRsUYsTXmrf7H2yGZtw@mail.gmail.com> +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: 8bit +Content-Language: fr +X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, + DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, + RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 +X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on + smtp1.linux-foundation.org +X-Mailman-Approved-At: Thu, 07 Mar 2019 23:49:38 +0000 +Subject: Re: [bitcoin-dev] Removal of reject network messages from Bitcoin + Core (BIP61) +X-BeenThere: bitcoin-dev@lists.linuxfoundation.org +X-Mailman-Version: 2.1.12 +Precedence: list +List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org> +List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>, + <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe> +List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/> +List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org> +List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help> +List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>, + <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe> +X-List-Received-Date: Thu, 07 Mar 2019 20:52:38 -0000 + +Bitcoin-transactions did use this "feature", but does not rely on it any +longer since I observed some strange behavior sometimes (no reject +message for bad tx, with suprnova for example as far as I remember), +then it doublechecks using getdata to see if the tx is in mempool + +Indeed you can't trust what a node tells you with or without reject +(idem for getdata but more difficult to fake and better than nothing) + +Then I don't see any problem to remove it, taking into account also that +the error message is too vague to be really helpful +https://github.com/bitcoin/bitcoin/issues/11891 + +Le 06/03/2019 à 01:53, Marco Falke via bitcoin-dev a écrit : +> Bitcoin Core may send "reject" messages as response to "tx", "block" or +> "version" messages from a network peer when the message could not be accepted. +> +> This feature is toggled by the `-enablebip61` command line option and has been +> disabled by default since Bitcoin Core version 0.18.0 (not yet released as of +> time of writing). Nodes on the network can not generally be trusted to send +> valid ("reject") messages, so this should only ever be used when connected to a +> trusted node. At this time, I am not aware of any software that requires this +> feature, and I would like to remove if from Bitcoin Core to make the codebase +> slimmer, easier to understand and maintain. Let us know if your application +> relies on this feature and you can not use any of the recommended alternatives: +> +> * Testing or debugging of implementations of the Bitcoin P2P network protocol +> should be done by inspecting the log messages that are produced by a recent +> version of Bitcoin Core. Bitcoin Core logs debug messages +> (`-debug=<category>`) to a stream (`-printtoconsole`) or to a file +> (`-debuglogfile=<debug.log>`). +> +> * Testing the validity of a block can be achieved by specific RPCs: +> - `submitblock` +> - `getblocktemplate` with `'mode'` set to `'proposal'` for blocks with +> potentially invalid POW +> +> * Testing the validity of a transaction can be achieved by specific RPCs: +> - `sendrawtransaction` +> - `testmempoolaccept` +> +> * Wallets should not use the absence of "reject" messages to indicate a +> transaction has propagated the network, nor should wallets use "reject" +> messages to set transaction fees. Wallets should rather use fee estimation +> to determine transaction fees and set replace-by-fee if desired. Thus, they +> could wait until the transaction has confirmed (taking into account the fee +> target they set (compare the RPC `estimatesmartfee`)) or listen for the +> transaction announcement by other network peers to check for propagation. +> +> I propose to remove "reject" messages from Bitcoin Core 0.19.0 unless there are +> valid concerns about its removal. +> +> Marco +> _______________________________________________ +> bitcoin-dev mailing list +> bitcoin-dev@lists.linuxfoundation.org +> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev + +-- +Move your coins by yourself (browser version): https://peersm.com/wallet +Bitcoin transactions made simple: https://github.com/Ayms/bitcoin-transactions +Zcash wallets made simple: https://github.com/Ayms/zcash-wallets +Bitcoin wallets made simple: https://github.com/Ayms/bitcoin-wallets +Get the torrent dynamic blocklist: http://peersm.com/getblocklist +Check the 10 M passwords list: http://peersm.com/findmyass +Anti-spies and private torrents, dynamic blocklist: http://torrent-live.org +Peersm : http://www.peersm.com +torrent-live: https://github.com/Ayms/torrent-live +node-Tor : https://www.github.com/Ayms/node-Tor +GitHub : https://www.github.com/Ayms + + |