From rusty at rustcorp.com.au Wed Nov 28 03:39:25 2018 From: rusty at rustcorp.com.au (Rusty Russell) Date: Wed, 28 Nov 2018 14:09:25 +1030 Subject: [Lightning-dev] Approximate assignment of option names: please fix! In-Reply-To: <84294c1f-9c34-9827-0c1d-9872f8260c16@bitonic.nl> References: <87o9atrh59.fsf@rustcorp.com.au> <87tvkkh6zq.fsf@rustcorp.com.au> <84294c1f-9c34-9827-0c1d-9872f8260c16@bitonic.nl> Message-ID: <874lc1vpjm.fsf@rustcorp.com.au> Corn? Plooy via Lightning-dev writes: > The only reasons I see for keeping the global/local distinction is that > you might not want to gossip everything, either to keep the gossip data > small, or for some privacy reasons. Apparently, that's all very > theoretical so far, as current features don't seem to need either. It also matters for compulsory features. As written today, if you don't understand a global feature you can't *route* through a node. If you don't understand a local feature, you can't connect to a node. So if c-lightning made option_simplfied_commitment compulsory in version 13.0 (released from the Blockstream Moon Base), we'd also be telling nodes they can't route through us, which is a lie. Perhaps we can fix this by pointing it out: that you shouldn't set compulsory feature bits in your node_announcement unless you really want to stop routing too. So we still have a mental distinction between local and global feature bits, just not a bitmap distinction? Cheers, Rusty.