From rusty at rustcorp.com.au Sun May 7 03:00:21 2017 From: rusty at rustcorp.com.au (Rusty Russell) Date: Sun, 07 May 2017 12:30:21 +0930 Subject: [Lightning-dev] Minor editorial fixes to lightning-rfc In-Reply-To: <70a6I_mwYkiy2ifctNTq2gOsEYwf7nMWLv3QLOBIiW3p5JlgZReECFW7Gc25gEclDet4zBRA5wuMbSUga60G_0lLq52NXgUPteIqZiS8Ah4=@protonmail.com> References: <70a6I_mwYkiy2ifctNTq2gOsEYwf7nMWLv3QLOBIiW3p5JlgZReECFW7Gc25gEclDet4zBRA5wuMbSUga60G_0lLq52NXgUPteIqZiS8Ah4=@protonmail.com> Message-ID: <87efw1e5h6.fsf@rustcorp.com.au> ZmnSCPxj via Lightning-dev writes: > Good morning. > > Attached please find minor editorial patches to lighting-rfc. Hi! Thanks. We generally prefer minor fixes as github pull requests to avoid spamming the list, though if you don't github I'm happy to take them personally and apply them, as I've done in this case: https://github.com/lightningnetwork/lightning-rfc/pull/161 The list is generally better used for discussing large change proposals, though even they are better if they start with a github patch :) Thanks! Rusty. > > Regards, > ZmnSCPxj > From d107d6b60988e0d9f61cd400322021d87a22d8d8 Mon Sep 17 00:00:00 2001 > From: "ZmnSCPxj" > Date: Sun, 7 May 2017 00:40:22 +0000 > Subject: [PATCH 1/3] 02-peer-protocol.md: Minor typo: `update_htlc_add`, verb > should come first > > --- > 02-peer-protocol.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/02-peer-protocol.md b/02-peer-protocol.md > index 5751eb7..0c69724 100644 > --- a/02-peer-protocol.md > +++ b/02-peer-protocol.md > @@ -482,7 +482,7 @@ the blockchain. > > #### Requirements > > -A node MUST NOT offer an HTLC (`update_htlc_add`) in response to an incoming HTLC until > +A node MUST NOT offer an HTLC (`update_add_htlc`) in response to an incoming HTLC until > the incoming HTLC has been irrevocably committed. > > A node MUST NOT fail an incoming HTLC (`update_fail_htlc`) for which it has committed > -- > 2.11.0 > > From 288a34e6f650f4420a6f9e1614de3f5e873daf12 Mon Sep 17 00:00:00 2001 > From: "ZmnSCPxj" > Date: Sun, 7 May 2017 00:49:42 +0000 > Subject: [PATCH 2/3] 07-routing-gossip.md: Move some text about `ipv6` and > `port` from `channel_update` to `node_announcement`. > > `channel_update` does not make sense as it does not have fields > with either addresses or ports. > Moved it to `node_announcement` on the assumption that the text > was just inserted in the wrong place, since `node_announcement` > is described before `channel_update` and does have addresses > and ports. > --- > 07-routing-gossip.md | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/07-routing-gossip.md b/07-routing-gossip.md > index cc19da1..19898c7 100644 > --- a/07-routing-gossip.md > +++ b/07-routing-gossip.md > @@ -231,6 +231,9 @@ does not match the types defined above. The receiving node SHOULD > fail the connection if `addrlen` is insufficient to hold the address > descriptors of the known types. > > +The receiving node SHOULD ignore `ipv6-addr` or `ipv4-addr` > +if `port` is zero. > + > The receiving node SHOULD ignore the message if `node-id` is not > previously known from a `channel_announcement` message, or if > `timestamp` is not greater than the last-received > @@ -300,8 +303,7 @@ The creating node MUST set `timestamp` to greater than zero, and MUST set it to > It MUST set `cltv-expiry-delta` to the number of blocks it will subtract from an incoming HTLCs `cltv-expiry`. It MUST set `htlc-minimum-msat` to the minimum HTLC value it will accept, in millisatoshi. It MUST set `fee-base-msat` to the base fee it will charge for any HTLC, in millisatoshi, and `fee-proportional-millionths` to the amount it will charge per millionth of a satoshi. > > The receiving node MUST ignore `flags` other than the least significant bit. > -The receiving node SHOULD ignore `ipv6` > -if `port` is zero. It SHOULD ignore the message if `short-channel-id` does > +It SHOULD ignore the message if `short-channel-id` does > not correspond to a previously > known, unspent channel from `channel_announcement`, otherwise the node-id > is taken from the `channel_announcement` `node-id-1` if least-significant bit of flags is 0 or `node-id-2` otherwise. > -- > 2.11.0 > > From aca87a4e2598c0b4f785f109907d6a79b06989f5 Mon Sep 17 00:00:00 2001 > From: "ZmnSCPxj" > Date: Sun, 7 May 2017 00:54:29 +0000 > Subject: [PATCH 3/3] 07-routing-gossip.md: `channel_update`: Update text about > end indication. > > The channel end is now indicated via a single bit > in `flags`, not an entire byte. > --- > 07-routing-gossip.md | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/07-routing-gossip.md b/07-routing-gossip.md > index 19898c7..97eeb32 100644 > --- a/07-routing-gossip.md > +++ b/07-routing-gossip.md > @@ -264,7 +264,8 @@ padding within `addresses` if they require certain alignment. > > After a channel has been initially announced, each side independently > announces its fees and minimum expiry for HTLCs. It uses the 8-byte > -channel shortid which matches the `channel_announcement` and one byte > +channel shortid which matches the `channel_announcement` and one bit > +in the `flags` field > to indicate which end this is. It can do this multiple times, if > it wants to change fees. > > -- > 2.11.0 > > _______________________________________________ > Lightning-dev mailing list > Lightning-dev at lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/lightning-dev