From rusty at rustcorp.com.au Tue Dec 12 00:04:48 2017 From: rusty at rustcorp.com.au (Rusty Russell) Date: Tue, 12 Dec 2017 10:34:48 +1030 Subject: [Lightning-dev] [MINUTES] Dev Meeting 2017-12-12 ***TWO BREAKING CHANGES*** Message-ID: <87bmj4yfof.fsf@rustcorp.com.au> https://docs.google.com/document/d/1WaZDvCX7FsfZbrEMepLdchmDQyyRhY9MTBMF4NeZlOc/edit# Unusually, we had two minor breaking changes, despite the freeze: 1. `r` fee field is now base+millionths like channel_update. * Fixes case where there's no amount ('donation address'). * Nobody had implemented *using* this yet, and old versions will parse, just have wrong fee now. 2. nVersion for closing tx is 2, not 1. * Turns out everyone implemented that, since every other tx is version 2. * Advice from Mark Friedenbach was that using latest supported nVersion is best practice. Random notes: Lots of bug-and-quirk fixing as each team sees issues on our now-hetrogeneous testnet network, but it's been generally really stable and usable (as much as testnet can be). Rusty promised that the major churn from all the copyediting should be almost over; the big BOLTs have been refactored, it should now be more minor stuff. No meeting in 2 weeks, as that would be Christmas Day for most. Have a great break, and see you in 2018! Note the master doc for all minutes: https://docs.google.com/document/d/1oU4wxzGsYd0T084rTXJbedb7Gvdtj4ax638nMkYUmco/edit#