Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1RujhR-0002um-Rm for bitcoin-development@lists.sourceforge.net; Tue, 07 Feb 2012 11:59:05 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.210.175 as permitted sender) client-ip=209.85.210.175; envelope-from=makosoft@gmail.com; helo=mail-iy0-f175.google.com; Received: from mail-iy0-f175.google.com ([209.85.210.175]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-MD5:128) (Exim 4.76) id 1RujhO-0008Te-63 for bitcoin-development@lists.sourceforge.net; Tue, 07 Feb 2012 11:59:05 +0000 Received: by iaby12 with SMTP id y12so12944426iab.34 for ; Tue, 07 Feb 2012 03:58:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.180.233 with SMTP id dr9mr15577667igc.11.1328615539270; Tue, 07 Feb 2012 03:52:19 -0800 (PST) Received: by 10.43.48.135 with HTTP; Tue, 7 Feb 2012 03:52:19 -0800 (PST) In-Reply-To: References: Date: Tue, 7 Feb 2012 11:52:19 +0000 Message-ID: From: Aidan Thornton To: Wladimir Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.6 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (makosoft[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 AWL AWL: From: address is in the auto white-list X-Headers-End: 1RujhO-0008Te-63 Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] Multisignature transaction support in the GUI X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2012 11:59:05 -0000 On Mon, Feb 6, 2012 at 5:27 PM, Wladimir wrote: > Change BitcoinAddressValidator::MaxAddressLength to 35 > The addresses are validated with walletmodel->validateAddress which in tu= rn > calls=A0CBitcoinAddress addressParsed(addr) and then isValid(). Does this= work > for the new addresses? Should do (unless BIP 16 broke something). In fact both the GUI and RPC commands use CBitcoinAddress and IsValid to validate addresses in that way. > And maybe WalletModel::sendCoins has to be changed. > Does=A0CScript.SetBitcoinAddress work for the new address type? Again, should do, and it's used by the RPC commands for sending Bitcoins as well. Really there's not a lot that needs to be changed. I'm pretty sure even the change in MaxAddressLength is only necessary to send coins to multisig addresses on testnet, sending them on mainnet should just work.