Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1X7B84-0003Ry-M6 for bitcoin-development@lists.sourceforge.net; Tue, 15 Jul 2014 22:23:20 +0000 Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.219.49 as permitted sender) client-ip=209.85.219.49; envelope-from=voisine@gmail.com; helo=mail-oa0-f49.google.com; Received: from mail-oa0-f49.google.com ([209.85.219.49]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1X7B83-0002pi-IV for bitcoin-development@lists.sourceforge.net; Tue, 15 Jul 2014 22:23:20 +0000 Received: by mail-oa0-f49.google.com with SMTP id eb12so70527oac.8 for ; Tue, 15 Jul 2014 15:23:14 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.70.106 with SMTP id l10mr29577188oeu.54.1405462994055; Tue, 15 Jul 2014 15:23:14 -0700 (PDT) Received: by 10.60.169.109 with HTTP; Tue, 15 Jul 2014 15:23:13 -0700 (PDT) In-Reply-To: References: Date: Tue, 15 Jul 2014 15:23:13 -0700 Message-ID: From: Aaron Voisine To: Mike Hearn Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.6 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (voisine[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1X7B83-0002pi-IV Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] BIP 38 NFC normalisation issue X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jul 2014 22:23:20 -0000 If the user creates a password on an iOS device with an astral character and then can't enter that password on a JVM wallet, that sucks. If JVMs really can't support unicode NFC then that's a strong case to limit the spec to the subset of unicode that all popular platforms can support, but it sounds like it might just be a JVM string library bug that could hopefully be reported and fixed. I get the same result as in the test case using apple's CFStringNormalize(passphrase, kCFStringNormalizationFormC); Aaron Voisine breadwallet.com On Tue, Jul 15, 2014 at 11:20 AM, Mike Hearn wrote: > Yes, we know, Andreas' code is indeed doing normalisation. > > However it appears the output bytes end up being different. What I get back > is: > > cf930001303430300166346139 > > vs > > cf9300f0909080f09f92a9 > > from the spec. > > I'm not sure why. It appears this is due to the character from the astral > planes. Java is old and uses 16 bit characters internally - it wouldn't > surprise me if there's some weirdness that means it doesn't/won't support > this kind of thing. > > I recommend instead that any implementation that wishes to be compatible > with JVM based wallets (I suspect Android is the same) just refuse any > passphrase that includes characters outside the BMP. At least unless someone > can find a fix. I somehow doubt this will really hurt anyone. > > ------------------------------------------------------------------------------ > Want fast and easy access to all the code in your enterprise? Index and > search up to 200,000 lines of code with a free copy of Black Duck > Code Sight - the same software that powers the world's largest code > search on Ohloh, the Black Duck Open Hub! Try it now. > http://p.sf.net/sfu/bds > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development >