Return-Path: <alice@librelamp.com>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id 0CA3F959
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 19 Dec 2016 08:14:01 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from librelamp.com (librelamp.com [45.79.96.192])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A61F3DF
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 19 Dec 2016 08:14:00 +0000 (UTC)
Received: from localhost.localdomain (c-50-184-37-123.hsd1.ca.comcast.net
	[50.184.37.123]) by librelamp.com (Postfix) with ESMTPSA id 179A4819
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 19 Dec 2016 08:14:00 +0000 (UTC)
To: bitcoin-dev@lists.linuxfoundation.org
References: <f27bd300c20d1b48cddc7e1d1dc1a96c@112bit.com>
	<615c88d2a1263810923705c170b25d33@112bit.com>
	<d2e0dd76-e6ec-8ccb-5a33-48f0d005afe9@librelamp.com>
	<7f51525a-6aeb-e1cd-060c-2f7f34700b6b@vt.edu>
From: Alice Wonder <alice@librelamp.com>
Message-ID: <a5f216cb-7a06-a52f-c132-9fc5dcba138e@librelamp.com>
Date: Mon, 19 Dec 2016 00:13:51 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
	Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <7f51525a-6aeb-e1cd-060c-2f7f34700b6b@vt.edu>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD
	autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
Subject: Re: [bitcoin-dev] Python test suite failures (was Re: Planned
 Obsolescence)
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Protocol Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Dec 2016 08:14:01 -0000

On 12/18/2016 12:51 PM, Douglas Roark via bitcoin-dev wrote:
> On 2016/12/18 12:07, Alice Wonder via bitcoin-dev wrote:
>> I almost did not update to 0.13.0 because the test suite was failing due
>> to python errors. How to fix them was posted on bitcointalk.
>>
>> 0.13.1 came with new python errors in the test suite. So I just said
>> fuck it.
>>
>> When the test suite actually works in my fairly standard environment
>> (CentOS) in the distributed release, I will upgrade.
>
> Can you post more info about the problems you're seeing, how you fixed
> them, your environment, etc., or at least post an issue on Github? I'm
> sure somebody would be happy to help. Some info on how to reproduce the
> problems would be very helpful. :)
>
> Thanks.

For 0.13.0 I had to do

export LANG=en_US.utf8

before running the test suite. I build in clean chroot build environment 
to avoid accidental linking to non-standard libraries, and in that 
environment the LANG is normally set to C as LANG normally doesn't 
matter for compiling software that is expected to run regardless of what 
the LANG is.

That I believe was fixed in 0.13.1.

In 0.13.1 the error is


Running test/bitcoin-util-test.py...
Traceback (most recent call last):
   File "./test/bitcoin-util-test.py", line 12, in <module>
     "bitcoin-util-test.json",buildenv)
   File "/builddir/build/BUILD/bitcoin-0.13.1/src/test/bctest.py", line 
54, in bctester
     bctest(testDir, testObj, buildenv.exeext)
   File "/builddir/build/BUILD/bitcoin-0.13.1/src/test/bctest.py", line 
26, in bctest
     outputData = open(testDir + "/" + outputFn).read()
FileNotFoundError: [Errno 2] No such file or directory: 
'./test/data/blanktx.json'
make[3]: *** [check-local] Error 1
make[3]: Leaving directory `/builddir/build/BUILD/bitcoin-0.13.1/src'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/builddir/build/BUILD/bitcoin-0.13.1/src'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/bitcoin-0.13.1/src'
make: *** [check-recursive] Error 1

0.13.0 test works just fine (once the LANG is set to something utf8)