Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.161.47 as permitted sender)
	client-ip=209.85.161.47; envelope-from=chris.double@gmail.com;
	helo=mail-fx0-f47.google.com; 
MIME-Version: 1.0
Sender: chris.double@gmail.com
In-Reply-To: <CALn1vHHynfb-u8fSwsStA=e5vR6x-e3yA44Z9Mt9A+AgO1+ezQ@mail.gmail.com>
References: <CALn1vHHynfb-u8fSwsStA=e5vR6x-e3yA44Z9Mt9A+AgO1+ezQ@mail.gmail.com>
Date: Sun, 4 Sep 2011 02:16:40 +1200
Message-ID: <CALn1vHHZAfE+phvcaSQNaaAgWPjVGfhOXKyp+hofrYgwAKBR9w@mail.gmail.com>
From: Chris Double <chris.double@double.co.nz>
To: bitcoin-development@lists.sourceforge.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Bitcoin-development] Transaction limit size in
	CWallet::CreateTransaction
Precedence: list

On Sun, Sep 4, 2011 at 1:52 AM, Chris Double <chris.double@double.co.nz> wrote:
> So was the intent to use the CWalletTxn size, and the casting is
> superfluous, or was it supposed to be the CTransaction* portion and
> the cast is an incorrect way of doing that? Or am I suffering from
> late night programmer syndrome and reading it wrong?

After a discussion on #bitcoin-dev it is indeed the latter. I was
under the mistaken believe that the GetSerializeSize method in
CTransaction and CWalletTxn were virtual, which would result in the
behavior I was thinking of. But they're not so it works. Please
disregard!

Chris.
-- 
http://www.bluishcoder.co.nz