Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1RR2xC-0005H5-4e for bitcoin-development@lists.sourceforge.net; Thu, 17 Nov 2011 14:28:38 +0000 Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.161.47 as permitted sender) client-ip=209.85.161.47; envelope-from=gavinandresen@gmail.com; helo=mail-fx0-f47.google.com; Received: from mail-fx0-f47.google.com ([209.85.161.47]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1RR2x8-0000St-Bq for bitcoin-development@lists.sourceforge.net; Thu, 17 Nov 2011 14:28:38 +0000 Received: by faat2 with SMTP id t2so4252632faa.34 for ; Thu, 17 Nov 2011 06:28:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.152.109.33 with SMTP id hp1mr23396921lab.36.1321540108007; Thu, 17 Nov 2011 06:28:28 -0800 (PST) Received: by 10.152.30.69 with HTTP; Thu, 17 Nov 2011 06:28:27 -0800 (PST) Date: Thu, 17 Nov 2011 09:28:27 -0500 Message-ID: From: Gavin Andresen To: Bitcoin Dev Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -1.6 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gavinandresen[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 AWL AWL: From: address is in the auto white-list X-Headers-End: 1RR2x8-0000St-Bq Subject: [Bitcoin-development] There will be a release candidate 6... X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2011 14:28:38 -0000 I got email from a tester who gave this feedback: > I think that user behaviour: encrypt wallet -> backup -> do some activity -> > restore backup -> BOOM. Is perfectly natural user behaviour and it will > happen. For example when generating a wallet on a secure computer and then > moving it to an insecure one. I agree that is likely to happen and, when it does, will be disastrous. So I'll be reworking the wallet encrypt/rewrite code today and creating a release candidate 6. My previous attempt (encrypt, invalidating keypool, then unlock and write a new keypool) resulted in unencrypted private keys in the new wallet. I think this will work, I'll implement and test today. Invalidate all the old keypool keys in the old wallet.Write new keypool keys to the old wallet.Encrypt all the keys in the old wallet.Rewrite the old wallet to create a new wallet.Shutdown/restart. IF ANYBODY IS WILLING TO HELP: There is still a mysterious problem with bdb throwing an exception when dbenv.close(0) is called during shutdown. If you can compile a -g version of bdb and then step through DbEnv::close in a debugger and tell me why it is throwing an exception that would be extremely helpful. -- -- Gavin Andresen