Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.213.170 as permitted sender)
	client-ip=209.85.213.170; envelope-from=laanwj@gmail.com;
	helo=mail-ig0-f170.google.com; 
MIME-Version: 1.0
In-Reply-To: <545747E7.6030403@numlog.fr>
References: <545747E7.6030403@numlog.fr>
Date: Mon, 3 Nov 2014 11:11:09 +0100
Message-ID: <CA+s+GJCQXWOP4PeGE=6_JYfiW8-=ssafr9BuvtV-fT1NiXiq4w@mail.gmail.com>
From: Wladimir <laanwj@gmail.com>
To: Francis GASCHET <fg@numlog.fr>
Content-Type: text/plain; charset=UTF-8
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Bug in genbuild.sh ?
Precedence: list

On Mon, Nov 3, 2014 at 10:16 AM, Francis GASCHET <fg@numlog.fr> wrote:
> Hello,
>
> I just compiled bitCoin core on Debian 7.
> I got an error message "too many arguments" when executing genuid.sh
> I fixed it as shown hereafter and it worked fine.
>
>
> pcfg:~/bitcoinCore> diff -u shareOLD/genbuild.sh share/genbuild.sh
> --- shareOLD/genbuild.sh        2014-11-03 08:32:08.950708258 +0100
> +++ share/genbuild.sh   2014-11-03 08:38:44.626698114 +0100
> @@ -16,7 +16,7 @@
>   DESC=""
>   SUFFIX=""
>   LAST_COMMIT_DATE=""
> -if [ -e "$(which git 2>/dev/null)" -a $(git rev-parse
> --is-inside-work-tree 2>/dev/null) = "true" ]; then
> +if [ -e "$(which git 2>/dev/null)" -a "$(git rev-parse
> --is-inside-work-tree 2>/dev/null)" = "true" ]; then
>       # clean 'dirty' status of touched files that haven't been modified
>       git diff >/dev/null 2>/dev/null

ACK

FYI there's an issue for this on github:
https://github.com/bitcoin/bitcoin/pull/5141 , but Rebroad's solution
contains a new error. Will merge your patch.

Wladimir