Delivery-date: Sat, 04 May 2024 08:40:31 -0700
Sender: bitcoindev@googlegroups.com
Date: Sat, 4 May 2024 08:00:07 -0700 (PDT)
From: Fractal Encrypt <fractalencryptlsd@gmail.com>
To: Bitcoin Development Mailing List <bitcoindev@googlegroups.com>
Message-Id: <75628135-32ae-4df3-be52-9f7d054bc096n@googlegroups.com>
Subject: [bitcoindev] A Fool's Errand or should I try?
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_1712_337132614.1714834807661"
Precedence: list
Mailing-list: list bitcoindev@googlegroups.com; contact bitcoindev+owners@googlegroups.com

------=_Part_1712_337132614.1714834807661
Content-Type: multipart/alternative; 
	boundary="----=_Part_1713_833547110.1714834807661"

------=_Part_1713_833547110.1714834807661
Content-Type: text/plain; charset="UTF-8"

TLDR: I'd like to investigate the possibilities of extending 
decoderawtransaction to include the fee (and maybe even sats per v/b).

I'm hoping it will be a good project for me to work on and build at least a 
tiny understanding of bitcoin development.

------------------------------------------------------------------------

I use the createrawtransaction function to create transactions, and before 
broadcasting, I always like to use decoderawtransaction to see if I made 
any mistakes.

I've sometimes messed up on the fee calculation, as I do that myself with a 
calculator.

Unfortunately decoderawtransaction doesn't give me the fee information (for 
a very good reason, it is not aware of the value of the inputs in the tx).

So to double check the fees, instead of using createrawtransaction, I'll 
use createpsbt and then go through the process of finalizing it so I can 
run decodepsbt, which does give the fee along with all the other relevant 
data.

But the createpsbt process is more work for a simple transaction where all 
UTXOs are in the wallet I am creating the rawtx in.

My goal would be to modify decoderawtransaction to perform these additional 
steps:
   
   1. Fetch UTXO details for each input.
   2. Calculate the total input value.
   3. Subtract the total output value to determine the fee.

Additionally there are the considerations about whether the inputs in the 
transaction are in your wallet or not. 

If I run listunspent it gives me the info I need to create the raw tx or 
psbt, and it has the values of the UTXOs that will be used as inputs in my 
tx.

But I understand decoderawtransaction is meant to be used whether or not 
the keys are in your wallet (so I was thinking to make a command argument 
T/F to show the fee value only if keys are in your wallet).

Alternatively if you are running the command in a node with txindex, then 
you have the full chainstate to look up txids (whether unspent or not) - so 
this needs to be addressed too.

Doing this within my own node would be cool enough and I don't necessarily 
need it to go farther than that. However if I do get it working, I'd 
certainly try to submit a PR.

I have no idea if any of this is possible, so I wanted to ask here for some 
guidance and maybe mentorship in this self-interest driven project. Also 
looking for this to be shot down mercilessly if it's just ridiculous.

My abilities and skills are very low. My interest and persistence are high.

Any help or ridicule invited ;)

-- 
You received this message because you are subscribed to the Google Groups "Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bitcoindev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/bitcoindev/75628135-32ae-4df3-be52-9f7d054bc096n%40googlegroups.com.

------=_Part_1713_833547110.1714834807661
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div>TLDR: I'd like to investigate the possibilities of extending decoderaw=
transaction to include the fee (and maybe even sats per v/b).</div><div><br=
 /></div><div>I'm hoping it will be a good project for me to work on and bu=
ild at least a tiny understanding of bitcoin development.</div><div><br /><=
/div><div>-----------------------------------------------------------------=
-------<br /></div><div><br /></div><div>I use the createrawtransaction fun=
ction to create transactions, and before broadcasting, I always like to use=
 decoderawtransaction to see if I made any mistakes.</div><div><br /></div>=
<div>I've sometimes messed up on the fee calculation, as I do that myself w=
ith a calculator.</div><div><br /></div><div>Unfortunately decoderawtransac=
tion doesn't give me the fee information (for a very good reason, it is not=
 aware of the value of the inputs in the tx).</div><div><br /></div><div>So=
 to double check the fees, instead of using createrawtransaction, I'll use =
createpsbt and then go through the process of finalizing it so I can run de=
codepsbt, which does give the fee along with all the other relevant data.<b=
r /></div><div><br /></div><div>But the createpsbt process is more work for=
 a simple transaction where all UTXOs are in the wallet I am creating the r=
awtx in.</div><div><br /></div><div>My goal would be to modify <span>decode=
rawtransaction</span> to perform these additional steps:<ol><li>Fetch UTXO =
details for each input.</li><li>Calculate the total input value.</li><li>Su=
btract the total output value to determine the fee.</li></ol><div>Additiona=
lly there are the considerations about whether the inputs in the transactio=
n are in your wallet or not. <br /></div><div><br /></div><div>If I run lis=
tunspent it gives me the info I need to create the raw tx or psbt, and it h=
as the values of the UTXOs that will be used as inputs in my tx.<br /><br /=
>But I understand decoderawtransaction is meant to be used whether or not t=
he keys are in your wallet (so I was thinking to make a command argument T/=
F to show the fee value only if keys are in your wallet).<br /><br />Altern=
atively if you are running the command in a node with txindex, then you hav=
e the full chainstate to look up txids (whether unspent or not) - so this n=
eeds to be addressed too.</div><div><br /></div><div>Doing this within my o=
wn node would be cool enough and I don't necessarily need it to go farther =
than that. However if I do get it working, I'd certainly try to submit a PR=
.<br /></div><div><br />I have no idea if any of this is possible, so I wan=
ted to ask here for some guidance and maybe mentorship in this self-interes=
t driven project. Also looking for this to be shot down mercilessly if it's=
 just ridiculous.</div><div><br /></div><div>My abilities and skills are ve=
ry low. My interest and persistence are high.</div><div><br /></div><div>An=
y help or ridicule invited ;)<br /></div>

</div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;Bitcoin Development Mailing List&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:bitcoindev+unsubscribe@googlegroups.com">bitcoind=
ev+unsubscribe@googlegroups.com</a>.<br />
To view this discussion on the web visit <a href=3D"https://groups.google.c=
om/d/msgid/bitcoindev/75628135-32ae-4df3-be52-9f7d054bc096n%40googlegroups.=
com?utm_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/d/msg=
id/bitcoindev/75628135-32ae-4df3-be52-9f7d054bc096n%40googlegroups.com</a>.=
<br />

------=_Part_1713_833547110.1714834807661--

------=_Part_1712_337132614.1714834807661--