Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XycWA-0003BW-Jf for bitcoin-development@lists.sourceforge.net; Wed, 10 Dec 2014 08:21:06 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.223.176 as permitted sender) client-ip=209.85.223.176; envelope-from=laanwj@gmail.com; helo=mail-ie0-f176.google.com; Received: from mail-ie0-f176.google.com ([209.85.223.176]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1XycWA-0003u7-0H for bitcoin-development@lists.sourceforge.net; Wed, 10 Dec 2014 08:21:06 +0000 Received: by mail-ie0-f176.google.com with SMTP id tr6so2214391ieb.21 for ; Wed, 10 Dec 2014 00:21:00 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.107.159.19 with SMTP id i19mr2598998ioe.79.1418199660738; Wed, 10 Dec 2014 00:21:00 -0800 (PST) Received: by 10.64.195.164 with HTTP; Wed, 10 Dec 2014 00:21:00 -0800 (PST) In-Reply-To: References: <54876653.4020403@certimix.com> <548769FA.5040406@bluematt.me> Date: Wed, 10 Dec 2014 08:21:00 +0000 Message-ID: From: Wladimir To: Matt Corallo Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.6 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (laanwj[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1XycWA-0003u7-0H Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] ACK NACK utACK "Concept ACK" X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 08:21:06 -0000 On Wed, Dec 10, 2014 at 6:47 AM, Wladimir wrote: > Abbreviations: > > Concept ACK -> agree with the idea and overall direction, but haven't > reviewed the code changes nor tested it > utACK -> reviewed the code changes, but did not put it through any testing > Tested ACK -> reviewed the code changes and verified the functionality/bug fix And there is also NACK, that's an aspecific 'I wouldn't like this merged'. I always explain why in the text. A document on this would be welcome, as it may look like Martian to outsiders. That's been brought up many times before, but no one ever created it. Wladimir