MIME-Version: 1.0
Sender: earonesty@gmail.com
From: Erik Aronesty <erik@q32.com>
Date: Sun, 13 Aug 2017 14:46:37 -0400
Message-ID: <CAJowKgLXhS2SxwuJnfbHzKSzw+aZie5aO2EsC9qbwWJXMNDuRw@mail.gmail.com>
To: Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Content-Type: multipart/alternative; boundary="001a11459da05c8cbb0556a6f782"
Subject: [bitcoin-dev] Would anyone object to adding a dlopen message hook
	system?
Precedence: list

--001a11459da05c8cbb0556a6f782
Content-Type: text/plain; charset="UTF-8"

I was thinking about something like this that could add the ability for
module extensions in the core client.

When messages are received, modules hooks are called with the message data.


They can then handle, mark the peer invalid, push a message to the peer or
pass through an alternate command.  Also, modules could have their own
private commands prefixed by "x:" or something like that.

The idea is that the base P2P layer is left undisturbed, but there is now a
way to create "enhanced features" that some peers support.

My end goal is to support using lightning network micropayments to allow
people to pay for better node access - creating a market for node services.


But I don't think this should be "baked in" to core.   Nor do I think it
should be a "patch".   It should be a linked-in module, optionally compiled
and added to bitcoin conf, then loaded via dlopen().    Modules should be
slightly robust to Bitcoin versions changing out from under them, but not
if the network layer is changed.   This can be ensured by a) keeping a
module version number, and b) treating module responses as if they were
just received from the network.   Any module incompatibility should throw
an exception...ensuring broken peers don't stay online.

In general I think the core reference would benefit from the ability to
create subnetworks within the Bitcoin ecosystem.   Right now, we have two
choices... full node and get slammed with traffic, or listen-only node, and
do nothing.

Adding a module/hook system would allow a complex ecosystem of
participation - and it would seem to be far more robust in the long term.

Something like this???

class MessageHookIn {
public:
    int hookversion;
    int64_t nodeid;
    int nVersion;
    int64_t serviceflags;
    const char *strCommand;
    const char *nodeaddr;
    const char *vRecv;
    int vRecvLen;
    int64_t nTimeReceived;
};

class MessageHookOut {
public:
    int hookversion;
    int misbehaving;
    const char *logMsg;
    const char *pushCommand;
    const unsigned char *pushData;
    int pushDataLen;
    const char *passCommand;
    CDataStream passStream;
};

class MessageHook {
public:
    int hookversion;
    std::string name;
    typedef bool (*HandlerType)(const MessageHookIn *in, MessageHookOut
*out);
    HandlerType handle;
};

--001a11459da05c8cbb0556a6f782
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I was thinking about something like this that could add th=
e ability for module extensions in the core client. =C2=A0 <br><br>When mes=
sages are received, modules hooks are called with the message data. =C2=A0 =
<br><br>They can then handle, mark the peer invalid, push a message to the =
peer or pass through an alternate command.=C2=A0 Also, modules could have t=
heir own private commands prefixed by &quot;x:&quot; or something like that=
. =C2=A0=C2=A0<div><br></div><div>The idea is that the base P2P layer is le=
ft undisturbed, but there is now a way to create &quot;enhanced features&qu=
ot; that some peers support.</div><div><br>My end goal is to support using =
lightning network micropayments to allow people to pay for better node acce=
ss - creating a market for node services. =C2=A0=C2=A0<br><br>But I don&#39=
;t think this should be &quot;baked in&quot; to core. =C2=A0 Nor do I think=
 it should be a &quot;patch&quot;. =C2=A0 It should be a linked-in module, =
optionally compiled and added to bitcoin conf, then loaded via dlopen(). =
=C2=A0 =C2=A0Modules should be slightly robust to Bitcoin versions changing=
 out from under them, but not if the network layer is changed. =C2=A0 This =
can be ensured by a) keeping a module version number, and b) treating modul=
e responses as if they were just received from the network. =C2=A0 Any modu=
le incompatibility should throw an exception...ensuring broken peers don=
9;t stay online.<br><br>In general I think the core reference would benefit=
 from the ability to create subnetworks within the Bitcoin ecosystem. =C2=
=A0 Right now, we have two choices... full node and get slammed with traffi=
c, or listen-only node, and do nothing. =C2=A0<br><br>Adding a module/hook =
system would allow a complex ecosystem of participation - and it would seem=
 to be far more robust in the long term.=C2=A0</div><div><br></div><div>Som=
ething like this???<br><br><div>class MessageHookIn {</div><div>public:</di=
v><div>=C2=A0 =C2=A0 int hookversion;</div><div>=C2=A0 =C2=A0 int64_t nodei=
d;</div><div>=C2=A0 =C2=A0 int nVersion;</div><div>=C2=A0 =C2=A0 int64_t se=
rviceflags;</div><div>=C2=A0 =C2=A0 const char *strCommand;</div><div>=C2=
=A0 =C2=A0 const char *nodeaddr;</div><div>=C2=A0 =C2=A0 const char *vRecv;=
</div><div>=C2=A0 =C2=A0 int vRecvLen;</div><div>=C2=A0 =C2=A0 int64_t nTim=
eReceived;</div><div>};</div><div><br></div><div>class MessageHookOut {</di=
v><div>public:</div><div>=C2=A0 =C2=A0 int hookversion;</div><div>=C2=A0 =
=C2=A0 int misbehaving;</div><div>=C2=A0 =C2=A0 const char *logMsg;</div><d=
iv>=C2=A0 =C2=A0 const char *pushCommand;</div><div>=C2=A0 =C2=A0 const uns=
igned char *pushData;</div><div>=C2=A0 =C2=A0 int pushDataLen;</div><div>=
=C2=A0 =C2=A0 const char *passCommand;</div><div>=C2=A0 =C2=A0 CDataStream =
passStream;</div><div>};<br></div><div><br><div>class MessageHook {</div><d=
iv>public:</div><div>=C2=A0 =C2=A0 int hookversion;</div><div>=C2=A0 =C2=A0=
 std::string name;</div><div>=C2=A0 =C2=A0 typedef bool (*HandlerType)(cons=
t MessageHookIn *in, MessageHookOut *out);</div><div>=C2=A0 =C2=A0 HandlerT=
ype handle;</div><div>};</div><div><br></div><br></div></div></div>

--001a11459da05c8cbb0556a6f782--