Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UMnJa-0006gG-1R for bitcoin-development@lists.sourceforge.net; Mon, 01 Apr 2013 22:34:58 +0000 X-ACL-Warn: Received: from mail-qc0-f174.google.com ([209.85.216.174]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1UMnJY-0000dy-Mq for bitcoin-development@lists.sourceforge.net; Mon, 01 Apr 2013 22:34:58 +0000 Received: by mail-qc0-f174.google.com with SMTP id z24so1273571qcq.5 for ; Mon, 01 Apr 2013 15:34:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=Pk7K09JRMyHT4H715znlsCAAPKRFx7CaCz+6aySxHhA=; b=hF/aRfpM5Ku6fYs93+SGHDEGCvTe+cthlm739Z8gPgnueUZKEJd0Oh+17iC4bZkRZL 7BYXJPm35ndNFQ7r8EN8s1ElG0swUqpt+BO9S+HtX+tBDg0BrjEoOQEDgvxH+o5Ssfo8 6QAJRwj1+dUgcjlbDiqYqMPz+9SU2utPsOVuSXEVPoyafZyz7pzMHoMMKGlk+ThcWJMl hgjdRGMnHMjJ4eIWMFNpKv40D+gzccFSlfJuUEeytysaETbhdNPHlNWrYshDuUnm7vuZ UxN6UveCkwUFgfx15o++GOFRin0nXoH9ZEvBaRuw9WDY8/h8vn59+0fp//vmWp4lnebm m8og== X-Received: by 10.49.87.40 with SMTP id u8mr15450968qez.62.1364854246721; Mon, 01 Apr 2013 15:10:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.49.14.194 with HTTP; Mon, 1 Apr 2013 15:10:26 -0700 (PDT) In-Reply-To: References: From: Will Date: Tue, 2 Apr 2013 00:10:26 +0200 Message-ID: To: Melvin Carvalho Content-Type: multipart/alternative; boundary=047d7bdc8b0a8be23604d953e4a5 X-Gm-Message-State: ALoCoQnXvciVBEBoYHuFADCJJARmfJr7WjNeVRocgd+FOEn66uEwTdBHzjxkxwbBI2BcrT2JHjQS X-Spam-Score: 1.0 (+) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 1.0 HTML_MESSAGE BODY: HTML included in message X-Headers-End: 1UMnJY-0000dy-Mq Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] bitcoin pull requests X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 22:34:58 -0000 --047d7bdc8b0a8be23604d953e4a5 Content-Type: text/plain; charset=ISO-8859-1 The threat of a SHA1 collision attack to insert a malicious pull request are tiny compared with the other threats - e.g. github being compromised, one of the core developers' passwords being compromised, one of the core developers going rogue, sourceforge (distribution site) being compromised etc etc... believe me there's a lot more to worry about than a SHA1 attack... Not meaning to scare, just to put things in perspective - this is why we all need to peer review each others commits and keep an eye out for suspicious commits, leverage the benefits of this project being open source and easily peer reviewed. Will On 1 April 2013 23:52, Melvin Carvalho wrote: > > > > On 1 April 2013 20:28, Petr Praus wrote: > >> An attacker would have to find a collision between two specific pieces of >> code - his malicious code and a useful innoculous code that would be >> accepted as pull request. This is the second, much harder case in the >> birthday problem. When people talk about SHA-1 being broken they actually >> mean the first case in the birthday problem - find any two arbitrary values >> that hash to the same value. So, no I don't think it's a feasible attack >> vector any time soon. >> >> Besides, with that kind of hashing power, it might be more feasible to >> cause problems in the chain by e.g. constantly splitting it. >> > > OK, maybe im being *way* too paranoid here ... but what if someone had > access to github, could they replace one file with one they had prepared at > some point? > > >> >> >> On 1 April 2013 03:26, Melvin Carvalho wrote: >> >>> I was just looking at: >>> >>> https://bitcointalk.org/index.php?topic=4571.0 >>> >>> I'm just curious if there is a possible attack vector here based on the >>> fact that git uses the relatively week SHA1 >>> >>> Could a seemingly innocuous pull request generate another file with a >>> backdoor/nonce combination that slips under the radar? >>> >>> Apologies if this has come up before ... >>> >>> >>> ------------------------------------------------------------------------------ >>> Own the Future-Intel® Level Up Game Demo Contest 2013 >>> Rise to greatness in Intel's independent game demo contest. >>> Compete for recognition, cash, and the chance to get your game >>> on Steam. $5K grand prize plus 10 genre and skill prizes. >>> Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d >>> _______________________________________________ >>> Bitcoin-development mailing list >>> Bitcoin-development@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/bitcoin-development >>> >>> >> > > > ------------------------------------------------------------------------------ > Own the Future-Intel® Level Up Game Demo Contest 2013 > Rise to greatness in Intel's independent game demo contest. > Compete for recognition, cash, and the chance to get your game > on Steam. $5K grand prize plus 10 genre and skill prizes. > Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development > > --047d7bdc8b0a8be23604d953e4a5 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
The threat of a SHA1 collision attack to insert a maliciou= s pull request are tiny compared with the other threats - e.g. github being= compromised, one of the core developers' passwords being compromised, = one of the core developers going rogue, sourceforge (distribution site) bei= ng compromised etc etc... believe me there's a lot more to worry about = than a SHA1 attack...

Not meaning to scare, just to put things in perspectiv= e - this is why we all need to peer review each others commits and keep an = eye out for suspicious commits, leverage the benefits of this project being= open source and easily peer reviewed.

Will

On 1 April 2013 23:52, Melvin Carvalho <melvincarvalho@gmail.com> wrote:



On 1 April 2013 20= :28, Petr Praus <petr@praus.net> wrote:
An attacker would have to find a collision between two spe= cific pieces of code - his malicious code and a useful innoculous code that= would be accepted as pull request. This is the second, much harder case in= the birthday problem. When people talk about SHA-1 being broken they actua= lly mean the first case in the birthday problem - find any two arbitrary va= lues that hash to the same value. So, no I don't think it's a feasi= ble attack vector any time soon.

Besides, with that kind of hashing power, it might be more f= easible to cause problems in the chain by e.g. constantly splitting it.

OK, maybe im being *way* too= paranoid here ... but what if someone had access to github, could they rep= lace one file with one they had prepared at some point?
=A0


On 1 April 2013 03:26, Melvin Carvalho <melvincarvalho@gmail.com> wrote:
I'm just curio= us if there is a possible attack vector here based on the fact that git use= s the relatively week SHA1

Could a seemingly innocuous pull request generate another file wi= th a backdoor/nonce combination that slips under the radar?

Ap= ologies if this has come up before ...

-----------------------------------------------------------= -------------------
Own the Future-Intel&reg; Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game
on Steam. $5K grand prize plus 10 genre and skill prizes.
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
___________= ____________________________________
Bitcoin-development mailing list
Bitcoin-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bitcoin-de= velopment




-----------------------------------------------------------------------= -------
Own the Future-Intel&reg; Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game
on Steam. $5K grand prize plus 10 genre and skill prizes.
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
___________= ____________________________________
Bitcoin-development mailing list
Bitcoin-develo= pment@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bitcoin-de= velopment


--047d7bdc8b0a8be23604d953e4a5--