Date: Sat, 1 Jan 2022 22:03:11 +0100 (CET)
From: Prayank <prayank@tutanota.de>
To: Bitcoin Dev <bitcoin-dev@lists.linuxfoundation.org>
Message-ID: <MsMS0F9--3-2@tutanota.de>
MIME-Version: 1.0
Content-Type: multipart/alternative; 
 boundary="----=_Part_476048_1592426282.1641070991314"
Subject: [bitcoin-dev] Nuke *notify options from Bitcoin Core
Precedence: list

------=_Part_476048_1592426282.1641070991314
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hello World,

What?

Remove all *notify options from Bitcoin Core (full node implementation used by 99% nodes)

Or one of the below:

notifications.dat
not use system() in runCommand()
Use a new setting in settings.json file, notifypolicy which is 0 by default (restricted) and can be set to 1 (unrestricted)

Why?

They can help attackers in doing almost anything on machines running Bitcoin Core with some social engineering.

How?

Everything is explained several times in different issues, PRs etc. to different people including few reviewers who even NACKed a PR that would help in adding such options but with some documentation. I won't comment much about the reviewers but some of them were clueless about issue and how things work.

Example: Calling something misleading and ludicrous when you don't even know what works in Windows shortcut and could not share one example of financial application https://github.com/bitcoin/bitcoin/issues/23412#issuecomment-1003496126

TL;DR

https://github.com/bitcoin/bitcoin/pull/23395#issuecomment-956353035

https://github.com/bitcoin/bitcoin/issues/23412#issuecomment-970480769

To be honest, neither I have energy left to highlight the importance of these issues nor most of the people look interested in this space to address it. This email is a part of my efforts to share things with everyone which I even tried with documentation. There is something seriously wrong if few people including maintainers acknowledge the issues with *notify options but nobody wants to fix it or document it, I will leave it for people to form their own opinions about it.

Last but not least I was even asked to not review and comment in https://github.com/bitcoin/bitcoin/pull/23395 when I was just responding to others. 

This will be helpful in my security project which was already shared in mailing list to highlight what users expect from developers and future of money, review process etc. and what is the ground reality.

Happy New Year

-- 
Prayank

A3B1 E430 2298 178F

------=_Part_476048_1592426282.1641070991314
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<html>
  <head>
    <meta http-equiv=3D"content-type" content=3D"text/html; charset=3DUTF-8=
">
  </head>
  <body>
<div>Hello World,<br></div><div dir=3D"auto"><br></div><div dir=3D"auto">Wh=
at?<br></div><div dir=3D"auto"><br></div><div dir=3D"auto">Remove all *noti=
fy options from Bitcoin Core (full node implementation used by 99% nodes)<b=
r></div><div dir=3D"auto"><br></div><div dir=3D"auto">Or one of the below:<=
br></div><div dir=3D"auto"><br></div><div dir=3D"auto">notifications.dat<br=
></div><div dir=3D"auto">not use system() in runCommand()<br></div><div dir=
=3D"auto">Use a new setting in settings.json file, notifypolicy which is 0 =
by default (restricted) and can be set to 1 (unrestricted)<br></div><div di=
r=3D"auto"><br></div><div dir=3D"auto">Why?<br></div><div dir=3D"auto"><br>=
</div><div dir=3D"auto">They can help attackers in doing almost anything on=
 machines running Bitcoin Core with some social engineering.<br></div><div =
dir=3D"auto"><br></div><div dir=3D"auto">How?<br></div><div dir=3D"auto"><b=
r></div><div dir=3D"auto">Everything is explained several times in differen=
t issues, PRs etc. to different people including few reviewers who even NAC=
Ked a PR that would help in adding such options but with some documentation=
. I won't comment much about the reviewers but some of them were clueless a=
bout issue and how things work.<br></div><div dir=3D"auto"><br></div><div d=
ir=3D"auto">Example: Calling something misleading and ludicrous when you do=
n't even know what works in Windows shortcut and could not share one exampl=
e of financial application https://github.com/bitcoin/bitcoin/issues/23412#=
issuecomment-1003496126<br></div><div dir=3D"auto"><br></div><div dir=3D"au=
to">TL;DR<br></div><div dir=3D"auto"><br></div><div dir=3D"auto">https://gi=
thub.com/bitcoin/bitcoin/pull/23395#issuecomment-956353035<br></div><div di=
r=3D"auto"><br></div><div dir=3D"auto">https://github.com/bitcoin/bitcoin/i=
ssues/23412#issuecomment-970480769<br></div><div dir=3D"auto"><br></div><di=
v dir=3D"auto">To be honest, neither I have energy left to highlight the im=
portance of these issues nor most of the people look interested in this spa=
ce to address it. This email is a part of my efforts to share things with e=
veryone which I even tried with documentation. There is something seriously=
 wrong if few people including maintainers acknowledge the issues with *not=
ify options but nobody wants to fix it or document it, I will leave it for =
people to form their own opinions about it.<br></div><div dir=3D"auto"><br>=
</div><div dir=3D"auto">Last but not least I was even asked to not review a=
nd comment in https://github.com/bitcoin/bitcoin/pull/23395 when I was just=
 responding to others. <br></div><div dir=3D"auto"><br></div><div dir=3D"au=
to">This will be helpful in my security project which was already shared in=
 mailing list to highlight what users expect from developers and future of =
money, review process etc. and what is the ground reality.<br></div><div di=
r=3D"auto"><br></div><div dir=3D"auto">Happy New Year<br></div><div><br></d=
iv><div>-- <br></div><div>Prayank<br></div><div><br></div><div dir=3D"auto"=
>A3B1 E430 2298 178F<br></div>  </body>
</html>

------=_Part_476048_1592426282.1641070991314--