From: "Luke-Jr" <luke@dashjr.org>
To: Gavin Andresen <gavinandresen@gmail.com>
Date: Fri, 12 Aug 2011 12:43:22 -0400
User-Agent: KMail/1.13.7 (Linux/2.6.39-gentoo; KDE/4.6.4; x86_64; ; )
References: <201108121219.53004.luke@dashjr.org>
	<CABsx9T0iCYr591RVXA40mHMU75sEL0AfbbBHXFaz0XLFp6_kFQ@mail.gmail.com>
In-Reply-To: <CABsx9T0iCYr591RVXA40mHMU75sEL0AfbbBHXFaz0XLFp6_kFQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201108121243.24207.luke@dashjr.org>
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] [PULL] When parsing base58 data,
	accept [0O] as o, and [l|!] as 1
Precedence: list

On Friday, August 12, 2011 12:35:27 PM Gavin Andresen wrote:
> pszDecode58 is not a pointer to a zero-terminated string; it should be
> pnDecode58.

Updated variable name in branch...

> I'm torn between "meh, whatever" and "this will just cause people
> headaches when they wonder why vanity addresses don't work in
> blockexplorer because theymos decides not to bother changing his
> code..."

Perhaps the vanity use would need to be introduced only after the community 
has accepted these as alternative legitimate representations. Even without 
that, I think gracefully handling the typos would be sensible.