Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E7349192D for ; Wed, 30 Sep 2015 04:05:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from ozlabs.org (ozlabs.org [103.22.144.67]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 773C71D2 for ; Wed, 30 Sep 2015 04:05:53 +0000 (UTC) Received: by ozlabs.org (Postfix, from userid 1011) id 1290C140D17; Wed, 30 Sep 2015 14:05:51 +1000 (AEST) From: Rusty Russell To: "Wladimir J. van der Laan" , Peter Todd In-Reply-To: <20150929200302.GA5051@amethyst.visucore.com> References: <20150927185031.GA20599@savin.petertodd.org> <20150929200302.GA5051@amethyst.visucore.com> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 30 Sep 2015 13:35:42 +0930 Message-ID: <87wpv8ft61.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: bitcoin-dev@lists.linuxfoundation.org Subject: Re: [bitcoin-dev] Let's deploy BIP65 CHECKLOCKTIMEVERIFY! X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Bitcoin Development Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2015 04:05:54 -0000 "Wladimir J. van der Laan via bitcoin-dev" writes: > On Sun, Sep 27, 2015 at 02:50:31PM -0400, Peter Todd via bitcoin-dev wrote: > >> It's time to deploy BIP65 CHECKLOCKTIMEVERIFY. > > There appears to be common agreement on that. > > The only source of some controversy is how to deploy: versionbits versus > IsSuperMajority. I think the versionbits proposal should first have code > out there for longer before we consider it for concrete softforks. Haste-ing > along versionbits because CLTV is wanted would be risky. Agreed. Unfortunately, a simple "block version >= 4" check is insufficient, due to XT which sets version bits 001....111. Given that, I suggest using the simple test: if (pstart->nVersion & 0x8) ++nFound; Which means: 1) XT won't trigger it. 2) It won't trigger XT. 3) You can simply set block nVersion to 8 for now. 4) We can still use versionbits in parallel later. Cheers, Rusty.