Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WrrsW-00016f-3X for bitcoin-development@lists.sourceforge.net; Tue, 03 Jun 2014 16:48:00 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of peernova.com designates 209.85.128.182 as permitted sender) client-ip=209.85.128.182; envelope-from=toshi@peernova.com; helo=mail-ve0-f182.google.com; Received: from mail-ve0-f182.google.com ([209.85.128.182]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1WrrsU-0004An-Vo for bitcoin-development@lists.sourceforge.net; Tue, 03 Jun 2014 16:48:00 +0000 Received: by mail-ve0-f182.google.com with SMTP id sa20so7245458veb.41 for ; Tue, 03 Jun 2014 09:47:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=VcpLWYwUIy6AiwpXLj4D+V1+GIueLP+MJlKgGr5OMAo=; b=hOmHOLtMeFS1hfXwsj+nR0M0+PO2QclUj1tXpAZwdHZ6hVCjt3gNqq1dmYR3FXUVHS YGrkW9MaP+qc/t3QGS0Vx1SdZXWCjgmy+ErhNgSK956gl5XcIx1xfBn6hSZ3D7mBRIee HZ28IyXGC+HSNXeN9kjLoAKT1m3jjaTMnwCSVTRsRLQv1K2fWx2/NDeS1qM0GGOlOa7d QAXTWvLuvhkkl3LtH+UFwjjdlTH8seox/xvP7H7wQ79H9PlPkGCl41NCUUjaCenxlo86 id9Ws4cZkDlMlk7mCTszFtUmxA4jjXsObTrd4dWf2wFNqPel8vtxIH3NrOSwo2gpbTAn ZHoA== X-Gm-Message-State: ALoCoQn3SoYPGOFGpLPXjRQLnwBOAm+8pxCy/9hUl21FQet+I731hGo7SeUmh3SO8nFk2ghToRTD MIME-Version: 1.0 X-Received: by 10.58.29.16 with SMTP id f16mr38480666veh.23.1401814073191; Tue, 03 Jun 2014 09:47:53 -0700 (PDT) Received: by 10.52.97.37 with HTTP; Tue, 3 Jun 2014 09:47:53 -0700 (PDT) In-Reply-To: References: Date: Tue, 3 Jun 2014 09:47:53 -0700 Message-ID: From: Toshi Morita To: Jeff Garzik Content-Type: multipart/alternative; boundary=047d7b6dd084dfb89104faf14509 X-Spam-Score: -0.5 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record 1.0 HTML_MESSAGE BODY: HTML included in message X-Headers-End: 1WrrsU-0004An-Vo Cc: bitcoin-development Subject: Re: [Bitcoin-development] Another uninitialized memory problem X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2014 16:48:00 -0000 --047d7b6dd084dfb89104faf14509 Content-Type: text/plain; charset=UTF-8 I looked at this a bit more yesterday, and it looks like both sides of the comparison were uninitialized, and I fixed one side, but the other side has the same problem. I'll try to investigate further this afternoon once I get out of meetings/meetings prep. Toshi On Tue, Jun 3, 2014 at 9:43 AM, Jeff Garzik wrote: > I think I see the problem. > > > On Mon, Jun 2, 2014 at 4:01 PM, Toshi Morita wrote: > > I'm seeing another uninitialized memory problem in bitcoind using > valgrind: > > > > tm@tm-VirtualBox:~/bitcoind/bitcoin/src$ valgrind ./bitcoind > > ==2337== Memcheck, a memory error detector > > ==2337== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al. > > ==2337== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright > info > > ==2337== Command: ./bitcoind > > ==2337== > > ==2337== Conditional jump or move depends on uninitialised value(s) > > ==2337== at 0x319176: CWallet::LoadKeyMetadata(CPubKey const&, > > CKeyMetadata const&) (wallet.cpp:110) > > ==2337== by 0x33645A: ReadKeyValue(CWallet*, CDataStream&, > CDataStream&, > > CWalletScanState&, std::string&, std::string&) (walletdb.cpp:509) > > ==2337== by 0x3374F0: CWalletDB::LoadWallet(CWallet*) > (walletdb.cpp:623) > > ==2337== by 0x3218FD: CWallet::LoadWallet(bool&) (wallet.cpp:1485) > > ==2337== by 0x157F16: AppInit2(boost::thread_group&) (init.cpp:958) > > ==2337== by 0x140142: AppInit(int, char**) (bitcoind.cpp:143) > > ==2337== by 0x13649E: main (bitcoind.cpp:180) > > ==2337== > > > > > > > ------------------------------------------------------------------------------ > > Learn Graph Databases - Download FREE O'Reilly Book > > "Graph Databases" is the definitive new guide to graph databases and > their > > applications. Written by three acclaimed leaders in the field, > > this first edition is now available. Download your free book today! > > http://p.sf.net/sfu/NeoTech > > _______________________________________________ > > Bitcoin-development mailing list > > Bitcoin-development@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/bitcoin-development > > > > > > -- > Jeff Garzik > Bitcoin core developer and open source evangelist > BitPay, Inc. https://bitpay.com/ > --047d7b6dd084dfb89104faf14509 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I looked at this a bit more yesterday, and it looks like b= oth sides of the comparison were uninitialized, and I fixed one side, but t= he other side has the same problem.

I'll try to inve= stigate further this afternoon once I get out of meetings/meetings prep.

Toshi



On Tue, Jun 3, 2014 at 9:43 AM, Jeff= Garzik <jgarzik@bitpay.com> wrote:
I think I see the problem.


On Mon, Jun 2, 2014 at 4:01 PM, Toshi Morita <toshi@peernova.com> wrote:
> I'm seeing another uninitialized memory problem in bitcoind using = valgrind:
>
> tm@tm-VirtualBox:~/bitcoind/bitcoin/src$ valgrind ./bitcoind
> =3D=3D2337=3D=3D Memcheck, a memory error detector
> =3D=3D2337=3D=3D Copyright (C) 2002-2012, and GNU GPL'd, by Julian= Seward et al.
> =3D=3D2337=3D=3D Using Valgrind-3.8.1 and LibVEX; rerun with -h for co= pyright info
> =3D=3D2337=3D=3D Command: ./bitcoind
> =3D=3D2337=3D=3D
> =3D=3D2337=3D=3D Conditional jump or move depends on uninitialised val= ue(s)
> =3D=3D2337=3D=3D =C2=A0 =C2=A0at 0x319176: CWallet::LoadKeyMetadata(CP= ubKey const&,
> CKeyMetadata const&) (wallet.cpp:110)
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x33645A: ReadKeyValue(CWallet*, CDat= aStream&, CDataStream&,
> CWalletScanState&, std::string&, std::string&) (walletdb.c= pp:509)
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x3374F0: CWalletDB::LoadWallet(CWall= et*) (walletdb.cpp:623)
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x3218FD: CWallet::LoadWallet(bool&am= p;) (wallet.cpp:1485)
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x157F16: AppInit2(boost::thread_grou= p&) (init.cpp:958)
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x140142: AppInit(int, char**) (bitco= ind.cpp:143)
> =3D=3D2337=3D=3D =C2=A0 =C2=A0by 0x13649E: main (bitcoind.cpp:180)
> =3D=3D2337=3D=3D
>
>
> ----------------------------------------------------------= --------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph datab= ases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today! > http://p.sf.= net/sfu/NeoTech
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-d= evelopment@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitco= in-development
>



--
Jeff Garzik
Bitcoin core developer and open source evangelist
BitPay, Inc. =C2=A0 =C2=A0 =C2=A0https://bitpay.com/

--047d7b6dd084dfb89104faf14509--