Return-Path: Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 026FCC002D for ; Wed, 5 Oct 2022 06:55:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BE0A5401D2 for ; Wed, 5 Oct 2022 06:55:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org BE0A5401D2 X-Virus-Scanned: amavisd-new at osuosl.org X-Spam-Flag: NO X-Spam-Score: -1.901 X-Spam-Level: X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7gRmBJ5rcdMr for ; Wed, 5 Oct 2022 06:55:50 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 74FC4404A8 Received: from azure.erisian.com.au (azure.erisian.com.au [172.104.61.193]) by smtp2.osuosl.org (Postfix) with ESMTPS id 74FC4404A8 for ; Wed, 5 Oct 2022 06:55:50 +0000 (UTC) Received: from aj@azure.erisian.com.au (helo=sapphire.erisian.com.au) by azure.erisian.com.au with esmtpsa (Exim 4.92 #3 (Debian)) id 1ofyJl-0005AN-Dp; Wed, 05 Oct 2022 16:55:47 +1000 Received: by sapphire.erisian.com.au (sSMTP sendmail emulation); Wed, 05 Oct 2022 16:55:39 +1000 Date: Wed, 5 Oct 2022 16:55:39 +1000 From: Anthony Towns To: eric@voskuil.org, Bitcoin Protocol Discussion Message-ID: References: <005e01d87b89$3d99df60$b8cd9e20$@voskuil.org> <02fc01d8d84d$90a7b120$b1f71360$@voskuil.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02fc01d8d84d$90a7b120$b1f71360$@voskuil.org> X-Spam-Score-int: -18 X-Spam-Bar: - Subject: Re: [bitcoin-dev] Packaged Transaction Relay X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2022 06:55:52 -0000 On Tue, Oct 04, 2022 at 05:01:04PM -0700, Eric Voskuil via bitcoin-dev wrote: > [Regarding bandwidth waste: I've pointed out in years past that > breaking the Bitcoin versioning scheme creates a requirement that any > unknown message type be considered valid. Up until a recently-deployed > protocol change, it had always been possible to validate messages by > type. I noticed recently that validating nodes have been dropping peers > at an increasing rate (a consequence of that deployment). Despite being > an undocumented compatibility break, it is now unfortunately a matter > of protocol that a peer must allow its peers to waste its bandwidth to > remain compatible - something which we should eliminate.] The only message listed as not being preceded by a bumped version number in: https://github.com/libbitcoin/libbitcoin-network/wiki/Protocol-Versioning is addrv2 (though addrv2 is gated on mutual exchange of sendaddrv2, so it's presumably the sendaddrv2 message at issue), however since [0] sendaddrv2 messages are only sent to nodes advertising version 70016 or later (same as wtxidrelay). ADDRV2 was introduced May 20 2020 after the 0.20 branch, and SENDADDRV2 gating was merged Dec 9 2020 and included from 0.21.0rc3 onwards. [0] https://github.com/bitcoin/bitcoin/pull/20564 I'm only seeing "bytesrecv_per_msg.*other*" entries for nodes advertising a version of 0.17 and 0.18, which I presume is due to REJECT messages (for taproot txs, perhaps?). Otherwise, I don't think there are any unexpected messages you should be receiving when advertising version 70015 or lower. Cheers, aj