Delivery-date: Mon, 06 May 2024 03:57:34 -0700
Sender: bitcoindev@googlegroups.com
Date: Sun, 5 May 2024 08:03:39 -0700 (PDT)
From: Fractal Encrypt <fractalencryptlsd@gmail.com>
To: Bitcoin Development Mailing List <bitcoindev@googlegroups.com>
Message-Id: <74ae96f5-4ea4-4afa-8321-e09e4ad9f97an@googlegroups.com>
In-Reply-To: <91d3be30-a672-4407-8d11-902df8ff4f54n@googlegroups.com>
References: <75628135-32ae-4df3-be52-9f7d054bc096n@googlegroups.com>
 <91d3be30-a672-4407-8d11-902df8ff4f54n@googlegroups.com>
Subject: [bitcoindev] Re: A Fool's Errand or should I try?
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_155346_1235427822.1714921419252"
Precedence: list
Mailing-list: list bitcoindev@googlegroups.com; contact bitcoindev+owners@googlegroups.com

------=_Part_155346_1235427822.1714921419252
Content-Type: multipart/alternative; 
	boundary="----=_Part_155347_1421974194.1714921419252"

------=_Part_155347_1421974194.1714921419252
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks Ali, I will investigate these avenues you've pointed out. Most=20
appreciated!=20

On Sunday, May 5, 2024 at 9:30:48=E2=80=AFAM UTC-4 Ali Sherief wrote:

> Currently the only way you can fetch the previous input addresses and=20
> amounts is if you use the getblock RPC call with a verbosity of 3. This=
=20
> will obviously cause it to print a lot of raw transactions. But since=20
> decoderawtrasnsaction is independent of the blocks that are actually stor=
ed=20
> on your disk, you'd have to modify it to locate each input inside the=20
> blocks.dat folder, and then assemble an equivalent "prevout" structure as=
=20
> in getblock.
>
> There is also the issue of the txo not actually existing in the=20
> blockchain, which means that such a prevout structure would not exist in=
=20
> the first place.
>
> I think it would be better to create a separate RPC for this, maybe=20
> 'getfulltransaction' or something like that since gettransaction for=20
> in-walet txs already exists, to implement such functionality.
>
> -Ali
>
> On Saturday, May 4, 2024 at 3:40:24=E2=80=AFPM UTC Fractal Encrypt wrote:
>
>> TLDR: I'd like to investigate the possibilities of extending=20
>> decoderawtransaction to include the fee (and maybe even sats per v/b).
>>
>> I'm hoping it will be a good project for me to work on and build at leas=
t=20
>> a tiny understanding of bitcoin development.
>>
>> ------------------------------------------------------------------------
>>
>> I use the createrawtransaction function to create transactions, and=20
>> before broadcasting, I always like to use decoderawtransaction to see if=
 I=20
>> made any mistakes.
>>
>> I've sometimes messed up on the fee calculation, as I do that myself wit=
h=20
>> a calculator.
>>
>> Unfortunately decoderawtransaction doesn't give me the fee information=
=20
>> (for a very good reason, it is not aware of the value of the inputs in t=
he=20
>> tx).
>>
>> So to double check the fees, instead of using createrawtransaction, I'll=
=20
>> use createpsbt and then go through the process of finalizing it so I can=
=20
>> run decodepsbt, which does give the fee along with all the other relevan=
t=20
>> data.
>>
>> But the createpsbt process is more work for a simple transaction where=
=20
>> all UTXOs are in the wallet I am creating the rawtx in.
>>
>> My goal would be to modify decoderawtransaction to perform these=20
>> additional steps:
>>   =20
>>    1. Fetch UTXO details for each input.
>>    2. Calculate the total input value.
>>    3. Subtract the total output value to determine the fee.
>>
>> Additionally there are the considerations about whether the inputs in th=
e=20
>> transaction are in your wallet or not.=20
>>
>> If I run listunspent it gives me the info I need to create the raw tx or=
=20
>> psbt, and it has the values of the UTXOs that will be used as inputs in =
my=20
>> tx.
>>
>> But I understand decoderawtransaction is meant to be used whether or not=
=20
>> the keys are in your wallet (so I was thinking to make a command argumen=
t=20
>> T/F to show the fee value only if keys are in your wallet).
>>
>> Alternatively if you are running the command in a node with txindex, the=
n=20
>> you have the full chainstate to look up txids (whether unspent or not) -=
 so=20
>> this needs to be addressed too.
>>
>> Doing this within my own node would be cool enough and I don't=20
>> necessarily need it to go farther than that. However if I do get it=20
>> working, I'd certainly try to submit a PR.
>>
>> I have no idea if any of this is possible, so I wanted to ask here for=
=20
>> some guidance and maybe mentorship in this self-interest driven project.=
=20
>> Also looking for this to be shot down mercilessly if it's just ridiculou=
s.
>>
>> My abilities and skills are very low. My interest and persistence are=20
>> high.
>>
>> Any help or ridicule invited ;)
>>
>

--=20
You received this message because you are subscribed to the Google Groups "=
Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to bitcoindev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/=
bitcoindev/74ae96f5-4ea4-4afa-8321-e09e4ad9f97an%40googlegroups.com.

------=_Part_155347_1421974194.1714921419252
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks Ali, I will investigate these avenues you've pointed out. Most appre=
ciated! <br /><br /><div class=3D"gmail_quote"><div dir=3D"auto" class=3D"g=
mail_attr">On Sunday, May 5, 2024 at 9:30:48=E2=80=AFAM UTC-4 Ali Sherief w=
rote:<br/></div><blockquote class=3D"gmail_quote" style=3D"margin: 0 0 0 0.=
8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Current=
ly the only way you can fetch the previous input addresses and amounts is i=
f you use the getblock RPC call with a verbosity of 3. This will obviously =
cause it to print a lot of raw transactions. But since decoderawtrasnsactio=
n is independent of the blocks that are actually stored on your disk, you&#=
39;d have to modify it to locate each input inside the blocks.dat folder, a=
nd then assemble an equivalent &quot;prevout&quot; structure as in getblock=
.<div><br></div><div>There is also the issue of the txo not actually existi=
ng in the blockchain, which means that such a prevout structure would not e=
xist in the first place.</div><div><br></div><div>I think it would be bette=
r to create a separate RPC for this, maybe &#39;getfulltransaction&#39; or =
something like that since gettransaction for in-walet txs already exists, t=
o implement such functionality.</div><div><br></div><div>-Ali<br><div><div>=
<br></div></div></div><div class=3D"gmail_quote"><div dir=3D"auto" class=3D=
"gmail_attr">On Saturday, May 4, 2024 at 3:40:24=E2=80=AFPM UTC Fractal Enc=
rypt wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 =
0 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>TLDR:=
 I&#39;d like to investigate the possibilities of extending decoderawtransa=
ction to include the fee (and maybe even sats per v/b).</div><div><br></div=
><div>I&#39;m hoping it will be a good project for me to work on and build =
at least a tiny understanding of bitcoin development.</div><div><br></div><=
div>-----------------------------------------------------------------------=
-<br></div><div><br></div><div>I use the createrawtransaction function to c=
reate transactions, and before broadcasting, I always like to use decoderaw=
transaction to see if I made any mistakes.</div><div><br></div><div>I&#39;v=
e sometimes messed up on the fee calculation, as I do that myself with a ca=
lculator.</div><div><br></div><div>Unfortunately decoderawtransaction doesn=
&#39;t give me the fee information (for a very good reason, it is not aware=
 of the value of the inputs in the tx).</div><div><br></div><div>So to doub=
le check the fees, instead of using createrawtransaction, I&#39;ll use crea=
tepsbt and then go through the process of finalizing it so I can run decode=
psbt, which does give the fee along with all the other relevant data.<br></=
div><div><br></div><div>But the createpsbt process is more work for a simpl=
e transaction where all UTXOs are in the wallet I am creating the rawtx in.=
</div><div><br></div><div>My goal would be to modify <span>decoderawtransac=
tion</span> to perform these additional steps:<ol><li>Fetch UTXO details fo=
r each input.</li><li>Calculate the total input value.</li><li>Subtract the=
 total output value to determine the fee.</li></ol><div>Additionally there =
are the considerations about whether the inputs in the transaction are in y=
our wallet or not. <br></div><div><br></div><div>If I run listunspent it gi=
ves me the info I need to create the raw tx or psbt, and it has the values =
of the UTXOs that will be used as inputs in my tx.<br><br>But I understand =
decoderawtransaction is meant to be used whether or not the keys are in you=
r wallet (so I was thinking to make a command argument T/F to show the fee =
value only if keys are in your wallet).<br><br>Alternatively if you are run=
ning the command in a node with txindex, then you have the full chainstate =
to look up txids (whether unspent or not) - so this needs to be addressed t=
oo.</div><div><br></div><div>Doing this within my own node would be cool en=
ough and I don&#39;t necessarily need it to go farther than that. However i=
f I do get it working, I&#39;d certainly try to submit a PR.<br></div><div>=
<br>I have no idea if any of this is possible, so I wanted to ask here for =
some guidance and maybe mentorship in this self-interest driven project. Al=
so looking for this to be shot down mercilessly if it&#39;s just ridiculous=
.</div><div><br></div><div>My abilities and skills are very low. My interes=
t and persistence are high.</div><div><br></div><div>Any help or ridicule i=
nvited ;)<br></div>

</div></blockquote></div></blockquote></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;Bitcoin Development Mailing List&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:bitcoindev+unsubscribe@googlegroups.com">bitcoind=
ev+unsubscribe@googlegroups.com</a>.<br />
To view this discussion on the web visit <a href=3D"https://groups.google.c=
om/d/msgid/bitcoindev/74ae96f5-4ea4-4afa-8321-e09e4ad9f97an%40googlegroups.=
com?utm_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/d/msg=
id/bitcoindev/74ae96f5-4ea4-4afa-8321-e09e4ad9f97an%40googlegroups.com</a>.=
<br />

------=_Part_155347_1421974194.1714921419252--

------=_Part_155346_1235427822.1714921419252--