Delivery-date: Tue, 02 Jul 2024 18:30:59 -0700
Sender: bitcoindev@googlegroups.com
Date: Tue, 2 Jul 2024 18:07:07 -0700 (PDT)
From: Larry Ruane <larryruane@gmail.com>
To: Bitcoin Development Mailing List <bitcoindev@googlegroups.com>
Message-Id: <e2c61ee5-68c4-461e-a132-bb86a4c3e2ccn@googlegroups.com>
In-Reply-To: <301c64c7-0f0f-476a-90c4-913659477276n@googlegroups.com>
References: <gnM89sIQ7MhDgI62JciQEGy63DassEv7YZAMhj0IEuIo0EdnafykF6RH4OqjTTHIHsIoZvC2MnTUzJI7EfET4o-UQoD-XAQRDcct994VarE=@protonmail.com>
 <72e83c31-408f-4c13-bff5-bf0789302e23n@googlegroups.com>
 <heKH68GFJr4Zuf6lBozPJrb-StyBJPMNvmZL0xvKFBnBGVA3fVSgTLdWc-_8igYWX8z3zCGvzflH-CsRv0QCJQcfwizNyYXlBJa_Kteb2zg=@protonmail.com>
 <5b0331a5-4e94-465d-a51d-02166e2c1937n@googlegroups.com>
 <yt1O1F7NiVj-WkmnYeta1fSqCYNFx8h6OiJaTBmwhmJ2MWAZkmmjPlUST6FM7t6_-2NwWKdglWh77vcnEKA8swiAnQCZJY2SSCAh4DOKt2I=@protonmail.com>
 <be78e733-6e9f-4f4e-8dc2-67b79ddbf677n@googlegroups.com>
 <jJLDrYTXvTgoslhl1n7Fk9-pL1mMC-0k6gtoniQINmioJpzgtqrJ_WqyFZkLltsCUusnQ4jZ6HbvRC-mGuaUlDi3kcqcFHALd10-JQl-FMY=@protonmail.com>
 <9a4c4151-36ed-425a-a535-aa2837919a04n@googlegroups.com>
 <3f0064f9-54bd-46a7-9d9a-c54b99aca7b2n@googlegroups.com>
 <26b7321b-cc64-44b9-bc95-a4d8feb701e5n@googlegroups.com>
 <CALZpt+EwVyaz1=A6hOOycqFGJs+zxyYYocZixTJgVmzZezUs9Q@mail.gmail.com>
 <607a2233-ac12-4a80-ae4a-08341b3549b3n@googlegroups.com>
 <3dceca4d-03a8-44f3-be64-396702247fadn@googlegroups.com>
 <301c64c7-0f0f-476a-90c4-913659477276n@googlegroups.com>
Subject: Re: [bitcoindev] Re: Great Consensus Cleanup Revival
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_27134_840701207.1719968827654"
Precedence: list
Mailing-list: list bitcoindev@googlegroups.com; contact bitcoindev+owners@googlegroups.com

------=_Part_27134_840701207.1719968827654
Content-Type: multipart/alternative; 
	boundary="----=_Part_27135_537405036.1719968827654"

------=_Part_27135_537405036.1719968827654
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Monday, July 1, 2024 at 11:03:33=E2=80=AFPM UTC-6 Antoine Riard wrote:


Here a snippet example of linked list code checking the pointer=20
(`*begin_list`) is non null before the comparison operation to find the=20
target element list.

```
pointer_t       ft_list_find(pointer_t **start_list, void *data_ref, int=20
(*cmp)())
{
        while (*start_list)
        {
                if (cmp((*start_list)->data, data_ref) =3D=3D 0)
                        return (*start_list);
                *start_list =3D (*start_list)->next;
        }
        return (0);
}
```


I assume this function lets you search for an element starting in the=20
middle of a single-linked list (the middle because you could call=20
`ft_list_find(&p-next, data_ref)` where `p` points to any element in the=20
middle of the list, including possibly the last item in the list, in which=
=20
case the loop body wouldn't run). If so, I don't think this does what's=20
intended. This actually unlinks (and memory-leaks) elements up to where the=
=20
match is found. I think you want to advance `start_list` this way (I didn't=
=20
test this):

```
    start_list =3D &(*start_list)->next;
```

Larry

--=20
You received this message because you are subscribed to the Google Groups "=
Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to bitcoindev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/=
bitcoindev/e2c61ee5-68c4-461e-a132-bb86a4c3e2ccn%40googlegroups.com.

------=_Part_27135_537405036.1719968827654
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><div dir=3D"auto">On Monday, July 1, 2024 at 11:03:33=E2=80=AFPM UTC-6=
 Antoine Riard wrote:<br /></div><blockquote style=3D"margin: 0px 0px 0px 0=
.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><=
br />Here a snippet example of linked list code checking the pointer (`*beg=
in_list`) is non null before the comparison operation to find the target el=
ement list.<br /><br />```<br />pointer_t =C2=A0 =C2=A0 =C2=A0 ft_list_find=
(pointer_t **start_list, void *data_ref, int (*cmp)())<br />{<br />=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 while (*start_list)<br />=C2=A0 =C2=A0 =C2=A0 =C2=A0 {=
<br />=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (cmp((*sta=
rt_list)-&gt;data, data_ref) =3D=3D 0)<br />=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return (*start_list);<=
br />=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *start_list =
=3D (*start_list)-&gt;next;<br />=C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br />=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 return (0);<br />}</div><div>```</div></blockquote><di=
v><br /></div><div>I assume this function lets you search for an element st=
arting in the middle of a single-linked list (the middle because you could =
call `ft_list_find(&amp;p-next, data_ref)` where `p` points to any element =
in the middle of the list, including possibly the last item in the list, in=
 which case the loop body wouldn't run). If so, I don't think this does wha=
t's intended. This actually unlinks (and memory-leaks) elements up to where=
 the match is found. I think you want to advance `start_list` this way (I d=
idn't test this):</div><div><br /></div><div>```</div><div>=C2=A0 =C2=A0 st=
art_list =3D &amp;(*start_list)-&gt;next;</div>```</div><div><br /></div><d=
iv>Larry</div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;Bitcoin Development Mailing List&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:bitcoindev+unsubscribe@googlegroups.com">bitcoind=
ev+unsubscribe@googlegroups.com</a>.<br />
To view this discussion on the web visit <a href=3D"https://groups.google.c=
om/d/msgid/bitcoindev/e2c61ee5-68c4-461e-a132-bb86a4c3e2ccn%40googlegroups.=
com?utm_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/d/msg=
id/bitcoindev/e2c61ee5-68c4-461e-a132-bb86a4c3e2ccn%40googlegroups.com</a>.=
<br />

------=_Part_27135_537405036.1719968827654--

------=_Part_27134_840701207.1719968827654--