I think that should be greater than in the comparison= ?=C2=A0 You want it to fail if the the height of the UTXO plus the sequence= number is greater than the spending block's height.

= There should be an exception for final inputs.=C2=A0 Otherwise, they will c= ount as relative locktime of 0xFFFFFFFF.=C2=A0 Is this check handled elsewh= ere?

if (!tx.vin[i].IsFinal() && nSpendHeight < coins-&g= t;nHeight + tx.vin[i].nSequence)
=C2=A0 =C2=A0 =C2=A0=C2=A0 return state.Invalid(false, REJECT_INVALID, &quo= t;bad-txns-non-final-input");

Is the intention to let the= script check the sequence number?

= <number> OP_RELATIVELOCKTIMEVERIFY

would check if <number> is less than or equal to the sequence n= umber.

It does make sequence mean something completely different from before.= =C2=A0 Invalidating previously valid transactions has the potential to redu= ce confidence in the currency.

A wo= rkaround would be to have a way to enable it in the sigScript by extending = Peter Todd's suggestion in the other email chain.

<1> OP_NOP2 means OP_CHECKLOCKTIMEVERIFY (absolute= )

<2> OP_NOP2 means OP_RELATIVECH= ECKLOCKTIMEVERIFY

<3> OP_NOP= 2 means OP_SEQUENCE_AS_RELATIVE_HEIGHT

=
OP_SEQUENCE_AS_RELATIVE_HEIGHT would cause the script to fail unless it= was the first opcode in the script.=C2=A0 It acts as a flag to enable usin= g the sequence number as for relative block height.

This can be achieved using a simple pattern match.

= bool CScript::IsSequenceAsRelativeHeight() const
{
=C2=A0=C2=A0=C2=A0= // Extra-fast test for pay-to-script-hash CScripts:
=C2=A0=C2=A0=C2=A0 = return (this->size() >=3D 4 &&
=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 this->at(0) =3D=3D OP_PUSHDATA1 &&

=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 this->at(1) =3D=3D 1 &&<= br>

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 this->at(2) =3D=3D 0xFF &&

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 this->at(3) =3D=3D OP_NOP2);
}

if (!tx.vin[i].IsFina= l() && tx.vin[i].scriptSig.IsSequenceAsRelativeHeight() && = nSpendHeight < coins->nHeight + tx.vin[i].nSequence)
=C2=A0 =C2=A0 =C2=A0=C2=A0 return state.Invalid(false, REJECT_INVALID, &quo= t;bad-txns-non-final-input");

On Mon, May 4, 2015= at 12:24 PM, Jorge Tim=C3=B3n <jtimon@jtimon.cc> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">for (unsi= gned int i =3D 0; i < tx.vin.size(); i++) {
// ...
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (coins->nHeight + tx= .vin[i].nSequence < nSpendHeight)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return state.Invali= d(false, REJECT_INVALID, "bad-txns-non-final-input");
// ...
}

=C2=A0

--001a11c12ce42b173b05155baaa8--