Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of taplink.co
	designates 50.117.27.232 as permitted sender)
	client-ip=50.117.27.232; envelope-from=jeremy@taplink.co;
	helo=mail.taplink.co; 
Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes
To: "bitcoin-development@lists.sourceforge.net"
	<bitcoin-development@lists.sourceforge.net>
References: <op.xb05iptvyldrnw@laptop-air>
Date: Sat, 01 Mar 2014 23:52:40 -0800
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "Jeremy Spilman" <jeremy@taplink.co>
Organization: TapLink
Message-ID: <op.xb2352ezyldrnw@laptop-air>
In-Reply-To: <op.xb05iptvyldrnw@laptop-air>
User-Agent: Opera Mail/1.0 (Win32)
Subject: [Bitcoin-development] Payment Protocol Hash Comments
Precedence: list

 From BIP70:

   If pki_type is "x509+sha256", then the Payment message is hashed using  
the
   SHA256 algorithm to produce the message digest that is signed. If  
pki_type
   is "x509+sha1", then the SHA1 algorithm is used.

A couple minor comments;

  - I think it meant to say the field to be hashed is 'PaymentRequest' not  
'Payment' message -- probably got renamed at some point and this is an old  
reference calling it by its original name.

  - Could be a bit more explicit about the hashing, e.g. 'copy the  
PaymentRequest, set the signature field to the empty string, serialize to  
a byte[] and hash.

  - SHA1 is retiring, any particular reason to even have it in there at all?

  - Should there any way for the end-user to see details like the pki_type  
and the certificate chain, like browser do?


Thanks,
Jeremy