Delivery-date: Thu, 28 Mar 2024 12:29:35 -0700
Sender: bitcoindev@googlegroups.com
Received-SPF: pass (google.com: domain of pete@petertodd.org designates 64.147.123.147 as permitted sender) client-ip=64.147.123.147;
Feedback-ID: i525146e8:Fastmail
Date: Thu, 28 Mar 2024 19:16:22 +0000
From: Peter Todd <pete@petertodd.org>
To: Antoine Riard <antoine.riard@gmail.com>
Cc: Steve Lee <steven.j.lee@gmail.com>, "David A. Harding" <dave@dtrt.org>,
	bitcoindev@googlegroups.com
Subject: Re: [bitcoindev] A Free-Relay Attack Exploiting RBF Rule #6
Message-ID: <ZgXCBhL2E6UECXVJ@petertodd.org>
References: <f7fbeb4f58904fc5a24b6fc2d829036c@dtrt.org>
 <ZgRfvrYatcpqPNRn@petertodd.org>
 <bbc33ff01e464f8c84a593ac05c5722c@dtrt.org>
 <ZgSB6kmLiDG08Yrd@petertodd.org>
 <CABu3BAeYsMG7TuM_htTYREgDdGOKV=gwFJ+T59L=qHqbewz4vw@mail.gmail.com>
 <CALZpt+EK26=E6U9OdY+c9LVQnGtb-f5zzKt5RTwBoHpr_SSxcA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mz1UYETDl4+YGTjN"
Content-Disposition: inline
In-Reply-To: <CALZpt+EK26=E6U9OdY+c9LVQnGtb-f5zzKt5RTwBoHpr_SSxcA@mail.gmail.com>
Precedence: list
Mailing-list: list bitcoindev@googlegroups.com; contact bitcoindev+owners@googlegroups.com


--mz1UYETDl4+YGTjN
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline

On Thu, Mar 28, 2024 at 06:34:42PM +0000, Antoine Riard wrote:
> Hi Steve,
> 
> > He literally cites a reference to an example.
> 
> About CVE-2017-12842,  the report of Sergio Demian Lerner available here
> gives more information on the reporting process of the vulnerability:
> https://bitslog.com/2018/06/09/leaf-node-weakness-in-bitcoin-merkle-tree-design/
> 
> I'll attract attention on the following words of Sergio himself:
> 
> "and as I said in the first paragraph, the weakness was already known by
> some developers. But I still don't understand (1) why so many people knew
> about it but underestimated it badly, (2) why there was no attempt to fix
> it."

I do not consider CVE-2017-12842 to be serious. Indeed, I'm skeptical that we
should even fix it with a fork. SPV validation is very sketchy, and the amount
of work and money required to trigger CVE-2017-12842 is probably as or more
expensive than simply creating fake blocks.

Sergio's RSK Bridge contract being vulnerable to it just indicates it was a
reckless design.

> I believe in the present "free-relay" bandwidth wasting, letting a minimal
> 2-weeks delay would have been more reasonable. Security list members might
> be in flight travels or at conferences, or under other operational
> constraints and domain experts in the area of transaction-relay might not
> be available to give full-fledged answers. Even if you have private
> contacts of someone, don't rush them to get an answer when it can be
> midnight in their time zones and they're recovering from jet lags.

To be clear, in this particular case I had specific, insider, knowledge that
the relevant people had in fact seen my report and had already decided to
dismiss it. This isn't a typical case where you're emailing some random company
and don't have any contacts. I personally knew prior to publication that the
relevant people had been given a fair chance to comment, had chosen not to, and
I would likely receive no response at all. Which is really annoying as I have
my own deadlines for (paid) things this research was relevant to: much more
useful to me to get the issue published publicly, so I can get actual comments
from people like yourself, and move forward with my work.

I'm not going to say anything further on how I knew this, because I'm not about
to put up people who have been co-operating with me to the risk of harassment
from people like Harding and others; I'm not very popular right now with many
of the Bitcoin Core people working on the mempool code.

Anyway, I think the lesson learned here is it's probably not worth bothering
with a disclosure process at all for this type of issue. It just created a
bunch of distracting political drama when simply publishing this exploit
variation immediately probably would not have.

-- 
https://petertodd.org 'peter'[:-1]@petertodd.org

-- 
You received this message because you are subscribed to the Google Groups "Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bitcoindev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/bitcoindev/ZgXCBhL2E6UECXVJ%40petertodd.org.

--mz1UYETDl4+YGTjN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE0RcYcKRzsEwFZ3N5Lly11TVRLzcFAmYFwgQACgkQLly11TVR
Lzfm8w/+IA717utqZBAHKlbQoX2jTL/a9Aq7FiI9q0dIaXkTA8ieK/hreLgvOF2A
5PJ14jqjgfecY4HBMBrelo8tvSJWFCOx3V3ug8f4QTC3/AYUY3wBvjITJR80MX6t
mGW95ZDJxaJn7z+EdWXo6++XJ2Bm4AE3h6aM4akkDfRpEePo5wYF3uVSs1mAoH2L
sLz5UHsnVjhjx2muxQb8IxZ3o0+JM42K8sXt02crB2Bwl9T3fxFBOpq1O4rxDO2c
UTo9R9ITCIOztTe5t8fcnIypvsyleGevzPuT9MxnYLNhq8/nkqN780eRn2di33GO
DBEy4/pukldwnJ+vXojdqvtQSlo1rv7tWRXBjfcGEKvm3VAUGdPpLcbCG5pKY0bE
5oykEAXrTLpIm/urg5DehTRecmef4LLhw986IhttjYGZ72Br2Dax3ZAoId4PJZFa
e5FCYm1L3kljUfpchqcV33d77NEzJCcKKl7wO3BQ08S4Er+ny6F4QTD70FPiA0qD
Ca4EGZOSj1FcbUgI1Ku1tBA1gljABxahFNBj03vj9knCftvqCn0VpGGDvazefjJ0
UbyOzIpJwcqbU1xEAx5JY8MAa3mP1CfbqwkmTcHZTihJki9F2m1xQslmu+GO0Zaz
/Z0FWwvbA6fsEufTT8Vlep5Iz9S/3Gm2Cf8ufaAB1f/3j/a55xc=
=r9TN
-----END PGP SIGNATURE-----

--mz1UYETDl4+YGTjN--