Message-ID: <1380770163.7534.YahooMailNeo@web124502.mail.ne1.yahoo.com>
Date: Wed, 2 Oct 2013 20:16:03 -0700 (PDT)
From: Ron <rdwnj@yahoo.com>
To: "bitcoin-development@lists.sourceforge.net"
	<bitcoin-development@lists.sourceforge.net>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="-626213187-280908893-1380770163=:7534"
Subject: [Bitcoin-development] on CDB::Rewrite()
Precedence: list
Reply-To: Ron <rdwnj@yahoo.com>

---626213187-280908893-1380770163=:7534
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

I only bring this up here since I can't raise https://bitcointalk.org? Perh=
aps it runs on the silk road servers:)=0A=0AUpon looking at the 0.8.5 & ear=
lier code for CDB:Rewrite(), in the files db.h and db.cpp, you will notice =
that in db.h it is declared bool static, but in db.cpp it isn't. Is this a =
problem? Or a feature? Or nothing at all?=0A=0A=0AFurthermore, it is called=
 only in wallet.cpp -->CWallet::EncryptWallet() but its return value is ign=
ored? Again, intentional or a bug or a feature or a ...?=0ANow CWallet::Enc=
ryptWallet() is called by AskPassphraseDialog::accept() and WalletModel::se=
tWalletEncrypted()and they seem very interested in what=A0 CWallet::Encrypt=
Wallet() returns. Could this be involved in some old issue with wallet encr=
yption on bitcoin-qt 0.8.1?=0A=0AThere seems to be plenty of this kind of "=
suspicious" code to ferret about in, with one's IDE during quiet moments. A=
musing is to follow return 0 and return 1 to try and infer their meaning, t=
heir intent?=0A=0A=0ARon=0A
---626213187-280908893-1380770163=:7534
Content-Type: text/html; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

<html><body><div style=3D"color:#000; background-color:#fff; font-family:ti=
mes new roman, new york, times, serif;font-size:12pt"><div>I only bring thi=
s up here since I can't raise https://bitcointalk.org? Perhaps it runs on t=
he silk road servers:)</div><div><br></div><div style=3D"color: rgb(0, 0, 0=
); font-size: 16px; font-family: times new roman,new york,times,serif; back=
ground-color: transparent; font-style: normal;">Upon looking at the 0.8.5 &=
amp; earlier code for CDB:Rewrite(), in the files db.h and db.cpp, you will=
 notice that in db.h it is declared bool static, but in db.cpp it isn't. Is=
 this a problem? Or a feature? Or nothing at all?<br></div><div><br></div><=
div style=3D"color: rgb(0, 0, 0); font-size: 16px; font-family: times new r=
oman,new york,times,serif; background-color: transparent; font-style: norma=
l;">Furthermore, it is called only in wallet.cpp --&gt;CWallet::EncryptWall=
et() but its return value is ignored? Again, intentional or a bug or a
 feature or a ...?</div><div style=3D"color: rgb(0, 0, 0); font-size: 16px;=
 font-family: times new roman,new york,times,serif; background-color: trans=
parent; font-style: normal;">Now CWallet::EncryptWallet() is called by AskP=
assphraseDialog::accept() and WalletModel::setWalletEncrypted()and they see=
m very interested in what&nbsp; CWallet::EncryptWallet() returns. Could thi=
s be involved in some old issue with wallet encryption on bitcoin-qt 0.8.1?=
</div><div style=3D"color: rgb(0, 0, 0); font-size: 16px; font-family: time=
s new roman,new york,times,serif; background-color: transparent; font-style=
: normal;"><br></div><div style=3D"color: rgb(0, 0, 0); font-size: 16px; fo=
nt-family: times new roman,new york,times,serif; background-color: transpar=
ent; font-style: normal;">There seems to be plenty of this kind of "suspici=
ous" code to ferret about in, with one's IDE during quiet moments. Amusing =
is to follow return 0 and return 1 to try and infer their meaning, their
 intent?<br></div><div style=3D"color: rgb(0, 0, 0); font-size: 16px; font-=
family: times new roman,new york,times,serif; background-color: transparent=
; font-style: normal;"><br></div><div style=3D"color: rgb(0, 0, 0); font-si=
ze: 16px; font-family: times new roman,new york,times,serif; background-col=
or: transparent; font-style: normal;">Ron<br></div></div></body></html>
---626213187-280908893-1380770163=:7534--