MIME-Version: 1.0
References: <1dd8c285-e3f4-4f03-d608-103a5026146d@achow101.com>
In-Reply-To: <1dd8c285-e3f4-4f03-d608-103a5026146d@achow101.com>
From: Lloyd Fournier <lloyd.fourn@gmail.com>
Date: Wed, 10 Mar 2021 11:20:58 +1100
Message-ID: <CAH5Bsr22oQ_yOD1eom6gZhUVbr+bMj2W8rfWO=Edujhj9bNsEg@mail.gmail.com>
To: Andrew Chow <achow101-lists@achow101.com>, 
 Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Content-Type: multipart/alternative; boundary="000000000000b92b6a05bd23a520"
Subject: Re: [bitcoin-dev] New PSBT version proposal
Precedence: list

--000000000000b92b6a05bd23a520
Content-Type: text/plain; charset="UTF-8"

Hi Andrew & all,

I've been working with PSBTs for a little while now. FWIW I agree with the
change of removing the global tx and having the input/output data stored
together in the new unified structures.

One thing I've been wondering about is how output descriptors could fit
into PSBTs. They are useful since they allow you to determine the maximum
satisfaction weight for inputs so you can properly align fees as things get
added. I haven't seen any discussion about including them in this revision.
Is it simply a matter of time before they make it into a subsequent PSBT
spec or is there something I'm missing conceptually?

Cheers,

LL

On Thu, 10 Dec 2020 at 09:33, Andrew Chow via bitcoin-dev <
bitcoin-dev@lists.linuxfoundation.org> wrote:

> Hi All,
>
> I would like to propose a new PSBT version that addresses a few
> deficiencies in the current PSBT v0. As this will be backwards
> incompatible, a new PSBT version will be used, v1.
>
> The primary change is to truly have all input and output data for each
> in their respective maps. Instead of having to parse an unsigned
> transaction and lookup some data from there, and other data from the
> correct map, all of the data for an input will be contained in its map.
> Doing so also disallows PSBT_GLOBAL_UNSIGNED_TX in this new version.
> Thus I propose that the following fields be added:
>
> Global:
> * PSBT_GLOBAL_TX_VERSION = 0x02
>    * Key: empty
>    * Value: 32-bit little endian unsigned integer for the transaction
> version number. Must be provided in PSBT v1 and omitted in v0.
> * PSBT_GLOBAL_PREFERRED_LOCKTIME = 0x03
>    * Key: empty
>    * Value: 32 bit little endian unsigned integer for the preferred
> transaction lock time. Must be omitted in PSBT v0. May be provided in
> PSBT v1, assumed to be 0 if not provided.
> * PSBT_GLOBAL_INPUT_COUNT = 0x04
>    * Key: empty
>    * Value: Compact size unsigned integer. Number of inputs in this
> PSBT. Must be provided in PSBT v1 and omitted in v0.
> * PSBT_GLOBAL_OUTPUT_COUNT = 0x05
>    * Key: empty
>    * Value: Compact size unsigned integer. Number of outputs in this
> PSBT. Must be provided in PSBT v1 and omitted in v0.
>
> Input:
> * PSBT_IN_PREVIOUS_TXID = 0x0e
>    * Key: empty
>    * Value: 32 byte txid of the previous transaction whose output at
> PSBT_IN_OUTPUT_INDEX is being spent. Must be provided in PSBT v1 and
> omitted in v0.
> * PSBT_IN_OUTPUT_INDEX = 0x0f
>    * Key: empty
>    * Value: 32 bit little endian integer for the index of the output
> being spent. Must be provided in PSBT v1 and omitted in v0.
> * PSBT_IN_SEQUENCE = 0x0f
>    * Key: empty
>    * Value: 32 bit unsigned little endian integer for the sequence
> number. Must be omitted in PSBT v0. May be provided in PSBT v1 assumed
> to be max sequence (0xffffffff) if not provided.
> * PSBT_IN_REQUIRED_LOCKTIME = 0x10
>    * Key: empty
>    * Value: 32 bit unsigned little endian integer for the lock time that
> this input requires. Must be omitted in PSBT v0. May be provided in PSBT
> v1, assumed to be 0 if not provided.
>
> Output:
> * PSBT_OUT_VALUE = 0x03
>    * Key: empty
>    * Value: 64-bit unsigned little endian integer for the output's
> amount in satoshis. Must be provided in PSBT v1 and omitted in v0.
> * PSBT_OUT_OUTPUT_SCRIPT = 0x04
>    * Key: empty
>    * Value: The script for this output. Otherwise known as the
> scriptPubKey. Must be provided in PSBT v1 and omitted in v0.
>
> This change allows for PSBT to be used in the construction of
> transactions. With these new fields, inputs and outputs can be added as
> needed. One caveat is that there is no longer a unique transaction
> identifier so more care must be taken when combining PSBTs.
> Additionally, adding new inputs and outputs must be done such that
> signatures are not invalidated. This may be harder to specify.
>
> An important thing to note in this proposal are the fields
> PSBT_GLOBAL_PREFERRED_LOCKTIME and PSBT_IN_REQUIRED_LOCKTIME. A Bitcoin
> transaction only has a single locktime yet a PSBT may have multiple
> locktimes. To choose the locktime for the transaction, finalizers must
> choose the maximum of all of the *_LOCKTIME fields.
> PSBT_IN_REQUIRED_LOCKTIME is added because some inputs, such as those
> involving OP_CHECKLOCKTIMEVERIFY, require a specific minimum locktime to
> be set. This field allows finalizers to choose a locktime that is high
> enough for all inputs without needing to understand the scripts
> involved. The PSBT_GLOBAL_PREFERRED_LOCKTIME is the locktime to use if
> no inputs require a particular locktime.
>
> As these changes disallow the PSBT_GLOBAL_UNSIGNED_TX field, PSBT v1
> needs the version number bump to enforce backwards incompatibility.
> However once the inputs and outputs of a PSBT are decided, a PSBT could
> be "downgraded" back to v0 by creating the unsigned transaction from the
> above fields, and then dropping these new fields.
>
> If the list finds that these changes are reasonable, I will write a PR
> to modify BIP 174 to incorporate them.
>
> Thanks,
> Andrew Chow
>
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
>

--000000000000b92b6a05bd23a520
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Andrew &amp; all,</div><div><br></div><div>I&#39;v=
e been working with PSBTs for a little while now. FWIW I agree with the cha=
nge of removing the global tx and having the input/output data stored toget=
her in the new unified structures.</div><div><br></div><div>One thing I&#39=
;ve been wondering about is how output descriptors could fit into PSBTs. Th=
ey are useful since they allow you to determine the maximum satisfaction we=
ight for inputs so you can properly align fees as things get added. I haven=
&#39;t seen any discussion about including them in this revision. Is it sim=
ply a matter of time before they make it into a subsequent PSBT spec or is =
there something I&#39;m missing conceptually?</div><div><br></div><div>Chee=
rs,</div><div><br></div><div>LL<br></div></div><br><div class=3D"gmail_quot=
e"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, 10 Dec 2020 at 09:33, Andr=
ew Chow via bitcoin-dev &lt;<a href=3D"mailto:bitcoin-dev@lists.linuxfounda=
tion.org">bitcoin-dev@lists.linuxfoundation.org</a>&gt; wrote:<br></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef=
t:1px solid rgb(204,204,204);padding-left:1ex">Hi All,<br>
<br>
I would like to propose a new PSBT version that addresses a few <br>
deficiencies in the current PSBT v0. As this will be backwards <br>
incompatible, a new PSBT version will be used, v1.<br>
<br>
The primary change is to truly have all input and output data for each <br>
in their respective maps. Instead of having to parse an unsigned <br>
transaction and lookup some data from there, and other data from the <br>
correct map, all of the data for an input will be contained in its map. <br=
>
Doing so also disallows PSBT_GLOBAL_UNSIGNED_TX in this new version. <br>
Thus I propose that the following fields be added:<br>
<br>
Global:<br>
* PSBT_GLOBAL_TX_VERSION =3D 0x02<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: 32-bit little endian unsigned integer for the transac=
tion <br>
version number. Must be provided in PSBT v1 and omitted in v0.<br>
* PSBT_GLOBAL_PREFERRED_LOCKTIME =3D 0x03<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: 32 bit little endian unsigned integer for the preferr=
ed <br>
transaction lock time. Must be omitted in PSBT v0. May be provided in <br>
PSBT v1, assumed to be 0 if not provided.<br>
* PSBT_GLOBAL_INPUT_COUNT =3D 0x04<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: Compact size unsigned integer. Number of inputs in th=
is <br>
PSBT. Must be provided in PSBT v1 and omitted in v0.<br>
* PSBT_GLOBAL_OUTPUT_COUNT =3D 0x05<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: Compact size unsigned integer. Number of outputs in t=
his <br>
PSBT. Must be provided in PSBT v1 and omitted in v0.<br>
<br>
Input:<br>
* PSBT_IN_PREVIOUS_TXID =3D 0x0e<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: 32 byte txid of the previous transaction whose output=
 at <br>
PSBT_IN_OUTPUT_INDEX is being spent. Must be provided in PSBT v1 and <br>
omitted in v0.<br>
* PSBT_IN_OUTPUT_INDEX =3D 0x0f<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: 32 bit little endian integer for the index of the out=
put <br>
being spent. Must be provided in PSBT v1 and omitted in v0.<br>
* PSBT_IN_SEQUENCE =3D 0x0f<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: 32 bit unsigned little endian integer for the sequenc=
e <br>
number. Must be omitted in PSBT v0. May be provided in PSBT v1 assumed <br>
to be max sequence (0xffffffff) if not provided.<br>
* PSBT_IN_REQUIRED_LOCKTIME =3D 0x10<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: 32 bit unsigned little endian integer for the lock ti=
me that <br>
this input requires. Must be omitted in PSBT v0. May be provided in PSBT <b=
r>
v1, assumed to be 0 if not provided.<br>
<br>
Output:<br>
* PSBT_OUT_VALUE =3D 0x03<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: 64-bit unsigned little endian integer for the output&=
#39;s <br>
amount in satoshis. Must be provided in PSBT v1 and omitted in v0.<br>
* PSBT_OUT_OUTPUT_SCRIPT =3D 0x04<br>
=C2=A0=C2=A0 * Key: empty<br>
=C2=A0=C2=A0 * Value: The script for this output. Otherwise known as the <b=
r>
scriptPubKey. Must be provided in PSBT v1 and omitted in v0.<br>
<br>
This change allows for PSBT to be used in the construction of <br>
transactions. With these new fields, inputs and outputs can be added as <br=
>
needed. One caveat is that there is no longer a unique transaction <br>
identifier so more care must be taken when combining PSBTs. <br>
Additionally, adding new inputs and outputs must be done such that <br>
signatures are not invalidated. This may be harder to specify.<br>
<br>
An important thing to note in this proposal are the fields <br>
PSBT_GLOBAL_PREFERRED_LOCKTIME and PSBT_IN_REQUIRED_LOCKTIME. A Bitcoin <br=
>
transaction only has a single locktime yet a PSBT may have multiple <br>
locktimes. To choose the locktime for the transaction, finalizers must <br>
choose the maximum of all of the *_LOCKTIME fields. <br>
PSBT_IN_REQUIRED_LOCKTIME is added because some inputs, such as those <br>
involving OP_CHECKLOCKTIMEVERIFY, require a specific minimum locktime to <b=
r>
be set. This field allows finalizers to choose a locktime that is high <br>
enough for all inputs without needing to understand the scripts <br>
involved. The PSBT_GLOBAL_PREFERRED_LOCKTIME is the locktime to use if <br>
no inputs require a particular locktime.<br>
<br>
As these changes disallow the PSBT_GLOBAL_UNSIGNED_TX field, PSBT v1 <br>
needs the version number bump to enforce backwards incompatibility. <br>
However once the inputs and outputs of a PSBT are decided, a PSBT could <br=
>
be &quot;downgraded&quot; back to v0 by creating the unsigned transaction f=
rom the <br>
above fields, and then dropping these new fields.<br>
<br>
If the list finds that these changes are reasonable, I will write a PR <br>
to modify BIP 174 to incorporate them.<br>
<br>
Thanks,<br>
Andrew Chow<br>
<br>
_______________________________________________<br>
bitcoin-dev mailing list<br>
<a href=3D"mailto:bitcoin-dev@lists.linuxfoundation.org" target=3D"_blank">=
bitcoin-dev@lists.linuxfoundation.org</a><br>
<a href=3D"https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev" =
rel=3D"noreferrer" target=3D"_blank">https://lists.linuxfoundation.org/mail=
man/listinfo/bitcoin-dev</a><br>
</blockquote></div>

--000000000000b92b6a05bd23a520--