Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 93C808E2 for ; Thu, 4 Jan 2018 10:08:10 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id EA6C7D3 for ; Thu, 4 Jan 2018 10:08:09 +0000 (UTC) Received: by mail-io0-f178.google.com with SMTP id n14so1681029iob.4 for ; Thu, 04 Jan 2018 02:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=WuLcg5mC+VSZ1TxuH17PP3C8wYG+X85xHC0AoV6SksY=; b=DGzn/0NAbQ5b7RcGM0xedwRmix6o8WuBdLUPwIYFs2/YdEjPnOKo5fXZC1mUPRP6Ub HJlJ+nmpcvCXWT2nA1bps5R4BZtP1LrcpwBhXHgFsufHMFgp1usdNUxcTk+Jg+CX6LC8 5JykKS1BlP6qeQNLxmvFt3rSM90C1CjFzUZiwI/fZQ9BCh5t/b7vhxzsAtuAZzcrW6Jl UNh4QD8lp9e0JY7qPzp485F8RNAEnqG8RB7aRbgVs0b8k3AftSAe8Q0xNVFObvRo48FA UFl5n8UCmWZryXrAmbwkM6n1Gra2d8FIXorfOahdEMCQkEq6b4STsGlrPWPOr+Lxb5HL raQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=WuLcg5mC+VSZ1TxuH17PP3C8wYG+X85xHC0AoV6SksY=; b=VTXQFKFSa8a+koy3ghmHitsvn8Uiv+x51OCkzOw6wSbDJRl7Qt189vNw8oFo5VyzAb vytuwzsnSVBaVwN8/6Kg1mEi8lOoNeRVBcsFhIlUmRWl/h9E+/xs/YvKSdjZv88qy2GT U18hPV6w2b0LD6eSmvPeZO5cfhOPVmM3VpsgDZmVreuwKBws21WDAwx2/LyxJP7uD81u ZAIHM4mKHq79yEy44x1WABtO5z8xxaMU4w5NylmtWUTKn2Raxw3bD8rcPJRppsHvauKV 8F2a8F3XHGpV9wARO7KcdHSbeaWhO2sdKe2tQIHHnDm6RAL8alyneahCy90cQ3ETRxZL YK0A== X-Gm-Message-State: AKGB3mK0bj8ctOX/gvYjJOyh7wqvSt5gyeFyokyKA3Q0Rm0dzLqEO2ly QVOEXlNCCdnrHpSg1CU67n/NLRMOIif8HbTLV7Cx/A== X-Google-Smtp-Source: ACJfBovEeUTLi+8Mri87kr5Ibyt3DO7Jr7bZlQ+1bjhzsH9cuTNnpX/dO3xIUSh/f7mUhhi4plIEd5izQDDAWCTUMwE= X-Received: by 10.107.180.23 with SMTP id d23mr4889393iof.281.1515060489006; Thu, 04 Jan 2018 02:08:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.151.142 with HTTP; Thu, 4 Jan 2018 02:08:08 -0800 (PST) From: Felix Wolfsteller Date: Thu, 4 Jan 2018 11:08:08 +0100 Message-ID: To: bitcoin-dev@lists.linuxfoundation.org Content-Type: multipart/alternative; boundary="94eb2c05fc9042b59d0561f08234" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org X-Mailman-Approved-At: Thu, 04 Jan 2018 13:39:26 +0000 Subject: [bitcoin-dev] Update links (use ssl-variant) to opensource.org/[..x..]MIT ? X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2018 10:08:10 -0000 --94eb2c05fc9042b59d0561f08234 Content-Type: text/plain; charset="UTF-8" Hey there Most source files contain the "default" copyright-header (also build by a script in devtools/copyright_header.py), which points out that the MIT license can be found in the COPYING file or at http://www.opensource.org/licenses/mit-license.php. However, the provided link is 1) using http where it could use https, 2) resulting in a redirect (https://opensource.org/licenses/mit-license.php) anyway. I am strongly in favor of using https where possible (I guess there are many other non-ssl links in the code base, but lets tackle the easier ones first). I propose that I 1) create a issue on github, 2) `sed -i` the relevant links, 3) create a PR on github, 4) come back to the mailing list. This change would affect a few hundred files I guess. A question remaining is this change would require a copyright-year-extension (to 2018), too. An example header can be seen e.g. here https://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7ef041942e9b/src/consensus/merkle.cpp#L3 I'd be happy about quick feedback - do not know the culture here, yet. Have fun Felix --94eb2c05fc9042b59d0561f08234 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey there
Most source files contai= n the "default" copyright-header (also build by a script in devto= ols/copyright_header.py), which points out that the MIT license can be foun= d in the COPYING file or at http://www.opensource.org/licens= es/mit-license.php.

Howe= ver, the provided link is 1) using http where it could use https, 2) result= ing in a redirect (https://opensource.org/licenses/mit-license.php) anyway.
=
I am strongly in favor of using https wher= e possible (I guess there are many other non-ssl links in the code base, bu= t lets tackle the easier ones first).

I propose that I
1) create a issue on github,
=
2) `sed -i` the relevant links,
<= /div>
3) create a PR on github,
=
4) come back to the mailing list.

This change would affect a few hundred files I guess.

A question remaining is this change would require a copyright-yea= r-extension (to 2018), too.
An example header can be seen= e.g. here

I'd be happy about quick feedback - do not know the cul= ture here, yet.

Have fun
Felix
--94eb2c05fc9042b59d0561f08234--