MIME-Version: 1.0
From: Felix Wolfsteller <felix.wolfsteller@gmail.com>
Date: Thu, 4 Jan 2018 11:08:08 +0100
Message-ID: <CALHCSvOn8YxFqGu4yXDPnFunNzmy=cmdwKBNmAL45Ymta3REig@mail.gmail.com>
To: bitcoin-dev@lists.linuxfoundation.org
Content-Type: multipart/alternative; boundary="94eb2c05fc9042b59d0561f08234"
Subject: [bitcoin-dev] Update links (use ssl-variant) to
	opensource.org/[..x..]MIT ?
Precedence: list

--94eb2c05fc9042b59d0561f08234
Content-Type: text/plain; charset="UTF-8"

Hey there
Most source files contain the "default" copyright-header (also build by a
script in devtools/copyright_header.py), which points out that the MIT
license can be found in the COPYING file or at
http://www.opensource.org/licenses/mit-license.php.

However, the provided link is 1) using http where it could use https, 2)
resulting in a redirect (https://opensource.org/licenses/mit-license.php)
anyway.
I am strongly in favor of using https where possible (I guess there are
many other non-ssl links in the code base, but lets tackle the easier ones
first).

I propose that I
1) create a issue on github,
2) `sed -i` the relevant links,
3) create a PR on github,
4) come back to the mailing list.

This change would affect a few hundred files I guess.

A question remaining is this change would require a
copyright-year-extension (to 2018), too.

An example header can be seen e.g. here
https://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7ef041942e9b/src/consensus/merkle.cpp#L3

I'd be happy about quick feedback - do not know the culture here, yet.

Have fun
Felix

--94eb2c05fc9042b59d0561f08234
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div><div>Hey there<br></div>Most source files contai=
n the &quot;default&quot; copyright-header (also build by a script in devto=
ols/copyright_header.py), which points out that the MIT license can be foun=
d in the COPYING file or at <span class=3D"gmail-pl-c"><a href=3D"http://ww=
w.opensource.org/licenses/mit-license.php">http://www.opensource.org/licens=
es/mit-license.php</a>.<br><br></span></div><span class=3D"gmail-pl-c">Howe=
ver, the provided link is 1) using http where it could use https, 2) result=
ing in a redirect (<a href=3D"https://opensource.org/licenses/mit-license.p=
hp">https://opensource.org/licenses/mit-license.php</a>) anyway.<br></span>=
</div><span class=3D"gmail-pl-c">I am strongly in favor of using https wher=
e possible (I guess there are many other non-ssl links in the code base, bu=
t lets tackle the easier ones first).<br></span><div><span class=3D"gmail-p=
l-c"><br></span><div><span class=3D"gmail-pl-c">I propose that I</span></di=
v><div><span class=3D"gmail-pl-c">1) create a issue on github,</span></div>=
<div><span class=3D"gmail-pl-c">2) `sed -i` the relevant links,<br></span><=
/div><div><span class=3D"gmail-pl-c">3) create a PR on github,</span></div>=
<div><span class=3D"gmail-pl-c">4) come back to the mailing list.</span></d=
iv><div><span class=3D"gmail-pl-c"><br></span></div><div><span class=3D"gma=
il-pl-c">This change would affect a few hundred files I guess.<br></span></=
div><div><span class=3D"gmail-pl-c"><br></span></div><div><span class=3D"gm=
ail-pl-c">A question remaining is this change would require a copyright-yea=
r-extension (to 2018), too.</span></div><div><span class=3D"gmail-pl-c"><br=
></span></div><div><span class=3D"gmail-pl-c">An example header can be seen=
 e.g. here<br></span></div><div><span class=3D"gmail-pl-c"><a href=3D"https=
://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7ef041942e9b=
/src/consensus/merkle.cpp#L3">https://github.com/bitcoin/bitcoin/blob/a9a49=
e6e7e8df13d80a6dc3245ce7ef041942e9b/src/consensus/merkle.cpp#L3</a><br></sp=
an></div><div><span class=3D"gmail-pl-c"><br></span></div><div><span class=
=3D"gmail-pl-c">I&#39;d be happy about quick feedback - do not know the cul=
ture here, yet.</span></div><div><span class=3D"gmail-pl-c"><br></span></di=
v><div><span class=3D"gmail-pl-c">Have fun</span></div><div><span class=3D"=
gmail-pl-c">Felix<br></span></div></div></div>

--94eb2c05fc9042b59d0561f08234--