Message-ID: <56155572.5040501@domob.eu>
Date: Wed, 07 Oct 2015 19:25:06 +0200
From: Daniel Kraft <d@domob.eu>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Icedove/31.8.0
MIME-Version: 1.0
To: bitcoin-dev@lists.linuxfoundation.org
OpenPGP: id=A7330737
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature";
	boundary="R0hWu1bs2sokwjFdNlLPMuuFSFjfjxOAv"
Subject: [bitcoin-dev] The new obfuscation patch & GetStats
Precedence: list

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--R0hWu1bs2sokwjFdNlLPMuuFSFjfjxOAv
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi!

I hope this is not a stupid question, but I thought I'd ask here first
instead of opening a Github ticket (in case I'm wrong).

With the recently merged "obfuscation" patch, content of the
"chainstate" LevelDB is obfuscated by XOR'ing against a random "key".
This is handled by CLevelDBWrapper's Read/Write methods, which probably
cover most of the usecases.

*However*, shouldn't it also be handled when iterating over the
database?  In particular, I would expect that the obfuscation key is
applied before line 119 in txdb.cpp (i. e., while iterating over the
coin database in CCoinsViewDB::GetStats).

Is there a reason why this need not be done there, or is this an actual
oversight?

Yours,
Daniel

--=20
http://www.domob.eu/
OpenPGP: 1142 850E 6DFF 65BA 63D6  88A8 B249 2AC4 A733 0737
Namecoin: id/domob -> https://nameid.org/?name=3Ddomob
--
Done:  Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Mon-Pri


--R0hWu1bs2sokwjFdNlLPMuuFSFjfjxOAv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWFVV4AAoJEFcvuTrTyRk7TgkQAIHsS1Ec7ASuc+s59Kruc5V1
XDZLUf27wMvvcqeZNpCtMuUMaMy2jtvr7RfTHT29qbSPFmN1yaXcOsgLiACrC6Ul
hHhD5RAa4xal7DavoEt85+HxGmMbQLC6yFiD4wW1orJHegwYT0dFjr6Ff8SquB7D
OjQ84WENuDO7H8+B8a5fJOTmBpN5gKZ0Ci9MSZBc9AoFEL8orrgyhrXU/jC9NOo2
ZQZfkCOMAVpquZfxE8saK84t/dPzDzKcy+r6kPP+q091Y3odCIj7Y2z/uv8zUI0F
+S2yZ9FKnoiX1smqn5c/ScyUqrRq2zniRIJ6AV8zwG59CNRY+VJ6HKLbLag90/CE
ksFVNE5gc9C7sD1defrZdEDeQjqHtjInrI9IHyFnGAYE9ToM/3gkmBkfXhrlwZYy
yPfGDtxUvRDp2tMbWmOdTUBrQo3pqRGP4gXqhQgW61oYaMnfKjGxylI2JdQDJhq1
tYmKAT5NmDtTDp62U1QcY/F41cr4foombpLVLp+hTSYJCBv7+aq6yrTiMdOeb9sM
41dtXfGKb20dHdub0Bp64wK7ICWrctHqqmCJBcXLY2SZpx7UPGWnmI7dWIrVms5h
wWzJ73ALYyzwwYksfJVTumDJhWQ2p2Gy2T2Y4Te7Z0j4PuGRJPkSEYzRFkIFC1JV
nlQeZwb0hJ6+u0heNxFE
=6uHx
-----END PGP SIGNATURE-----

--R0hWu1bs2sokwjFdNlLPMuuFSFjfjxOAv--