MIME-Version: 1.0
In-Reply-To: <CALHCSvOn8YxFqGu4yXDPnFunNzmy=cmdwKBNmAL45Ymta3REig@mail.gmail.com>
References: <CALHCSvOn8YxFqGu4yXDPnFunNzmy=cmdwKBNmAL45Ymta3REig@mail.gmail.com>
From: Felix Wolfsteller <felix.wolfsteller@gmail.com>
Date: Mon, 15 Jan 2018 15:33:28 +0100
Message-ID: <CALHCSvMFro4v8g0f1yFT6jUdry7wKpJZyYgFU0NTbm2LG-5GRw@mail.gmail.com>
To: bitcoin-dev@lists.linuxfoundation.org
Content-Type: multipart/alternative; boundary="94eb2c18a43e689c570562d17f44"
Subject: Re: [bitcoin-dev] Update links (use ssl-variant) to
	opensource.org/[..x..]MIT ?
Precedence: list

--94eb2c18a43e689c570562d17f44
Content-Type: text/plain; charset="UTF-8"

I am a bit disappointed about the feedback (just received one off-list ;)
), but understand now that this mailing list is protocol-only discussions.
So - sorry for that. Anybody interested can follow progress here:
https://github.com/bitcoin/bitcoin/issues/12190
Thanks, Felix

On Thu, Jan 4, 2018 at 11:08 AM, Felix Wolfsteller <
felix.wolfsteller@gmail.com> wrote:

> Hey there
> Most source files contain the "default" copyright-header (also build by a
> script in devtools/copyright_header.py), which points out that the MIT
> license can be found in the COPYING file or at http://www.opensource.org/
> licenses/mit-license.php.
>
> However, the provided link is 1) using http where it could use https, 2)
> resulting in a redirect (https://opensource.org/licenses/mit-license.php)
> anyway.
> I am strongly in favor of using https where possible (I guess there are
> many other non-ssl links in the code base, but lets tackle the easier ones
> first).
>
> I propose that I
> 1) create a issue on github,
> 2) `sed -i` the relevant links,
> 3) create a PR on github,
> 4) come back to the mailing list.
>
> This change would affect a few hundred files I guess.
>
> A question remaining is this change would require a
> copyright-year-extension (to 2018), too.
>
> An example header can be seen e.g. here
> https://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7e
> f041942e9b/src/consensus/merkle.cpp#L3
>
> I'd be happy about quick feedback - do not know the culture here, yet.
>
> Have fun
> Felix
>

--94eb2c18a43e689c570562d17f44
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>I am a bit disappointed about the feedback (just rece=
ived one off-list ;) ), but understand now that this mailing list is protoc=
ol-only discussions. So - sorry for that. Anybody interested can follow pro=
gress here:<br><a href=3D"https://github.com/bitcoin/bitcoin/issues/12190">=
https://github.com/bitcoin/bitcoin/issues/12190</a><br></div>Thanks, Felix<=
br></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Thu, =
Jan 4, 2018 at 11:08 AM, Felix Wolfsteller <span dir=3D"ltr">&lt;<a href=3D=
"mailto:felix.wolfsteller@gmail.com" target=3D"_blank">felix.wolfsteller@gm=
ail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D=
"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D=
"ltr"><div><div><div>Hey there<br></div>Most source files contain the &quot=
;default&quot; copyright-header (also build by a script in devtools/copyrig=
ht_header.py), which points out that the MIT license can be found in the CO=
PYING file or at <span class=3D"m_5618360175334424174gmail-pl-c"><a href=3D=
"http://www.opensource.org/licenses/mit-license.php" target=3D"_blank">http=
://www.opensource.org/<wbr>licenses/mit-license.php</a>.<br><br></span></di=
v><span class=3D"m_5618360175334424174gmail-pl-c">However, the provided lin=
k is 1) using http where it could use https, 2) resulting in a redirect (<a=
 href=3D"https://opensource.org/licenses/mit-license.php" target=3D"_blank"=
>https://opensource.org/<wbr>licenses/mit-license.php</a>) anyway.<br></spa=
n></div><span class=3D"m_5618360175334424174gmail-pl-c">I am strongly in fa=
vor of using https where possible (I guess there are many other non-ssl lin=
ks in the code base, but lets tackle the easier ones first).<br></span><div=
><span class=3D"m_5618360175334424174gmail-pl-c"><br></span><div><span clas=
s=3D"m_5618360175334424174gmail-pl-c">I propose that I</span></div><div><sp=
an class=3D"m_5618360175334424174gmail-pl-c">1) create a issue on github,</=
span></div><div><span class=3D"m_5618360175334424174gmail-pl-c">2) `sed -i`=
 the relevant links,<br></span></div><div><span class=3D"m_5618360175334424=
174gmail-pl-c">3) create a PR on github,</span></div><div><span class=3D"m_=
5618360175334424174gmail-pl-c">4) come back to the mailing list.</span></di=
v><div><span class=3D"m_5618360175334424174gmail-pl-c"><br></span></div><di=
v><span class=3D"m_5618360175334424174gmail-pl-c">This change would affect =
a few hundred files I guess.<br></span></div><div><span class=3D"m_56183601=
75334424174gmail-pl-c"><br></span></div><div><span class=3D"m_5618360175334=
424174gmail-pl-c">A question remaining is this change would require a copyr=
ight-year-extension (to 2018), too.</span></div><div><span class=3D"m_56183=
60175334424174gmail-pl-c"><br></span></div><div><span class=3D"m_5618360175=
334424174gmail-pl-c">An example header can be seen e.g. here<br></span></di=
v><div><span class=3D"m_5618360175334424174gmail-pl-c"><a href=3D"https://g=
ithub.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7ef041942e9b/src=
/consensus/merkle.cpp#L3" target=3D"_blank">https://github.com/bitcoin/<wbr=
>bitcoin/blob/<wbr>a9a49e6e7e8df13d80a6dc3245ce7e<wbr>f041942e9b/src/consen=
sus/<wbr>merkle.cpp#L3</a><br></span></div><div><span class=3D"m_5618360175=
334424174gmail-pl-c"><br></span></div><div><span class=3D"m_561836017533442=
4174gmail-pl-c">I&#39;d be happy about quick feedback - do not know the cul=
ture here, yet.</span></div><div><span class=3D"m_5618360175334424174gmail-=
pl-c"><br></span></div><div><span class=3D"m_5618360175334424174gmail-pl-c"=
>Have fun</span></div><span class=3D"HOEnZb"><font color=3D"#888888"><div><=
span class=3D"m_5618360175334424174gmail-pl-c">Felix<br></span></div></font=
></span></div></div>
</blockquote></div><br></div>

--94eb2c18a43e689c570562d17f44--