MIME-Version: 1.0
In-Reply-To: <534FA237.1010501@cs.huji.ac.il>
References: <534FA237.1010501@cs.huji.ac.il>
Date: Thu, 17 Apr 2014 11:00:04 -0700
Message-ID: <CAHUNwMoSG+C8T4_69j3-qmM_Z=WYixARYuAr1CEUv6Wxq6kajA@mail.gmail.com>
From: Matthieu Riou <matthieu@blockcypher.com>
To: Sharon Dvir <sharondvir@cs.huji.ac.il>
Content-Type: multipart/alternative; boundary=047d7b3439e48548d504f740cdcc
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] question about ProcessMessage()
Precedence: list

--047d7b3439e48548d504f740cdcc
Content-Type: text/plain; charset=ISO-8859-1

Github has a nice feature that lets you link to a specific line of code:

https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L3549

Is it the line you're referring to? It just flags the peer as at that point
we know we don't have more addresses to learn from it (peers send 1000
addrs). The previous
check<https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L3497>only
applies for peers sending an addr message that would have more than
1000 addresses, which is disallowed to prevent flooding. And no number is
both greater and lesser than 1000 :)

Matthieu


On Thu, Apr 17, 2014 at 2:43 AM, Sharon Dvir <sharondvir@cs.huji.ac.il>wrote:

> Hi, in main.cpp, ProcessMessage(), the line:
> if (vAddr.size() < 1000) that appears at about line 3290
> (not sure which, as I have made changes.)
> What is the purpose of this line?
> vAddr.size() was already checked at about line 3240, and if it was >
> 1000, the function has returned.
> Is pfrom->fGetAddr allowed to be true iff  vAddr.size()==1000 ?
> Could not find it in list archive.
> Thanks.
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/NeoTech
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>

--047d7b3439e48548d504f740cdcc
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Github has a nice feature that lets you link to a specific=
 line of code:<div><br></div><div><a href=3D"https://github.com/bitcoin/bit=
coin/blob/master/src/main.cpp#L3549">https://github.com/bitcoin/bitcoin/blo=
b/master/src/main.cpp#L3549</a><br>
</div><div><br></div><div>Is it the line you&#39;re referring to? It just f=
lags the peer as at that point we know we don&#39;t have more addresses to =
learn from it (peers send 1000 addrs). The <a href=3D"https://github.com/bi=
tcoin/bitcoin/blob/master/src/main.cpp#L3497">previous check</a> only appli=
es for peers sending an addr message that would have more than 1000 address=
es, which is disallowed to prevent flooding. And no number is both greater =
and lesser than 1000 :)</div>
<div><br></div><div>Matthieu</div></div><div class=3D"gmail_extra"><br><br>=
<div class=3D"gmail_quote">On Thu, Apr 17, 2014 at 2:43 AM, Sharon Dvir <sp=
an dir=3D"ltr">&lt;<a href=3D"mailto:sharondvir@cs.huji.ac.il" target=3D"_b=
lank">sharondvir@cs.huji.ac.il</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">Hi, in main.cpp, ProcessMessage(), the line:=
<br>
if (vAddr.size() &lt; 1000) that appears at about line 3290<br>
(not sure which, as I have made changes.)<br>
What is the purpose of this line?<br>
vAddr.size() was already checked at about line 3240, and if it was &gt;<br>
1000, the function has returned.<br>
Is pfrom-&gt;fGetAddr allowed to be true iff =A0vAddr.size()=3D=3D1000 ?<br=
>
Could not find it in list archive.<br>
Thanks.<br>
<br>
---------------------------------------------------------------------------=
---<br>
Learn Graph Databases - Download FREE O&#39;Reilly Book<br>
&quot;Graph Databases&quot; is the definitive new guide to graph databases =
and their<br>
applications. Written by three acclaimed leaders in the field,<br>
this first edition is now available. Download your free book today!<br>
<a href=3D"http://p.sf.net/sfu/NeoTech" target=3D"_blank">http://p.sf.net/s=
fu/NeoTech</a><br>
_______________________________________________<br>
Bitcoin-development mailing list<br>
<a href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-develo=
pment@lists.sourceforge.net</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development=
" target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de=
velopment</a><br>
</blockquote></div><br></div>

--047d7b3439e48548d504f740cdcc--