Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1TvUU3-0001c9-Dn for bitcoin-development@lists.sourceforge.net; Wed, 16 Jan 2013 15:00:55 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of bluematt.me designates 173.246.101.161 as permitted sender) client-ip=173.246.101.161; envelope-from=bitcoin-list@bluematt.me; helo=mail.bluematt.me; Received: from vps.bluematt.me ([173.246.101.161] helo=mail.bluematt.me) by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1TvUU2-0002Fr-5C for bitcoin-development@lists.sourceforge.net; Wed, 16 Jan 2013 15:00:55 +0000 Received: from [152.23.116.230] (mid-campus-00230.wireless.unc.edu [152.23.116.230]) by mail.bluematt.me (Postfix) with ESMTPSA id ED1F355B4; Wed, 16 Jan 2013 15:00:47 +0000 (UTC) Message-ID: <1358348447.1048.0.camel@localhost.localdomain> From: Matt Corallo To: Mike Hearn Date: Wed, 16 Jan 2013 10:00:47 -0500 In-Reply-To: References: <20121121151534.GA5540@vps7135.xlshosting.net> <1353523117.1085.14.camel@localhost.localdomain> <20121127211019.GA22701@vps7135.xlshosting.net> <1357876751.1740.4.camel@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1TvUU2-0002Fr-5C Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] Draft BIP for Bloom filtering X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2013 15:00:55 -0000 Actually, there is one more minor algorithmic change I would like to make to the way the hash function is computed really quick before it gets merged, I'll have that finished up by the end of today. Matt On Wed, 2013-01-16 at 11:43 +0100, Mike Hearn wrote: > Matts latest code has been tested by Andreas and seems to work > correctly. He had to extend the client a bit to refresh the filter > every 25k blocks because even with the extra flag, eventually the > filter degrades into uselessness, but it did still improve the > situation quite a bit. > > Because it's unit tested, been reviewed by me several times, has an > interoperable implementation that has also been tested by Andreas in a > build of his smartphone app, I'm going to ACK the current code and > request that it be merged in to 0.8. What do you say Gavin? > > The next step after that would be profiling. It's a big performance > improvement for SPV clients already, but not as much as I anticipated. > I suspect there's a simple bottleneck or missed optimization > somewhere. But that can obviously come post-0.8