Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191]
	helo=mx.sourceforge.net)
	by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <srintuar@gmail.com>) id 1WhVKb-0006sx-B0
	for bitcoin-development@lists.sourceforge.net;
	Tue, 06 May 2014 02:42:09 +0000
Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.212.172 as permitted sender)
	client-ip=209.85.212.172; envelope-from=srintuar@gmail.com;
	helo=mail-wi0-f172.google.com; 
Received: from mail-wi0-f172.google.com ([209.85.212.172])
	by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128)
	(Exim 4.76) id 1WhVKa-0000UT-GX
	for bitcoin-development@lists.sourceforge.net;
	Tue, 06 May 2014 02:42:09 +0000
Received: by mail-wi0-f172.google.com with SMTP id hi2so2369764wib.11
	for <bitcoin-development@lists.sourceforge.net>;
	Mon, 05 May 2014 19:42:02 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.180.11.239 with SMTP id t15mr18677078wib.25.1399344122278;
	Mon, 05 May 2014 19:42:02 -0700 (PDT)
Received: by 10.194.78.198 with HTTP; Mon, 5 May 2014 19:42:02 -0700 (PDT)
Date: Mon, 5 May 2014 22:42:02 -0400
Message-ID: <CACUQsLJwNo=GtcozCRpZU9PDDJE1fY-mnMomCUtf0WCsgGEnfA@mail.gmail.com>
From: Srintuar <srintuar@gmail.com>
To: bitcoin-development@lists.sourceforge.net
Content-Type: multipart/alternative; boundary=001a11c289be53b88c04f8b23112
X-Spam-Score: -0.6 (/)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for
	sender-domain
	0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
	(srintuar[at]gmail.com)
	-0.0 SPF_PASS               SPF: sender matches SPF record
	1.0 HTML_MESSAGE           BODY: HTML included in message
	-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
	author's domain
	0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
	not necessarily valid
	-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-Headers-End: 1WhVKa-0000UT-GX
Subject: [Bitcoin-development] Bug in key.cpp
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Tue, 06 May 2014 02:42:09 -0000

--001a11c289be53b88c04f8b23112
Content-Type: text/plain; charset=UTF-8

I think i see a bug:

line 273 of key.cpp

        if (rec<0 || rec>=3)
            return false;

Afaict, 3 is a perfectly valid value, meaning 25% of sig-> key recoveries
would fail erroneously...

--001a11c289be53b88c04f8b23112
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>I think i see a bug:<br><br>line 273 of key.cpp<br><b=
r>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (rec&lt;0 || rec&gt;=3D3)<b=
r>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return=
 false;<br><br></div>Afaict, 3 is a perfectly valid value, meaning 25% of s=
ig-&gt; key recoveries would fail erroneously...<br>
<div><br></div><div><br></div></div>

--001a11c289be53b88c04f8b23112--