Delivery-date: Sat, 24 Feb 2024 10:48:20 -0800
Sender: bitcoindev@googlegroups.com
Received-SPF: pass (google.com: domain of pete@petertodd.org designates 66.111.4.26 as permitted sender) client-ip=66.111.4.26;
Feedback-ID: i525146e8:Fastmail
Date: Sat, 24 Feb 2024 18:45:41 +0000
From: Peter Todd <pete@petertodd.org>
To: Nagaev Boris <bnagaev@gmail.com>
Cc: bitcoindev@googlegroups.com
Subject: Re: [bitcoindev] Over Half of Replace-by-Fee-Rate Replacements Are Mined
Message-ID: <Zdo5VZIu3gU5wVQM@petertodd.org>
References: <ZdoSP+Z/f17TYOD+@petertodd.org>
 <CAFC_Vt5TSjGVk58o5G8aW4Jt4aJyDQvR9yE4eLvtB1t+m1jrYg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="BMq109yhr1Ol0UB7"
Content-Disposition: inline
In-Reply-To: <CAFC_Vt5TSjGVk58o5G8aW4Jt4aJyDQvR9yE4eLvtB1t+m1jrYg@mail.gmail.com>
Precedence: list
Mailing-list: list bitcoindev@googlegroups.com; contact bitcoindev+owners@googlegroups.com


--BMq109yhr1Ol0UB7
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline

On Sat, Feb 24, 2024 at 02:55:26PM -0300, Nagaev Boris wrote:
> > I recently released a [prototype Libre Relay fork](https://github.com/petertodd/bitcoin/tree/libre-relay-v26.0) of Bitcoin Core v26.0, that among
> > other things, implements [Pure Replace-By-Fee-Rate](/2024/one-shot-replace-by-fee-rate#pure-replace-by-fee-rate) (RBFR)
> > with a 2x ratio. This means that transactions will be replaced if the fee-rate
> > of the new transaction is at least 2x higher than the old transaction(s), even
> > if the absolute fee is lower.
> 
> I like the idea of pure replacement by fee rate, but I'm not sure
> about the 2x coefficient. I'm afraid it can result in overpaying.
> 
> What is the purpose of the 2x coefficient? Is it needed to prevent DoS
> by continuously increasing feerate by a fraction of a percent? Isn't
> 1.1x enough to prevent this DoS vector? A rise from 100 sats/byte to
> 110 sats/byte is easier to bear, then a rise from 100 to 200,
> especially if the next block feerate is 105.

The coefficient is a trade-off between overpaying and DoS attack cost. The
smaller the coefficient, the more replacements that can be done:

2^10    = 1024
1.5^10  = 58
1.25^10 = 9.3
1.1^10  = 2.6

I picked 2x for the prototype because it's:

1) A safe default that makes DoS attacks _very_ expensive.
2) Low enough that the primary purpose of preventing pinning attacks still
   works.
3) High enough to be clearly incentive compatible for miners.
4) A ratio that's easy to implement with addition.

The last reason is kinda funny... CFeeRate in Bitcoin Core v26.0 doesn't
support multiplication or division operations. So I implemented the 2x ratio by
just adding a fee-rate to itself.

Personally, I think 1.25 would be a reasonable ratio. But I wanted to release a
conservative version first to minimize the impact of DoS attacks.

-- 
https://petertodd.org 'peter'[:-1]@petertodd.org

-- 
You received this message because you are subscribed to the Google Groups "Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bitcoindev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/bitcoindev/Zdo5VZIu3gU5wVQM%40petertodd.org.

--BMq109yhr1Ol0UB7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE0RcYcKRzsEwFZ3N5Lly11TVRLzcFAmXaOVIACgkQLly11TVR
LzdCYg/9EfIMUPK2Z6TJwODCedxxx4V0NcwYnhMaMFT9c8jgx5HnvaDvuddotG7D
1AIEpN7hRvv7rLQdzTdpYSBp3BuPaKGvPaAaSQFJ9cI1jMxlDbSHHWtslH+GeLvS
+NWHR/DQhhhEVLjt7JWeDWSyvaJuc1ZrCSQPrs9tJBy6XQIKSs2cq+VcSE0T4fpa
tcU/PgXt9guN0VnQ2i/osSeSf8azdz4gKPluoTydJKXVLAAru1jQeMhIwWvqt5e/
J806F6T6IfMuTFY2e9sNhx7r/0phzLq42tIAGH+PBeXnNqX69Ne//7Qzn6Q9NoFX
o1/p/Nobt64yf9NJLvvQb9f1dbLKPTe3DReQTmB0a4f24hM+l2cHtTOlZcAaSdtt
sPeg5xJLWZ+eTWpQlpUMk1v0DgZS/mUbZedU68L7qJdENvJYJ/tJ0VVDmii9xBpJ
zgoDtjQtawsdy8y/M4cvZM+kYzTZyE8f+Q2GxSNdAOEo+5YmULIhKY5/XWtszj/I
DrsoNe9YTf6yW0X7V/rNKd/8FxnBxHNn1Go2hi3TMeTyDgl6N60lm8IFlR6S0F4E
4L5E5a8Ge+kbI5cxRf6c4YmDqXTiiEUyJeW6SO3XfqPIpijQdUTAVgl93tJMmHI4
BC68Z4pIqkh8QrBztVd/AsdQyOj2UgizXgChaHU7O+ZbTsjefxQ=
=BkdP
-----END PGP SIGNATURE-----

--BMq109yhr1Ol0UB7--