MIME-Version: 1.0
In-Reply-To: <CA+s+GJBLUTfu8q2zE4pJ+HO5u-GweGNKZebV=XRhBe7TCPggPg@mail.gmail.com>
References: <CAKaEYhK5ZzP8scbhyzkEU+WdWjwMBDzkgF+SrC-Mdjgo9G9RnA@mail.gmail.com>
	<CACezXZ94oDX1O7y7cgh+HvDj4QiDWmy1NVQ4Ahq=gmzhgmUaHQ@mail.gmail.com>
	<CAKaEYhK4v3mhkGMKDW9g7km+5artBAjpukQdwx17psgdJaqvgA@mail.gmail.com>
	<CAHQs=o4pKBoVO-14dqoq9EoNxq2BNnKE+zmOjLBw+XqJfAp8yA@mail.gmail.com>
	<CAKaEYh+bePsmzM5XU1wpb_SFrTnbKB8LxMvWLLqP4p8KuesuSA@mail.gmail.com>
	<20130401225107.GU65880@giles.gnomon.org.uk>
	<20130401225417.GV65880@giles.gnomon.org.uk>
	<CA+s+GJBLUTfu8q2zE4pJ+HO5u-GweGNKZebV=XRhBe7TCPggPg@mail.gmail.com>
Date: Tue, 2 Apr 2013 23:51:45 -0400
Message-ID: <CA+8xBpcZtsZ=p30hJtqLTBJPEE3eD=gQ+x6bKy46z0hc8XNB1Q@mail.gmail.com>
From: Jeff Garzik <jgarzik@exmulti.com>
To: Wladimir <laanwj@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] bitcoin pull requests
Precedence: list

On Tue, Apr 2, 2013 at 11:41 PM, Wladimir <laanwj@gmail.com> wrote:
> Maybe now that bitcoin is growing out of the toy phase it's an idea to start
> gpg signing commits, like the Linux kernel
> (https://lwn.net/Articles/466468/).
>
> But I suppose then we can't use github anymore to merge as-is and need
> manual steps?

Correct, that rules out github, AFAICS.

Though, honestly, when I ACK that means I read the code, which is more
important than the author really.  github seems fine for that still,
though I do wonder if there is a race possible,

* sneak uploads innocent branch sneak/bitcoin.git #innocent
* sneak creates pull req
* just before I click "pull", sneak rebases the branch to something evil

-- 
Jeff Garzik
exMULTI, Inc.
jgarzik@exmulti.com