Date: Wed, 26 Oct 2022 16:39:02 +0000
To: Dhruv M <dhruv@bip324.com>
From: Pieter Wuille <bitcoin-dev@wuille.net>
Message-ID: <zxv58iXZ73hf9ge8S0QLTanW-uLzaWjNtMHuKONP9hrqS5RhwitxzfVaMH8hbi3yImgNrKme3lCuDcHYKkpxEQHyGZZHJ8xtReOcnAx3o4g=@wuille.net>
In-Reply-To: <56677685-619a-691f-d5bc-54b69fdb6ed2@bip324.com>
References: <56677685-619a-691f-d5bc-54b69fdb6ed2@bip324.com>
Feedback-ID: 19463299:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: bitcoin-dev@lists.linuxfoundation.org
Subject: Re: [bitcoin-dev] Refreshed BIP324
Precedence: list

Hi all,

On Saturday, October 8th, 2022 at 8:59 AM, Dhruv M <dhruv@bip324.com> wrote=
:

> We have refreshed the proposal for BIP324, a new bitcoin P2P protocol
> featuring opportunistic encryption, a mild bandwidth reduction, and the
> ability
> to negotiate upgrades before exchanging application messages. We'd like
> to invite community members to review the BIP[1] and the related Bitcoin
> Core
> code[2].

One open question we have regarding BIP324's design is how to deal with the
coordination of assigning the message type IDs.

For context, the current BIP324 draft introduces a notion of 1-byte message
type IDs, which take the place of the 12-byte command strings (in a backwar=
d
compatible way; it's still possible to send full strings). This offers a
mild bandwidth reduction (3 bytes per message overall), especially since ma=
ny
messages on the network are fairly small.

However, it obviously raises the question of how the mapping table between =
the
1-byte IDs and the commands they represent should be maintained:

1. The most straightforward solution is using the BIP process as-is: let BI=
P324
   introduce a fixed initial table, and future BIPs which introduce new
   messages can introduce new mapping entries for it. In theory, this is no
   worse than the current coordination difficulty about command strings, bu=
t
   in practice the risk of collisions due to competing proposals is of cour=
se
   significantly larger with 1-byte IDs vs. 12-byte strings.

2. An alternative approach is not using 1-byte IDs but slightly longer ones=
;
   for example 3-byte IDs, each consisting of a 2-byte BIP number and a 1-b=
yte
   message index introduced by that BIP, at the cost of a smaller bandwidth
   improvement. This significantly reduces collision risks, but doesn't rem=
ove
   the coordination process concerns entirely (e.g. revisions changing what=
 a
   BIP introduces need to be taken into account and probably still mean BIP=
s
   need to explicitly list which assignments they introduce).

3. Yet another possibility is not having a fixed table at all, and negotiat=
e
   the mapping dynamically. E.g. either side could send a message at
   connection time with an explicit table of entries "when I send byte X, I
   mean command Y".

4. Lastly, the whole feature could just be dropped from BIP324 (sticking wi=
th
   command strings), and left for a follow-up (or independent) protocol
   improvement. Since arguably this is purely an application-layer concern =
and
   not a transport-layer one, it could even be added as an optional feature=
 to
   the (pre-BIP324) protocol today. That would however very likely mean tha=
t
   BIP324 if adopted as-is isn't actually an (albeit small) bandwidth
   reduction compared to today, and forego a possibility to fix a fairly
   gratuitous inefficiency in the protocol from day one.

Our idea is to start out with approach (1), with a mapping table effectivel=
y
managed by the BIP process directly, but if and when collisions become a
concern (maybe due to many parallel proposals, maybe because the number of
messages just grows too big), switch to approach (3), possibly even
differentially (the sent mappings are just additions/overwrites of the
BIP-defined table mappings, rather than a full mapping).

That said, we're not all that convinced this is the best approach, and feel
this more a community/process question than a technical one, so it would be
good to see more opinions on the topic.

Cheers,

--=20
Dhruv, Pieter, Tim