Delivery-date: Wed, 11 Dec 2024 05:36:53 -0800
Sender: bitcoindev@googlegroups.com
Received-SPF: pass (google.com: domain of aj@erisian.com.au designates 172.104.61.193 as permitted sender) client-ip=172.104.61.193;
Date: Wed, 11 Dec 2024 23:28:42 +1000
From: Anthony Towns <aj@erisian.com.au>
To: Brandon Black <freedom@reardencode.com>
Cc: bitcoindev@googlegroups.com
Subject: Re: [bitcoindev] Covenants Support - Bitcoin Wiki
Message-ID: <Z1mTiguyy5waz4Vg@erisian.com.au>
References: <028c0197-5c45-4929-83a9-cfe7c87d17f4n@googlegroups.com>
 <941b8c22-0b2c-4734-af87-00f034d79e2e@gmail.com>
 <Z1dPfjDwioa/DXzp@erisian.com.au>
 <Z1dW77h3rhr5oivP@console>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <Z1dW77h3rhr5oivP@console>
X-Spam_score: -0.0
X-Spam_bar: /
X-Original-Sender: aj@erisian.com.au
X-Original-Authentication-Results: gmr-mx.google.com;       spf=pass
 (google.com: domain of aj@erisian.com.au designates 172.104.61.193 as
 permitted sender) smtp.mailfrom=aj@erisian.com.au
Content-Transfer-Encoding: quoted-printable
Precedence: list
Mailing-list: list bitcoindev@googlegroups.com; contact bitcoindev+owners@googlegroups.com
List-ID: <bitcoindev.googlegroups.com>
X-Google-Group-Id: 786775582512
List-Post: <https://groups.google.com/group/bitcoindev/post>, <mailto:bitcoindev@googlegroups.com>
List-Help: <https://groups.google.com/support/>, <mailto:bitcoindev+help@googlegroups.com>
List-Archive: <https://groups.google.com/group/bitcoindev
List-Subscribe: <https://groups.google.com/group/bitcoindev/subscribe>, <mailto:bitcoindev+subscribe@googlegroups.com>
List-Unsubscribe: <mailto:googlegroups-manage+786775582512+unsubscribe@googlegroups.com>,
 <https://groups.google.com/group/bitcoindev/subscribe>
X-Spam-Score: -0.8 (/)

On Mon, Dec 09, 2024 at 12:45:35PM -0800, Brandon Black wrote:
> First, my example scripts for Lightning Symmetry all use opcodes that do
> not exist in the script testing environments so I cannot run my scripts
> through those environments.

You've implemented your code against bitcoin inquisition 27.x [0],
which already includes an "evalscript" subcommand [1] that allows you
to do precisely that, even without updating the functional test suite
so that CI passes. So, yes, you can run your scripts through testing
environments.

You can also easily tweak your scripts to run them through unmodified
testing environments to at least ensure you aren't making trivial errors
and to check the stack is working the way you think it should -- replace
the new commands with OP_NOP (for things like CTV) or OP_2DROP OP_VERIFY
(for things like CHECKSIGVERIFY, where an empty signature would fail,
and there are two other arguments to ignore).

> The fact that I misglanced the opcode list
> during drafting is completely irrelevant to the exercise.

That you made a mistake is perhaps excusable, though as someone proposing
to modify the script language, being more than glancingly familiar with
script as it is today seems like a pretty basic expectation. That you
didn't put your work through even the most basic testing cycle before
publicising it isn't so excusable. [2]

It's utterly astounding to me that you're publicising your project
as "lnhance" [3] and yet are willing to be that careless in your
demonstrations of how it might enhance the lightning network.

Cheers,
aj

[0] https://github.com/bitcoin-inquisition/bitcoin/pull/45
[1] https://github.com/bitcoin-inquisition/bitcoin/pull/58

[2] For instance, I made a claim above that you can use evalscript
    with your inquisition pr. That's something that I should test,
    and when I do, it turns out there's a line that needs fixing to
    make that work. Here's what it looks like after that's done,
    checking the first entry in the bip340 test vectors:

    ```
    $ ./bitcoin-util -sigversion=3Dtapscript -script_flags=3DCHECKSIGFROMST=
ACK evalscript '0x200000000000000000000000000000000000000000000000000000000=
000000000 0x20F9308A019258C31049344F85F89D5229B531C845836F99B08601F113BCE03=
6F9 CHECKSIGFROMSTACK' E907831F80848D1069A5371B402410364BDF1C5F8307B0084C55=
F1CE2DCA821525F66A4A85EA8B71E482A74F382D2CE5EBEEE8FDB2172F477DF4900D310536C=
0
    {
      "script": {
        "asm": "00000000000000000000000000000000000000000000000000000000000=
00000 f9308a019258c31049344f85f89d5229b531c845836f99b08601f113bce036f9 OP_C=
HECKSIGFROMSTACK",
        "hex": "20000000000000000000000000000000000000000000000000000000000=
000000020f9308a019258c31049344f85f89d5229b531c845836f99b08601f113bce036f9cc=
",
        "type": "nonstandard"
      },
      "sigversion": "tapscript",
      "script_flags": [
        "CHECKSIGFROMSTACK"
      ],
      "stack-after": [
        "01"
      ],
      "sigop-count": 0,
      "success": true
    }
    ```

[3] https://www.lnhance.org/#team

--=20
You received this message because you are subscribed to the Google Groups "=
Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to bitcoindev+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/bitcoindev/=
Z1mTiguyy5waz4Vg%40erisian.com.au.