Message-ID: <561CE4C8.3000501@domob.eu>
Date: Tue, 13 Oct 2015 13:02:32 +0200
From: Daniel Kraft <d@domob.eu>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Icedove/31.8.0
MIME-Version: 1.0
To: bitcoin-dev@lists.linuxfoundation.org
OpenPGP: id=A7330737
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature";
	boundary="OefWMx2rntXTg5wHF9eu5ePwehkl5nhHD"
Subject: [bitcoin-dev] Initial getheaders request
Precedence: list

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--OefWMx2rntXTg5wHF9eu5ePwehkl5nhHD
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi!

I've stumbled upon the code that does the initial "getheaders" request,
i. e., around line 4960 of src/main.cpp [1].

  [1] https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L4960

For some reason, it uses not pindexBestHeader but the *preceding* block
pindexBestHeader->pprev as the "from argument".  In contrast, the
request on line 4132 [2] (which is done in response to a newly announced
block) *does* use pindexBestHeader.

  [2] https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L4132

I see no apparent reason for using the preceding call; but if I change
it to pindexBestHeader on line 4960 as well, the wallet.py test seems to
get stuck.  I've not been able to figure out from the logs and the code
why this is the case; can anyone help me?  I think this is something
that should really be explained in a comment around line 4960.  If
someone can make me understand, I can write a pull request for that -- I
guess this will save others some time wondering like I do at the moment.

Yours,
Daniel

--=20
http://www.domob.eu/
OpenPGP: 1142 850E 6DFF 65BA 63D6  88A8 B249 2AC4 A733 0737
Namecoin: id/domob -> https://nameid.org/?name=3Ddomob
--
Done:  Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Mon-Pri


--OefWMx2rntXTg5wHF9eu5ePwehkl5nhHD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWHOTMAAoJEFcvuTrTyRk7dHcP/0nrT+pV7YDVaVSUhaJZc4Ag
wwSsDVQECkh4urpZ54P8FmDF9fY8zJBQu9Qe0vT7t+oTb1wf1hVjEOWbGxNeCd6L
HcWxYrIVK1AQL5MqfAqLP4VX+Q1UgClmVXiQo+0eobs3Dv07pfH2DQSCnxBM+Umd
xl4JrCdJXsFG2O4UMc0VgEBA6cmbAXfR/9iVK8JDsQkmBFKtwV50WlsdCxp4Iadg
0V4luzKXLKlk/t5oVjLe4yxHSe2jkDuOAnsvdFaa18Vzxyua607A/+/GBD8OWQQ8
fbQP2AFNRIiDmJKTJYJLyimXPkzq/eO+Yq+mYne1IXiiF/imyCEaKBTiwe1xCVAO
2tdolFHtKtzaTY5NN1VSbPma2hMKhDEiviI/dTu1GJ5PR09W57H0Suiri556LA8Y
7YVdmQLpknqongLjtxPvttKf2RyzfbaITdADiX9R6tTlY63bFvqZsWbb91FCaEBw
QYFsqQqDvmpOaDwHfdDfSw28hmIGu4g7KAkq+itkAyw6tHcymcxJFPOZU98yyfE3
hqDYTJ7vuT4oI0ubnpUh50tL8CSz6aGKy/jEOpgHSmWXAfeeluINu8YuZAvgU8MY
tgEs0MFjrn4kQzEjeMvhBmIeGqczs6K9vssIsKcBupYff0LYeuzjUoItFKGTsuwW
JaifYSfBA+jGUF6wr6/1
=8bhy
-----END PGP SIGNATURE-----

--OefWMx2rntXTg5wHF9eu5ePwehkl5nhHD--