Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of gmail.com
	designates 209.85.214.41 as permitted sender)
	client-ip=209.85.214.41; envelope-from=mh.in.england@gmail.com;
	helo=mail-bk0-f41.google.com; 
MIME-Version: 1.0
Sender: mh.in.england@gmail.com
In-Reply-To: <20131004115300.GA22215@savin>
References: <CANEZrP1Sd8cK2YUr4OSvnOxEJrbWpmfdpor-qbap1f98tGqPwg@mail.gmail.com>
	<20131004115300.GA22215@savin>
Date: Fri, 4 Oct 2013 14:14:19 +0200
Message-ID: <CANEZrP3e4G_XJy4wDc6VeeBfPG3p4dJ4tpcB8PTwMCNn4+=9Yg@mail.gmail.com>
From: Mike Hearn <mike@plan99.net>
To: Peter Todd <pete@petertodd.org>
Content-Type: multipart/alternative; boundary=20cf30223a83ef00a904e7e93d54
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Code review
Precedence: list

--20cf30223a83ef00a904e7e93d54
Content-Type: text/plain; charset=UTF-8

On Fri, Oct 4, 2013 at 1:53 PM, Peter Todd <pete@petertodd.org> wrote:

> When I'm reviewing multiple commit pull-requests and want to see every
> change made, I always either click on the "Files Changed" tab on github,
> which collapses every commit into a single diff, or do the equivalent
> with git log.
>
> Why doesn't that work for you?
>

The files changed tab definitely works better for reading. In the past
comments I put there have disappeared, but I think that can also be true of
comments put on the individual commit reviews (which is another issue with
github, but it's unrelated to how the commits are presented). So I have
lost trust in doing reviews that way. It does make things easier to read
though.

One advantage of using github is that they're an independent third
> party; we should think carefully about the risks of furthering the
> impression that Bitcoin development is a closed process by moving the
> code review it to a server that we control with explicit review groups.
>

I guess anyone would be able to sign up and comment.

--20cf30223a83ef00a904e7e93d54
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">On Fri, Oct 4, 2013 at 1:53 PM, Peter Todd <span dir=3D"lt=
r">&lt;<a href=3D"mailto:pete@petertodd.org" target=3D"_blank">pete@peterto=
dd.org</a>&gt;</span> wrote:<br><div class=3D"gmail_extra"><div class=3D"gm=
ail_quote">
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div class=3D"im"><span style=3D"color:rgb(3=
4,34,34)">When I&#39;m reviewing multiple commit pull-requests and want to =
see every</span><br>
</div>
change made, I always either click on the &quot;Files Changed&quot; tab on =
github,<br>
which collapses every commit into a single diff, or do the equivalent<br>
with git log.<br>
<br>
Why doesn&#39;t that work for you?<br></blockquote><div><br></div><div>The =
files changed tab definitely works better for reading. In the past comments=
 I put there have disappeared, but I think that can also be true of comment=
s put on the individual commit reviews (which is another issue with github,=
 but it&#39;s unrelated to how the commits are presented). So I have lost t=
rust in doing reviews that way. It does make things easier to read though.<=
/div>
<div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex">
<div class=3D"im"><span style=3D"color:rgb(34,34,34)">One advantage of usin=
g github is that they&#39;re an independent third</span><br></div>
party; we should think carefully about the risks of furthering the<br>
impression that Bitcoin development is a closed process by moving the<br>
code review it to a server that we control with explicit review groups.<br>=
</blockquote><div><br></div><div>I guess anyone would be able to sign up an=
d comment.</div><div><br></div></div></div></div>

--20cf30223a83ef00a904e7e93d54--