00:00:07 at least now I can possibly make a flow chart of how to do it right 00:00:14 I wonder if that would be helpful 00:00:36 nomailing has quit 00:01:09 hnz has quit 00:01:46 roidster has joined #bitcoin-wizards 00:02:19 certainly 00:06:06 breesy has quit 00:07:05 hnz has joined #bitcoin-wizards 00:09:39 imma work on that then 00:13:44 that should probably be linked directly from https://bitcoin.org/en/development if I may 00:14:28 can i assume a correct implementation of the protocol would allow for spending zero-conf change address TxIns? 00:14:58 optimator_ is now known as optimator 00:15:40 sry, that's way above my level 00:16:14 optimator: that has nothing to do with the protocol (the protocol doesn't know about "change" or "address") 00:16:47 espes__ has quit 00:17:19 espes__ has joined #bitcoin-wizards 00:19:20 JochenKlump has quit 00:22:57 DougieBot5000 has quit 00:23:18 Emcy has quit 00:25:28 tromp_ has joined #bitcoin-wizards 00:25:53 so is it correct to say that spending zero-conf change transactions is a reference client implementation separate from the protocol? 00:26:20 i don't understand what you're asking 00:26:22 ia, ia, cthulhu ftaghn 00:26:28 (ok i stop) 00:26:32 whether you allow that or not is a wallet implementation/policy thing 00:26:40 with benefits and risks 00:27:11 ah ok finally parsed it 00:27:46 sipa: i think that is what I was asking, so it's the wallet implementation, like spending coinbase transactions after 120 confs rather than 100, kinda? 00:28:05 yes, that's also a wallet policy 00:28:12 (in 0.9 it's reduced to 101, btw) 00:28:28 it can't be reduced below 100 though, as that _is_ a protocol rule 00:28:37 way the extra 1? just curious 00:28:40 why 00:29:02 no time to explain... short story: extra protection in some weird edge cases 00:29:10 ty 00:35:41 nanuko has quit 00:40:00 Ursium has quit 00:43:33 Xarian has joined #bitcoin-wizards 00:43:43 Ursium has joined #bitcoin-wizards 00:44:30 Xarikins has quit 00:44:30 freewil has quit 00:44:46 Xarian is now known as Xarikins 00:45:35 antephialtic has joined #bitcoin-wizards 00:54:18 <[\\\]> [\\\] has joined #bitcoin-wizards 01:13:14 antephialtic has quit 01:50:59 jtimon has quit 02:02:59 austinhill has joined #bitcoin-wizards 02:06:55 espes__ has quit 02:07:27 espes__ has joined #bitcoin-wizards 02:19:23 Muis_ has quit 02:19:49 Muis_ has joined #bitcoin-wizards 02:28:58 austinhill1 has joined #bitcoin-wizards 02:32:32 austinhill has quit 02:51:46 austinhill1 has left #bitcoin-wizards 02:51:55 austinhill1 has joined #bitcoin-wizards 02:54:43 spin123456 has joined #bitcoin-wizards 02:54:43 spinza has quit 02:57:32 spinza has joined #bitcoin-wizards 02:58:31 spin123456 has quit 03:46:05 crispy has joined #bitcoin-wizards 03:52:37 Krellan_ has quit 03:53:36 zooko has joined #bitcoin-wizards 03:54:52 crispy1 has joined #bitcoin-wizards 03:56:22 crispy has quit 03:56:47 crispy1 has left #bitcoin-wizards 03:57:02 crispy1 has joined #bitcoin-wizards 03:57:37 crispy1 has left #bitcoin-wizards 03:57:39 crispy1 has joined #bitcoin-wizards 03:58:09 crispy1 has left #bitcoin-wizards 04:00:15 sipa: ping 04:00:23 Is this a bugfix? a42eef6 verify vchPubKey matches calculated public key unless fSkipCheck is set 04:04:34 Luke-Jr, no 04:04:43 Luke-Jr, https://github.com/bitcoin/bitcoin/pull/2950 04:05:17 thx 04:05:57 crispy1 has joined #bitcoin-wizards 04:14:46 crispy1 has quit 04:17:49 crispy has joined #bitcoin-wizards 04:30:39 samson_ has quit 04:35:56 Emcy has joined #bitcoin-wizards 04:36:06 zooko has quit 05:05:30 tromp_ has quit 05:06:03 tromp_ has joined #bitcoin-wizards 05:10:31 tromp_ has quit 05:19:33 orperelman has joined #bitcoin-wizards 05:21:21 crispy has quit 05:24:31 flotsamuel has joined #bitcoin-wizards 05:27:56 Hunger- has joined #bitcoin-wizards 05:32:40 nOgAnOo is now known as nogandoo 05:37:57 nogandoo is now known as nOgAnOo 05:41:23 samson_ has joined #bitcoin-wizards 05:55:28 shinybro_ has joined #bitcoin-wizards 05:55:43 rdymac has quit 05:58:32 rdymac has joined #bitcoin-wizards 06:31:33 shinybro_ has quit 06:38:40 flotsamuel has quit 06:43:15 orperelman has quit 06:51:03 nanuko has joined #bitcoin-wizards 06:53:58 nanuko has quit 07:17:00 Sorcier_FXK has quit 07:49:23 Sorcier_FXK has joined #bitcoin-wizards 07:52:49 RoboTeddy has quit 07:57:06 bizzle has joined #bitcoin-wizards 08:18:06 JochenKlump has joined #bitcoin-wizards 08:20:07 roidster has quit 08:21:30 poeticlobster has quit 08:25:06 <_ingsoc> _ingsoc has joined #bitcoin-wizards 08:25:28 <_ingsoc> _ingsoc has quit 08:25:28 <_ingsoc> _ingsoc has joined #bitcoin-wizards 08:28:12 <_ingsoc> _ingsoc has quit 08:32:00 <_ingsoc> _ingsoc has joined #bitcoin-wizards 08:33:12 RoboTeddy has joined #bitcoin-wizards 08:33:50 RoboTeddy has quit 08:33:56 RoboTedd_ has joined #bitcoin-wizards 08:38:20 Krellan__ has joined #bitcoin-wizards 08:43:55 antephialtic has joined #bitcoin-wizards 08:46:18 Krellan__ has quit 08:46:54 Krellan_ has joined #bitcoin-wizards 08:48:44 Krellan__ has joined #bitcoin-wizards 08:51:17 Krella___ has joined #bitcoin-wizards 08:51:50 Krellan_ has quit 08:53:31 Krellan__ has quit 09:14:42 shinybro_ has joined #bitcoin-wizards 09:18:24 martinBrown has quit 09:18:48 bizzle has quit 09:19:23 bizzle has joined #bitcoin-wizards 09:23:51 bizzle has quit 09:28:11 Muis_ has quit 09:28:13 vdo has joined #bitcoin-wizards 09:30:19 Muis has joined #bitcoin-wizards 09:43:06 <_ingsoc> _ingsoc has quit 10:02:32 <_ingsoc> _ingsoc has joined #bitcoin-wizards 10:04:21 shinybro_ has quit 10:28:17 rdymac has quit 10:29:32 rdymac has joined #bitcoin-wizards 10:31:17 bizzle has joined #bitcoin-wizards 10:34:02 antephialtic has quit 10:36:03 bizzle has quit 10:36:10 antephialtic has joined #bitcoin-wizards 10:37:06 antephialtic has quit 10:37:42 Ursium has quit 10:52:37 antephialtic has joined #bitcoin-wizards 10:52:42 Ursium has joined #bitcoin-wizards 11:01:52 RoboTedd_ has quit 11:09:56 Ursium has quit 11:10:23 antephialtic has quit 11:19:01 gavinandresen_ has joined #bitcoin-wizards 11:21:41 gavinandresen has quit 11:21:41 gavinandresen_ is now known as gavinandresen 11:22:10 <_ingsoc> _ingsoc has quit 11:40:53 antephialtic has joined #bitcoin-wizards 11:49:30 antephialtic has quit 11:55:20 c0rw1n has quit 11:55:38 c0rw1n has joined #bitcoin-wizards 11:56:28 oooooo has quit 12:04:33 oooooo has joined #bitcoin-wizards 12:10:59 rdymac has quit 12:12:32 rdymac has joined #bitcoin-wizards 12:17:09 c0rw1n has quit 12:34:45 nsh has quit 12:40:15 zooko has joined #bitcoin-wizards 12:40:35 jtimon has joined #bitcoin-wizards 12:40:36 breesy has joined #bitcoin-wizards 12:45:27 c0rw1n has joined #bitcoin-wizards 12:45:28 <_ingsoc> _ingsoc has joined #bitcoin-wizards 13:11:42 Ursium has joined #bitcoin-wizards 13:12:34 nsh has joined #bitcoin-wizards 13:15:52 go1111111 has quit 13:21:30 Ursium has quit 13:30:30 Ursium has joined #bitcoin-wizards 13:50:12 <_ingsoc> _ingsoc has quit 13:50:23 <_ingsoc> _ingsoc has joined #bitcoin-wizards 13:59:01 nsh has quit 14:08:43 <_ingsoc> _ingsoc has quit 14:14:01 krypto has quit 14:42:21 breesy has quit 14:58:25 <[\\\]> [\\\] has quit 14:58:56 c0rw1n has quit 15:01:14 orperelman has joined #bitcoin-wizards 15:02:25 <_ingsoc> _ingsoc has joined #bitcoin-wizards 15:06:17 antephialtic has joined #bitcoin-wizards 15:12:08 Ursium has quit 15:21:29 nsh has joined #bitcoin-wizards 15:21:29 nsh has quit 15:21:29 nsh has joined #bitcoin-wizards 15:22:04 antephialtic has quit 15:25:23 c0rw1n has joined #bitcoin-wizards 15:34:31 samson_ has quit 15:36:10 samson_ has joined #bitcoin-wizards 15:38:45 Ursium has joined #bitcoin-wizards 15:46:37 OneFixt_ has joined #bitcoin-wizards 15:49:29 Ursium has quit 15:51:28 jarpiain has joined #bitcoin-wizards 15:51:51 jarpiain is now known as Guest52815 15:53:54 c0rw1n has quit 15:55:34 qwertyoruiop_ has joined #bitcoin-wizards 15:56:32 orperelman1 has joined #bitcoin-wizards 15:56:40 orperelman has quit 15:56:41 oooooo has quit 15:56:43 qwertyoruiop has quit 15:56:43 OneFixt has quit 15:56:44 adam3us has quit 15:56:46 Guest982 has quit 15:57:42 qwertyoruiop_ is now known as qwertyoruiop 15:59:40 imsaguy has quit 16:00:57 imsaguy has joined #bitcoin-wizards 16:01:15 oooooo has joined #bitcoin-wizards 16:03:00 TD has joined #bitcoin-wizards 16:03:40 nanuko has joined #bitcoin-wizards 16:03:58 adam3us has joined #bitcoin-wizards 16:09:57 good evening 16:10:13 so has anyone established what exactly is going on with the network? is this a sybil attack of bogus nodes that are spamming/mutating simultaneously? 16:16:50 TD: whats happing currently? 16:17:59 there's the 25% tx mutation rate, and also the "enjoy sochi" spam 16:18:46 nsh has quit 16:19:06 Ursium has joined #bitcoin-wizards 16:31:08 'enjoy sochi' has been around for a long time afaik, who knows what that is. we are assuming the mutation is a collection of nodes mutating every single tx that they happen across, but afaik nobody has really looked into it.. 16:31:48 enjoy sochi is new to me. if it's been around for a while then there's been a step-up in volume lately, i think 16:32:13 i wonder if the mutation is malicious or the result of a stupid implementation that doesn't roundtrip transactions correctly 16:35:10 well as it started just after the malleability became well known (due to mtgox), I don't think it is accidental 16:36:45 but yeah, AFAIK no one really looked into which nodes are doing this, also because it's so easy to pull off and it's more urgent to make wallets robust against it 16:41:01 Ursium has quit 16:47:59 OneFixt_ is now known as OneFixt 16:49:17 ielo has joined #bitcoin-wizards 16:53:57 nanuko has quit 16:58:45 nsh has joined #bitcoin-wizards 16:58:46 nsh has quit 16:58:46 nsh has joined #bitcoin-wizards 17:02:29 rdymac has quit 17:03:56 rdymac has joined #bitcoin-wizards 17:08:40 ryan-c has quit 17:12:38 ryan-c has joined #bitcoin-wizards 17:17:07 antephialtic has joined #bitcoin-wizards 17:23:08 nanuko has joined #bitcoin-wizards 17:31:29 vdo has quit 17:37:27 nsh has quit 17:42:58 Ursium has joined #bitcoin-wizards 17:51:17 bizzle has joined #bitcoin-wizards 17:52:16 bizzle has quit 17:54:35 DougieBot5000 has joined #bitcoin-wizards 17:55:21 Ursium has quit 18:22:21 orperelman1 has quit 18:25:15 antephialtic has quit 18:25:41 antephialtic has joined #bitcoin-wizards 18:30:36 antephialtic has quit 18:33:02 nanuko has quit 18:33:30 nanuko has joined #bitcoin-wizards 18:34:14 forrestv has quit 18:36:42 forrestv has joined #bitcoin-wizards 18:48:06 TD has quit 18:50:29 nanuko has quit 18:59:58 <_ingsoc> _ingsoc has quit 19:01:25 <_ingsoc> _ingsoc has joined #bitcoin-wizards 19:08:26 rdymac has quit 19:08:39 rdymac has joined #bitcoin-wizards 19:18:03 nomailing has joined #bitcoin-wizards 19:26:47 spin123456 has joined #bitcoin-wizards 19:26:47 spinza has quit 19:37:21 orperelman has joined #bitcoin-wizards 20:00:16 nsh has joined #bitcoin-wizards 20:05:06 nanuko has joined #bitcoin-wizards 20:05:25 nsh has quit 20:05:25 nsh has joined #bitcoin-wizards 20:21:08 flotsamuel has joined #bitcoin-wizards 20:25:23 nanuko has quit 20:35:11 zooko has quit 20:43:13 spinza has joined #bitcoin-wizards 20:45:20 spin123456 has quit 20:48:36 Krella___ has quit 20:48:47 Krellan_ has joined #bitcoin-wizards 20:48:50 <_ingsoc> _ingsoc has quit 20:48:58 zooko has joined #bitcoin-wizards 20:58:56 zooko is now known as zooko-standup 21:04:27 antephialtic has joined #bitcoin-wizards 21:05:35 sipa, how difficult would it be to add a flag to ignore unconfirmed transactions entirely? 21:09:50 zooko-standup is now known as zookowatercooler 21:12:40 phantomcircuit: a one-liner: https://github.com/bitcoin/bitcoin/pull/3657 21:27:15 samson_ has quit 21:27:56 RoboTeddy has joined #bitcoin-wizards 21:32:27 RoboTeddy has quit 21:34:45 antephialtic has quit 21:35:20 antephialtic has joined #bitcoin-wizards 21:35:37 crispy has joined #bitcoin-wizards 21:39:04 RoboTeddy has joined #bitcoin-wizards 21:39:39 antephialtic has quit 21:40:07 go1111111 has joined #bitcoin-wizards 21:41:47 nomailing has quit 21:45:14 samson_ has joined #bitcoin-wizards 21:45:22 wumpus, that is similar to what i was saying, but not exactly the same 21:45:34 with the the unconfirmed mutated transaction is still stored in wallet.dat 21:45:40 which is the longer term issue here 21:48:42 c0rw1n has joined #bitcoin-wizards 21:49:47 storing it is not bad, we absolutely should still store it. 21:49:55 we should never delete records. 21:50:51 gmaxwell, sure... except if i can connect directly to your node its a trivial DoS condition to flood you with IsMine or even IsFromMe mutated txs 21:51:01 phantomcircuit: no its not. 21:51:15 gmaxwell, what i dont get is how someone is managing to even get these relayed, they should largely be blocked as a double spend 21:51:18 we won't accept them unless they show up in a block because we already have the first one. 21:51:28 because the mutant makes it into a block. 21:51:48 gmaxwell, ah so the wallet code already rejects them as a double spend? 21:51:50 speaking of that... /me goes to ping elu to see if he's applied the filtering yet. 21:52:12 phantomcircuit: the basic node code does. (either as a doublespend from the original in the mempool or in the blockchain) 21:52:54 so it's only an issue when the mutant gets into the block instead of the original tx 21:53:00 i guess that makes sense in a way 21:53:22 except the getbalance logic is all fubar from IsConfirmed being weird 21:53:31 and also just from the accounts stuff in general being weird 21:53:35 right, this was why I was attempting to get major pools to deploy the code blocking these things. 21:54:00 no. fucking a he still has not. "doing it now" 21:54:00 gmaxwell, which code? 21:54:13 the canonical push patch. 21:54:37 gmaxwell, im out of the loop on all of this at the moment sitting in a dc surrounded by mining hardware 21:54:48 which reminds me... /me goes to get ear protection 22:00:04 trn has quit 22:00:19 ryan-c has quit 22:06:31 gmaxwell, heh the getbalance logic is something that was on my list of things to fix... you know eventually maybe 22:07:31 trn has joined #bitcoin-wizards 22:08:18 gmaxwell, also is it just me or are the usernames of the commiters on that issue all uuid's except you? 22:08:54 gmaxwell: elu? 22:11:10 ryan-c has joined #bitcoin-wizards 22:11:43 Guest52815 is now known as jarpiain 22:14:30 zookowatercooler is now known as zooko 22:18:15 c0rw1n has quit 22:18:39 Eleuthria 22:19:17 c0rw1n has joined #bitcoin-wizards 22:19:52 ah! 22:30:41 c0rw1n has quit 22:35:08 sipa, would it help to completely remove the silly behavior in IsConfirmed? 22:35:43 gmaxwell, also apparently bitcoinqt will use 0 confirm transactions as inputs but only after it's tried everything else 22:36:39 phantomcircuit, yes. However note the user experience: have 1000 BTC. send 1 BTC. balance drops to zero... 22:36:51 (if unconfirmed are disabled for spends) 22:37:13 jgarzik, i dont believe the second half of the IsConfirmed code ever works currently actually 22:37:42 iirc vtxPrev is always populated with empty CTransaction (CWalletTx?) objects 22:38:01 except in the case where you're spending and receiving 22:38:09 but yeah i guess that's very common with change 22:38:32 (hadn't thought about change) 22:39:24 phantomcircuit: here is my suggestion that i've been making in a few mails already, but maybe not publically 22:39:41 phantomcircuit: consider wallet transactions active when they are either confirmed, or in the mempool 22:40:00 get rid of vtxPrev and vfSpent 22:40:13 keep a multimap of all inputs spent by wallet transactions 22:40:36 and consider a coin as spendable if it is created by an active transaction, and not spent by an active one 22:41:05 as the mempool guarantees perfect consistency with the blockchain and itself, this means no two conflicting transactions can ever be counted at the same time 22:47:31 nOgAnOo is now known as me 22:48:01 me is now known as Guest66919 22:48:36 Guest66919 is now known as nOgAnOo 22:53:10 sipa, i like that 22:53:19 it's clean and wouldn't result in crazy displays to the user 22:53:53 c0rw1n has joined #bitcoin-wizards 22:57:02 shinybro_ has joined #bitcoin-wizards 23:13:21 <[\\\]> [\\\] has joined #bitcoin-wizards 23:25:12 antephialtic has joined #bitcoin-wizards 23:39:33 antephialtic has quit 23:40:08 antephialtic has joined #bitcoin-wizards 23:40:41 shinybro_ has quit 23:44:26 antephialtic has quit 23:50:06 bobke has quit 23:56:34 zooko has quit 23:58:56 bobke has joined #bitcoin-wizards